[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-06-22 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-399541128 Hi @markusthoemmes! Do you have any additional review comments or feedback that need to be addressed

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-06-18 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-398221104 @rabbah It looks like I'm unable to trigger another TravisCI run now that it's been addressed with a new

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-06-18 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-398164636 Thanks @markusthoemmes, that definitely helps express the logic in a concise way

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-06-12 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-396754172 @rabbah Yes, this is ready for review minus a final commit to address the tests (along with a small

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-05-22 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-391098438 @rabbah @csantanapr I've made changes to move the check into Entitlement. Any additional thoughts

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-05-16 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389667020 @csantanapr here are two more explicit use cases. 1) The OW system currently supports nodejs kinds in

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-05-16 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389667020 @csantanapr here's are two more explicit use cases. 1) The OW system currently supports nodejs kinds in

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-05-15 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389353549 Is this a privilege check on a subject or on a resource only? The entirety of the check is that the

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-05-15 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389348864 Sample whitelist to be used in `common/scala/src/main/resources/application.conf` ``` whisk {

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-05-15 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389348864 Sample whitelist to be used in `common/scala/src/main/resources/application.conf` ``` whisk {

[GitHub] asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds

2018-05-15 Thread GitBox
asteed commented on issue #3661: Restrict allowed namespaces when creating action of certain kinds URL: https://github.com/apache/incubator-openwhisk/pull/3661#issuecomment-389348864 Sample whitelist to be used in `common/scala/src/main/resources/application.confapplication.conf` ```