[GitHub] chetanmeh commented on issue #3722: Scala based admin tooling

2018-06-26 Thread GitBox
chetanmeh commented on issue #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#issuecomment-400543679 @dubee Missed on requesting the PG as changes were not impacting the runtime and local build of cli project went fine. However looks like it

[GitHub] chetanmeh commented on issue #3722: Scala based admin tooling

2018-06-26 Thread GitBox
chetanmeh commented on issue #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#issuecomment-400201568 Opened #3808 wrt error messages in case of missing sub commands. This would need some changes in Scallop library used for CLI parsing.

[GitHub] chetanmeh commented on issue #3722: Scala based admin tooling

2018-06-26 Thread GitBox
chetanmeh commented on issue #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#issuecomment-400200513 > will we be able to add tab completion to wskadmin-next Currently Scallop does not support that. Would be an interesting feature to add

[GitHub] chetanmeh commented on issue #3722: Scala based admin tooling

2018-06-26 Thread GitBox
chetanmeh commented on issue #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#issuecomment-400199062 > We should probably prune these error logs. Those logs were coming because Http connection pool was not getting closed. So closing them

[GitHub] chetanmeh commented on issue #3722: Scala based admin tooling

2018-06-26 Thread GitBox
chetanmeh commented on issue #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#issuecomment-400198899 > wskadmin] Error: File './wskadmin.conf' not found This was happening because the [Spring Boot Launch Script][1] changes the base

[GitHub] chetanmeh commented on issue #3722: Scala based admin tooling

2018-06-26 Thread GitBox
chetanmeh commented on issue #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#issuecomment-400197481 > Should we suppress the stack trace - in this case the error message is useful enough. Perhaps a -d debug flag to emit the trace. Makes

[GitHub] chetanmeh commented on issue #3722: Scala based admin tooling

2018-06-19 Thread GitBox
chetanmeh commented on issue #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#issuecomment-398493802 > Can the existing wskadmin tests pass against wskadmin-next May be not all as in some cases the message format may have changed. Would

[GitHub] chetanmeh commented on issue #3722: Scala based admin tooling

2018-06-12 Thread GitBox
chetanmeh commented on issue #3722: Scala based admin tooling URL: https://github.com/apache/incubator-openwhisk/pull/3722#issuecomment-396551429 @rabbah @markusthoemmes This PR is now ready for review. Currently it supports all of `user` and `limits` command. Dumping db content