dubee commented on a change in pull request #3913: Bump kafka-clients version
to 2.0.0.
URL:
https://github.com/apache/incubator-openwhisk/pull/3913#discussion_r206136617
##########
File path:
common/scala/src/main/scala/whisk/connector/kafka/KafkaConsumerConnector.scala
##########
@@ -69,7 +70,7 @@ class KafkaConsumerConnector(
val wakeUpTask =
actorSystem.scheduler.scheduleOnce(cfg.sessionTimeoutMs.milliseconds +
1.second)(consumer.wakeup())
try {
- val response = consumer.poll(duration.toMillis).asScala
+ val response = consumer.poll(duration).asScala
Review comment:
Is wakeup still needed with the new poll method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
