[GitHub] dubeejw commented on a change in pull request #176: Only fetch action code when saving an action

[GitBox]

dubeejw commented on a change in pull request #176: Only fetch action code when 
saving an action
URL: 
https://github.com/apache/incubator-openwhisk-cli/pull/176#discussion_r170769779
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskActionTests.scala
 ##
 @@ -230,8 +230,6 @@ abstract class WskActionTests extends TestHelpers with 
WskTestHelpers with JsHel
 assetHelper.withCleaner(wsk.action, name) { (action, _) =>
   action.create(name, Some(TestCLIUtils.getTestActionFilename("empty.js")))
 }
-val rr = wsk.action.get(name)
-wsk.parseJsonString(rr.stdout).getFieldPath("exec", "code") shouldBe 
Some(JsString(""))
 
 Review comment:
   Validation happens above these lines during the create as a 200 status code 
is returned. Also there is a REST test here 
https://github.com/apache/incubator-openwhisk/blob/master/tests/src/test/scala/system/basic/WskActionTests.scala#L227.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #176: Only fetch action code when saving an action

[GitBox]

dubeejw commented on a change in pull request #176: Only fetch action code when 
saving an action
URL: 
https://github.com/apache/incubator-openwhisk-cli/pull/176#discussion_r170769831
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskBasicTests.scala
 ##
 @@ -313,7 +313,7 @@ class WskBasicTests extends TestHelpers with 
WskTestHelpers {
   wsk.action.get(name, fieldFilter = Some("exec")).stdout should 
include(s"""$successMsg""")
   wsk.action
 .get(name, fieldFilter = Some("exec"))
-.stdout should include regex (s"""$successMsg 
exec\n\\{\\s+"kind":\\s+"nodejs:6",\\s+"code":\\s+"\\/\\*\\*[r]*n \\* 
Hello, world.[r]*n \\*\\/[r]*nfunction main\\(params\\) 
\\{[r]*ngreeting \\= 'hello, ' \\+ params.payload \\+ 
'!'[r]*nconsole.log\\(greeting\\);[r]*nreturn 
\\{payload: greeting\\}[r]*n\\}""")
+.stdout should include regex (s"""$successMsg 
exec\n\\{\\s+"kind":\\s+"nodejs:6",\\s+"binary":\\s+false\\s+\\}""")
 
 Review comment:
   It's new to the CLI.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dubeejw commented on a change in pull request #176: Only fetch action code when saving an action

[GitBox]

dubeejw commented on a change in pull request #176: Only fetch action code when 
saving an action
URL: 
https://github.com/apache/incubator-openwhisk-cli/pull/176#discussion_r170769779
 
 

 ##
 File path: tests/src/test/scala/system/basic/WskActionTests.scala
 ##
 @@ -230,8 +230,6 @@ abstract class WskActionTests extends TestHelpers with 
WskTestHelpers with JsHel
 assetHelper.withCleaner(wsk.action, name) { (action, _) =>
   action.create(name, Some(TestCLIUtils.getTestActionFilename("empty.js")))
 }
-val rr = wsk.action.get(name)
-wsk.parseJsonString(rr.stdout).getFieldPath("exec", "code") shouldBe 
Some(JsString(""))
 
 Review comment:
   Validation happens above these lines during the create as a 200 status code 
is returned. Also three is a REST test here 
https://github.com/apache/incubator-openwhisk/blob/master/tests/src/test/scala/system/basic/WskActionTests.scala#L227.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services