[GitHub] lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs
lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-365403918 Am I blocking this? I _think_ I've answered all the comments and this PR is ripe for another review, but please let me know if there's anything I should be doing at this end This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs
lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-363866122 Some really good review comments here, can we review ALL the docs like this? :) I think we're really improving what's there. I've taken all the comments above into account, tried to improve the introduction and head off some common confusion about parameters, and moved the file parameter stuff to its own section. Also linked to the other language examples from the parameters page, and to the parameters page in the first location that parameters are used on the main actions page. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs
lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-363392611 I _thought_ I had linked to the parameters doc from everywhere where there already was (or I thought there should be) mention of parameters. @rabbah is there somewhere in particular where you feel this information belongs and is missing? I can add it but I'm not sure where. Thanks for the other comments as well, I'll revisit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs
lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-363378267 What a lovely thorough review! Changes made as requested. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
