pritidesai opened a new issue #773: How to address go get failures due to 
breaking changes in Go Client?
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/773
 
 
   There was a change in the function signature of Get action in 
apache/incubator-openwhisk-client-go@72bf712
   
   ```
   -func (s *ActionService) Get(actionName string) (*Action, *http.Response, 
error) {
   +func (s *ActionService) Get(actionName string, fetchCode bool) (*Action, 
*http.Response, error) {
   ```
   
   `fetchCode` was added to determine whether to return function code or not on 
a `GET` call. This is just one simple change which was breaking `go get`:
   
   ```
   go get GitHub.com/apache/incubator-openwhisk-wskdeploy
   # github.com/apache/incubator-openwhisk-wskdeploy/deployers
   
go/src/github/apache/incubator-openwhisk-wskdeploy/deployers/servicedeployer.go:1334:44:
 not enough arguments in call to deployer.Client.Actions.Get
           have (string)
           want (string, bool)
   ```
   
   This kind of change wouldn't break `wskdeploy` travis builds as we specify 
dependencies in `GoDeps` file. How to enforce those dependency versions in `go 
get`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to