[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-389926238 @Himavanth thanks for the thumbs up - will close in favor of new PR.

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-389755413 @Himavanth take a look at this branch:

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-388403914 @csantanapr this will need a PG. I'll go through it today or this weekend but it's good enough for jenkins.

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-376820612 Yep. Opinion/feedback/suggestions welcomed. This is an

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-374462780 Thinking through this a bit more - because it will have breaking changes to downstream projects, I think we should do the break

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-372168758 Yes. We?d like to get this in for sure. This is an automated

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-370094992 @hsane2001 can you open an issue to discuss the desired feature. I think the approach here establishes a bit of the foundation

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-363973980 Yes. That was my suggestion above (https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688). We

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-363974176 We should seperate the multiple cell support into a seperate PR. Here it sufficies to export the kind to a pure config setting

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-363974176 We should seperate the multiple cell support into a seperate PR. Here it sufficies to export the kind to a pure config setting

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-363973980 Yes. That was my suggestion above (https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688).

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361312490 Thanks for the contribution - do you have an Apache ICLA on file?

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688 I'd suggest in addition making the configuration a set of stem cells (vs a single kind). It might look something like this:

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688 I'd suggest in addition making the configuration a set of stem cells (vs a single kind). It might look something like this:

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688 I'd suggest in addition making the configuration a set of stem cells (vs a single kind). It might look something like this:

[GitHub] rabbah commented on issue #3232: Making prewarm kind (and count) configurable

rabbah commented on issue #3232: Making prewarm kind (and count) configurable URL: https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688 I'd suggest in addition making the configuration a set of stem cells (vs a single kind). It might look something like this: