[GitHub] rabbah commented on issue #3340: Default activation response to empty JsObject.

2018-02-24 Thread GitBox 
rabbah commented on issue #3340: Default activation response to empty JsObject.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3340#issuecomment-368229792
 
 
   Travis is enough - The result = None is not observable unless there's an 
invariant violation which the loop back likely introduced (I suppose the 
loopback returns a WhiskActivation() for example).
   
   The defensive code is not harmful.
   
   It would be nice to tighten further but I think it's equally OK to treat a 
missing result as `{}`... until we want to support `JsNull` as a possible 
response as well (related to sequence semantics).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3340: Default activation response to empty JsObject.

2018-02-24 Thread GitBox 
rabbah commented on issue #3340: Default activation response to empty JsObject.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3340#issuecomment-368229792
 
 
   Travis is enough - The result = None is not observable unless there's an 
invariant violation; returning result = None and a full activation instead of 
an id (I suppose the loopback returns a WhiskActivation() here for example). 
   
   It would be nice to tighten but I think it's equally OK to treat a missing 
result as `{}`... until we want to support `JsNull` as a possible response as 
well (related to sequence semantics).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3340: Default activation response to empty JsObject.

2018-02-23 Thread GitBox 
rabbah commented on issue #3340: Default activation response to empty JsObject.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3340#issuecomment-368150368
 
 
   could be... or remove the option and use an empty object. None is used on 
the non-blocking path so the result doesn?t matter. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3340: Default activation response to empty JsObject.

2018-02-23 Thread GitBox 
rabbah commented on issue #3340: Default activation response to empty JsObject.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3340#issuecomment-368144952
 
 
   This is OK - where are we using the response result though incorrectly; 
isn't there another bug?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services