[
https://issues.apache.org/jira/browse/ORC-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333286#comment-16333286
]
ASF GitHub Bot commented on ORC-293:
------------------------------------
Github user xndai commented on a diff in the pull request:
https://github.com/apache/orc/pull/212#discussion_r162789950
--- Diff: c++/include/orc/Common.hh ---
@@ -69,7 +69,7 @@ namespace orc {
UNKNOWN_WRITER = INT32_MAX
};
- enum CompressionKind {
+ enum CompressionKind : std::int64_t {
--- End diff --
The definition of CompressionKind_MAX already makes CompressionKind a int64
type. Enum base type is a C++ 11 feature and should at least be configurable
through orc-config.hh
> RleEncoderV1::writeVulong works incorrectly if (sizeof(long) <
> sizeof(int64_t))
> -------------------------------------------------------------------------------
>
> Key: ORC-293
> URL: https://issues.apache.org/jira/browse/ORC-293
> Project: ORC
> Issue Type: Bug
> Components: C++
> Reporter: rip.nsk
> Assignee: rip.nsk
> Priority: Blocker
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
