[jira] [Commented] (ORC-302) Reader: all NULL + isRepeating should NULL out 1st row

2018-02-20 Thread Gopal V (JIRA)

[ 
https://issues.apache.org/jira/browse/ORC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370448#comment-16370448
 ] 

Gopal V commented on ORC-302:
-

This is about the value vector, not isNull and assumptions about 
LongColumnVector.NULL_VALUE in Vectorization code written back in 2013.


> Reader: all NULL + isRepeating should NULL out 1st row
> --
>
> Key: ORC-302
> URL: https://issues.apache.org/jira/browse/ORC-302
> Project: ORC
>  Issue Type: Bug
>Affects Versions: 1.4.3, 1.5.0
>Reporter: Gopal V
>Priority: Major
>
> ORC-285 fixed this for Double, but not for other types.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ORC-304) Fix TestRecordReaderImpl to not fail with new storage-api

2018-02-20 Thread Owen O'Malley (JIRA)

 [ 
https://issues.apache.org/jira/browse/ORC-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Owen O'Malley updated ORC-304:
--
Fix Version/s: 1.4.4

> Fix TestRecordReaderImpl to not fail with new storage-api
> -
>
> Key: ORC-304
> URL: https://issues.apache.org/jira/browse/ORC-304
> Project: ORC
>  Issue Type: Test
>Reporter: Owen O'Malley
>Assignee: Owen O'Malley
>Priority: Major
> Fix For: 1.4.4, 1.5.0
>
>
> Hive's storage-api has changed so that with diskRanges with doMerge = false 
> will fail if the ranges overlap. We also call with doMerge = true in the 
> reader, but the tests use doMerge = false. I propose that we change this so 
> that the tests all use doMerge = true also.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ORC-302) Reader: all NULL + isRepeating should NULL out 1st row

2018-02-20 Thread Owen O'Malley (JIRA)

[ 
https://issues.apache.org/jira/browse/ORC-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370446#comment-16370446
 ] 

Owen O'Malley commented on ORC-302:
---

Can you give me an example Gopal? Do you mean columns that don't have any 
values? If they have all nulls, it sets the isNull vector correctly.

> Reader: all NULL + isRepeating should NULL out 1st row
> --
>
> Key: ORC-302
> URL: https://issues.apache.org/jira/browse/ORC-302
> Project: ORC
>  Issue Type: Bug
>Affects Versions: 1.4.3, 1.5.0
>Reporter: Gopal V
>Priority: Major
>
> ORC-285 fixed this for Double, but not for other types.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)