[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp

2020-04-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#discussion_r406614653 ## File path:

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp

2020-04-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#discussion_r406611949 ## File path:

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp

2020-04-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#discussion_r406613824 ## File path:

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp

2020-04-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#discussion_r406611949 ## File path:

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp

2020-04-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#discussion_r406611279 ## File path:

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp

2020-04-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#discussion_r406608036 ## File path:

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp

2020-04-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#discussion_r406607709 ## File path:

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp

2020-04-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#discussion_r406605780 ## File path:

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp

2020-04-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#discussion_r406605821 ## File path:

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp

2020-04-09 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#discussion_r406605714 ## File path:

[GitHub] [phoenix] yanxinyi closed pull request #583: PHOENIX-5470 Tool to find view corruption

2020-04-09 Thread GitBox
yanxinyi closed pull request #583: PHOENIX-5470 Tool to find view corruption URL: https://github.com/apache/phoenix/pull/583 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [phoenix] yanxinyi closed pull request #585: PHOENIX-5470 Tool to find view corruption

2020-04-09 Thread GitBox
yanxinyi closed pull request #585: PHOENIX-5470 Tool to find view corruption URL: https://github.com/apache/phoenix/pull/585 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [phoenix] yanxinyi commented on issue #585: PHOENIX-5470 Tool to find view corruption

2020-04-09 Thread GitBox
yanxinyi commented on issue #585: PHOENIX-5470 Tool to find view corruption URL: https://github.com/apache/phoenix/pull/585#issuecomment-611873181 close this PR since I plan to implement this tool as part of phck. This is an

[GitHub] [phoenix] dbwong closed pull request #742: Phoenix-5797 RVC Offset does not work with tenant views on global indexes

2020-04-09 Thread GitBox
dbwong closed pull request #742: Phoenix-5797 RVC Offset does not work with tenant views on global indexes URL: https://github.com/apache/phoenix/pull/742 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (PHOENIX-5818) Add documentation for query timeoutDuration attribute in Pherf scenarios

2020-04-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080125#comment-17080125 ] Hadoop QA commented on PHOENIX-5818: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-5804) Implement strong verification with -v ONLY option for old design of secondary indexes

2020-04-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080123#comment-17080123 ] Hadoop QA commented on PHOENIX-5804: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-4521) Allow Pherf scenario to define per query max allowed query execution duration after which thread is interrupted

2020-04-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080117#comment-17080117 ] Hadoop QA commented on PHOENIX-4521: {color:red}-1 overall{color}. Here are the results of testing

[GitHub] [phoenix] swaroopak opened a new pull request #758: PHOENIX-5804: Implement strong verification with -v ONLY option for o…

2020-04-09 Thread GitBox
swaroopak opened a new pull request #758: PHOENIX-5804: Implement strong verification with -v ONLY option for o… URL: https://github.com/apache/phoenix/pull/758 …ld design of secondary indexes 1. More verification logic in Integration tests 2. Missing index row scenario in

[GitHub] [phoenix] jpisaac commented on issue #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp

2020-04-09 Thread GitBox
jpisaac commented on issue #724: PHOENIX-5629 Phoenix Function to Return HBase row timestamp URL: https://github.com/apache/phoenix/pull/724#issuecomment-611813507 @swaroopak @ChinmaySKulkarni @yanxinyi Please review the updates.

[jira] [Commented] (PHOENIX-5812) Automatically Close "Idle" Long Open Connections

2020-04-09 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080099#comment-17080099 ] Josh Elser commented on PHOENIX-5812: - bq. The reason is, PConnection if not closed, for 1) it will

[jira] [Commented] (PHOENIX-5812) Automatically Close "Idle" Long Open Connections

2020-04-09 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080049#comment-17080049 ] Mingliang Liu commented on PHOENIX-5812: [~elserj] and [~jisaac] Yes the context I have is

[GitHub] [phoenix-queryserver] joshelser commented on issue #25: PHOENIX-5827 Add a maven repo to PQS

2020-04-09 Thread GitBox
joshelser commented on issue #25: PHOENIX-5827 Add a maven repo to PQS URL: https://github.com/apache/phoenix-queryserver/pull/25#issuecomment-611748073 ab18594 pushes the phoenix-client bundling into a profile, and adds some documentation. However, the problem with this all is

[jira] [Commented] (PHOENIX-5789) try to standardize on a JSON library

2020-04-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079977#comment-17079977 ] Hadoop QA commented on PHOENIX-5789: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-5799) Inline Index Verification Output API

2020-04-09 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079957#comment-17079957 ] Geoffrey Jacoby commented on PHOENIX-5799: -- [~stoty]- Shouldn't CompatUtil.setStopRow for 1.3

[GitHub] [phoenix-connectors] stoty commented on issue #16: PHOENIX-5684 PHOENIX-5683

2020-04-09 Thread GitBox
stoty commented on issue #16: PHOENIX-5684 PHOENIX-5683 URL: https://github.com/apache/phoenix-connectors/pull/16#issuecomment-611660096 merged This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (PHOENIX-5812) Automatically Close "Idle" Long Open Connections

2020-04-09 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079564#comment-17079564 ] Josh Elser commented on PHOENIX-5812: - bq. Since this was related PHOENIX-5802, assumed it was

[jira] [Commented] (PHOENIX-5771) Make standalone queryserver assembly useful again

2020-04-09 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079547#comment-17079547 ] Istvan Toth commented on PHOENIX-5771: -- Based on a discussion with [~elserj], the current

[GitHub] [phoenix-queryserver] joshelser commented on issue #25: PHOENIX-5827 Add a maven repo to PQS

2020-04-09 Thread GitBox
joshelser commented on issue #25: PHOENIX-5827 Add a maven repo to PQS URL: https://github.com/apache/phoenix-queryserver/pull/25#issuecomment-611621932 > Generate a bare-bones assembly be default. A profile that generates a full-fat assembly, with phoenix-client included in the PQS

[GitHub] [phoenix-queryserver] stoty commented on issue #25: PHOENIX-5827 Add a maven repo to PQS

2020-04-09 Thread GitBox
stoty commented on issue #25: PHOENIX-5827 Add a maven repo to PQS URL: https://github.com/apache/phoenix-queryserver/pull/25#issuecomment-611611102 The queryserver assembly is a mess in every way. I have PHOENIX-5829 (opened today) and PHOENIX-5771 open for these issues. The

[jira] [Commented] (PHOENIX-5799) Inline Index Verification Output API

2020-04-09 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079508#comment-17079508 ] Istvan Toth commented on PHOENIX-5799: -- Unfortunately I cannot think of anything simpler than

[jira] [Commented] (PHOENIX-5799) Inline Index Verification Output API

2020-04-09 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079490#comment-17079490 ] Geoffrey Jacoby commented on PHOENIX-5799: -- Oops, sorry about that. Will get this fixed today.

[GitHub] [phoenix-connectors] joshelser commented on issue #16: PHOENIX-5684 PHOENIX-5683

2020-04-09 Thread GitBox
joshelser commented on issue #16: PHOENIX-5684 PHOENIX-5683 URL: https://github.com/apache/phoenix-connectors/pull/16#issuecomment-611589945 That'd be great, thanks Istvan. This is an automated message from the Apache Git

[GitHub] [phoenix-queryserver] joshelser commented on issue #25: PHOENIX-5827 Add a maven repo to PQS

2020-04-09 Thread GitBox
joshelser commented on issue #25: PHOENIX-5827 Add a maven repo to PQS URL: https://github.com/apache/phoenix-queryserver/pull/25#issuecomment-611584928 > Given that the PQS server artifact is supposed to be phoenix and HBase version agnostic I think that we should not add the thick

[GitHub] [phoenix-connectors] stoty commented on issue #16: PHOENIX-5684 PHOENIX-5683

2020-04-09 Thread GitBox
stoty commented on issue #16: PHOENIX-5684 PHOENIX-5683 URL: https://github.com/apache/phoenix-connectors/pull/16#issuecomment-611575692 This looks useful. Do you want me to rebase and commit this @joshelser ? This is an

[GitHub] [phoenix-queryserver] stoty commented on issue #11: PHOENIX-5234 Create patch scripts for phoenix-connectors and phoenix-queryserver projects

2020-04-09 Thread GitBox
stoty commented on issue #11: PHOENIX-5234 Create patch scripts for phoenix-connectors and phoenix-queryserver projects URL: https://github.com/apache/phoenix-queryserver/pull/11#issuecomment-611571778 This has already been merged. The PR can be closed.

[jira] [Commented] (PHOENIX-5789) try to standardize on a JSON library

2020-04-09 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079442#comment-17079442 ] Istvan Toth commented on PHOENIX-5789: -- YW. Please also rebase the patch to the current master,

[jira] [Comment Edited] (PHOENIX-5789) try to standardize on a JSON library

2020-04-09 Thread Richard Antal (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079435#comment-17079435 ] Richard Antal edited comment on PHOENIX-5789 at 4/9/20, 2:43 PM: - Thank

[jira] [Commented] (PHOENIX-5789) try to standardize on a JSON library

2020-04-09 Thread Richard Antal (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079435#comment-17079435 ] Richard Antal commented on PHOENIX-5789: Thank you for the [~stoty] for checking the patch. >

[jira] [Commented] (PHOENIX-5811) Synchronise Phoenix dependencies to match Hbase dependency versions

2020-04-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079433#comment-17079433 ] Hudson commented on PHOENIX-5811: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3735

[jira] [Commented] (PHOENIX-5789) try to standardize on a JSON library

2020-04-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079432#comment-17079432 ] Hadoop QA commented on PHOENIX-5789: {color:red}-1 overall{color}. Here are the results of testing

[GitHub] [phoenix-queryserver] stoty commented on issue #26: PHOENIX-5830 Fix python printing in query-server

2020-04-09 Thread GitBox
stoty commented on issue #26: PHOENIX-5830 Fix python printing in query-server URL: https://github.com/apache/phoenix-queryserver/pull/26#issuecomment-611563407 Merged This is an automated message from the Apache Git

[GitHub] [phoenix-queryserver] stoty closed pull request #26: PHOENIX-5830 Fix python printing in query-server

2020-04-09 Thread GitBox
stoty closed pull request #26: PHOENIX-5830 Fix python printing in query-server URL: https://github.com/apache/phoenix-queryserver/pull/26 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [phoenix-queryserver] stoty commented on issue #26: PHOENIX-5830 Fix python printing in query-server

2020-04-09 Thread GitBox
stoty commented on issue #26: PHOENIX-5830 Fix python printing in query-server URL: https://github.com/apache/phoenix-queryserver/pull/26#issuecomment-611562383 +1 LGTM This is an automated message from the Apache Git

[jira] [Commented] (PHOENIX-5789) try to standardize on a JSON library

2020-04-09 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079386#comment-17079386 ] Istvan Toth commented on PHOENIX-5789: -- Please fix this shaded guava import that your IDE has

[jira] [Commented] (PHOENIX-5825) Remove PhoenixCanaryTool and CanaryTestResult from phoenix repo

2020-04-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079308#comment-17079308 ] Hudson commented on PHOENIX-5825: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3734

[jira] [Commented] (PHOENIX-5656) Make Phoenix scripts work with Python 3

2020-04-09 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079300#comment-17079300 ] Hadoop QA commented on PHOENIX-5656: {color:red}-1 overall{color}. Here are the results of testing

[GitHub] [phoenix-queryserver] richardantal opened a new pull request #26: PHOENIX-5830 Fix python printing in query-server

2020-04-09 Thread GitBox
richardantal opened a new pull request #26: PHOENIX-5830 Fix python printing in query-server URL: https://github.com/apache/phoenix-queryserver/pull/26 This is an automated message from the Apache Git Service. To respond to

[GitHub] [phoenix-queryserver] stoty commented on issue #25: PHOENIX-5827 Add a maven repo to PQS

2020-04-09 Thread GitBox
stoty commented on issue #25: PHOENIX-5827 Add a maven repo to PQS URL: https://github.com/apache/phoenix-queryserver/pull/25#issuecomment-611413668 Given that the PQS server artifact is supposed to be phoenix and HBase version agnostic I think that we should not add the thick client repo

[jira] [Commented] (PHOENIX-5799) Inline Index Verification Output API

2020-04-09 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079021#comment-17079021 ] Istvan Toth commented on PHOENIX-5799: -- [~gjacoby] This breaks builds with the HBase 1.3 profile.

[GitHub] [phoenix] stoty closed pull request #755: PHOENIX-5825 Remove PhoenixCanaryTool and CanaryTestResult from phoen…

2020-04-09 Thread GitBox
stoty closed pull request #755: PHOENIX-5825 Remove PhoenixCanaryTool and CanaryTestResult from phoen… URL: https://github.com/apache/phoenix/pull/755 This is an automated message from the Apache Git Service. To respond to

[GitHub] [phoenix-queryserver] stoty closed pull request #24: PHOENIX-5824 Add dependency:analyze to queryserver build

2020-04-09 Thread GitBox
stoty closed pull request #24: PHOENIX-5824 Add dependency:analyze to queryserver build URL: https://github.com/apache/phoenix-queryserver/pull/24 This is an automated message from the Apache Git Service. To respond to the