[GitHub] [phoenix] sakshamgangwar commented on pull request #858: PHOENIX-6078 Remove Internal Phoenix Connections from parent LinkedQueue when closed

2020-08-14 Thread GitBox
sakshamgangwar commented on pull request #858: URL: https://github.com/apache/phoenix/pull/858#issuecomment-674315972 > Please open up follow up jira for unhappy path handling. Thanks. @dbwong added that here: https://issues.apache.org/jira/browse/PHOENIX-6079

[GitHub] [phoenix] dbwong commented on pull request #858: PHOENIX-6078 Remove Internal Phoenix Connections from parent LinkedQueue when closed

2020-08-14 Thread GitBox
dbwong commented on pull request #858: URL: https://github.com/apache/phoenix/pull/858#issuecomment-674315541 Please open up follow up jira for unhappy path handling. Thanks. This is an automated message from the Apache Git

[GitHub] [phoenix] sakshamgangwar opened a new pull request #858: PHOENIX-6078 Remove Internal Phoenix Connections from parent LinkedQueue when closed

2020-08-14 Thread GitBox
sakshamgangwar opened a new pull request #858: URL: https://github.com/apache/phoenix/pull/858 https://issues.apache.org/jira/browse/PHOENIX-6078 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (PHOENIX-6077) PHOENIX-5946 breaks mvn verify

2020-08-14 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178000#comment-17178000 ] Istvan Toth commented on PHOENIX-6077: -- Thanks for the review [~swaroopa]. Yes it's needed for

[GitHub] [phoenix] stoty commented on pull request #857: PHOENIX-5881 - Port PHOENIX-5645 (MaxLookbackAge) to 5.x

2020-08-14 Thread GitBox
stoty commented on pull request #857: URL: https://github.com/apache/phoenix/pull/857#issuecomment-674203202 In 4.x we use org.apache.phoenix.compat.hbase.HbaseCompatCapabilities for the feature flags, It would be more consistent to move the feature flags there. I did not go through

[jira] [Commented] (PHOENIX-6077) PHOENIX-5946 breaks mvn verify

2020-08-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177972#comment-17177972 ] Hadoop QA commented on PHOENIX-6077: {color:red}-1 overall{color}. Here are the results of testing

[GitHub] [phoenix] gjacoby126 commented on pull request #857: PHOENIX-5881 - Port PHOENIX-5645 (MaxLookbackAge) to 5.x

2020-08-14 Thread GitBox
gjacoby126 commented on pull request #857: URL: https://github.com/apache/phoenix/pull/857#issuecomment-674184771 @stoty - I'm curious about your opinion on how I'm using your compatibility projects to get version-specific coproc logic, plus version-specific feature flags.

[GitHub] [phoenix] gjacoby126 commented on pull request #857: PHOENIX-5881 - Port PHOENIX-5645 (MaxLookbackAge) to 5.x

2020-08-14 Thread GitBox
gjacoby126 commented on pull request #857: URL: https://github.com/apache/phoenix/pull/857#issuecomment-674182171 Note that since HBase 2.1 and HBase 2.2 lack HBASE-24321, a lot of the logic is behind a 2.3 compatibility shim.

[GitHub] [phoenix] gjacoby126 opened a new pull request #857: PHOENIX-5881 - Port PHOENIX-5645 (MaxLookbackAge) to 5.x

2020-08-14 Thread GitBox
gjacoby126 opened a new pull request #857: URL: https://github.com/apache/phoenix/pull/857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (PHOENIX-5872) Close Internal Phoenix Connections that were running during cancel

2020-08-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177865#comment-17177865 ] Hadoop QA commented on PHOENIX-5872: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-6077) PHOENIX-5946 breaks mvn verify

2020-08-14 Thread Swaroopa Kadam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177860#comment-17177860 ] Swaroopa Kadam commented on PHOENIX-6077: - Thank you for the patch [~stoty]. I assume this

[jira] [Commented] (PHOENIX-5946) Implement SchemaExtractionTool utility to get effective DDL from cluster

2020-08-14 Thread Swaroopa Kadam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177849#comment-17177849 ] Swaroopa Kadam commented on PHOENIX-5946: - [~stoty] I am supposed to share one-pager on

[GitHub] [phoenix-connectors] stoty commented on a change in pull request #26: PHOENIX-6076 Refactor Phoenix Hive Connectors introduced by PHOENIX-6057

2020-08-14 Thread GitBox
stoty commented on a change in pull request #26: URL: https://github.com/apache/phoenix-connectors/pull/26#discussion_r470619252 ## File path: phoenix-hive-base/src/main/java/org/apache/phoenix/hive/util/PhoenixStorageHandlerUtilBase.java ## @@ -20,18 +20,27 @@ import

[jira] [Commented] (PHOENIX-6010) Create phoenix-thirdparty, and consume guava through it

2020-08-14 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177751#comment-17177751 ] Istvan Toth commented on PHOENIX-6010: -- I've tried to push new snapshot for Tephra and Omid, but I

[jira] [Commented] (PHOENIX-6056) Migrate from builds.apache.org by August 15

2020-08-14 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177737#comment-17177737 ] Istvan Toth commented on PHOENIX-6056: -- I had to move the Precommit jo to the root of the Master,

[jira] [Commented] (PHOENIX-6077) PHOENIX-5946 breaks mvn verify

2020-08-14 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177724#comment-17177724 ] Istvan Toth commented on PHOENIX-6077: -- Re-uploaded patch to try to trigger new PreCommit script.

[jira] [Commented] (PHOENIX-6077) PHOENIX-5946 breaks mvn verify

2020-08-14 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177644#comment-17177644 ] Istvan Toth commented on PHOENIX-6077: -- Please review [~swaroopa]. > PHOENIX-5946 breaks mvn

[jira] [Commented] (PHOENIX-5946) Implement SchemaExtractionTool utility to get effective DDL from cluster

2020-08-14 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177637#comment-17177637 ] Istvan Toth commented on PHOENIX-5946: -- [~swaroopa] What is the reason for creating a new

[GitHub] [phoenix] stoty opened a new pull request #856: PHOENIX-6077 PHOENIX-5946 breaks mvn verify

2020-08-14 Thread GitBox
stoty opened a new pull request #856: URL: https://github.com/apache/phoenix/pull/856 make sure IT is run by maven replace commomns-lang with commons-lang3 like in the rest of Phoenix POM cleanups This is an automated

[GitHub] [phoenix-connectors] richardantal opened a new pull request #26: PHOENIX-6076 Refactor Phoenix Hive Connectors introduced by PHOENIX-6057

2020-08-14 Thread GitBox
richardantal opened a new pull request #26: URL: https://github.com/apache/phoenix-connectors/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Issue Comment Deleted] (PHOENIX-6076) Refactor Phoenix Hive Connectors introduced by PHOENIX-6057

2020-08-14 Thread Richard Antal (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Antal updated PHOENIX-6076: --- Comment: was deleted (was: This refactor should add Hive 2 support as well.) > Refactor

[jira] [Commented] (PHOENIX-6076) Refactor Phoenix Hive Connectors introduced by PHOENIX-6057

2020-08-14 Thread Richard Antal (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177595#comment-17177595 ] Richard Antal commented on PHOENIX-6076: This refactor should add Hive 2 support as well. >