stoty closed pull request #884:
URL: https://github.com/apache/phoenix/pull/884
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gjacoby126 commented on a change in pull request #864:
URL: https://github.com/apache/phoenix/pull/864#discussion_r489752459
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##
@@ -3629,14 +3632,25 @@ private void
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197241#comment-17197241
]
Lars Hofhansl commented on PHOENIX-5712:
[~yanxinyi] are you planning to work on this?
> Got
[
https://issues.apache.org/jira/browse/PHOENIX-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197240#comment-17197240
]
Hadoop QA commented on PHOENIX-6119:
{color:red}-1 overall{color}. Here are the results of testing
priyankporwal commented on a change in pull request #864:
URL: https://github.com/apache/phoenix/pull/864#discussion_r489748474
##
File path: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
##
@@ -1524,6 +1525,40 @@ public Integer getBucketNum() {
priyankporwal commented on a change in pull request #864:
URL: https://github.com/apache/phoenix/pull/864#discussion_r489743628
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
##
@@ -528,8 +528,9 @@ public SQLException
[
https://issues.apache.org/jira/browse/PHOENIX-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197220#comment-17197220
]
Chinmay Kulkarni commented on PHOENIX-6072:
---
Thanks for the reviews in
ChinmaySKulkarni commented on pull request #883:
URL: https://github.com/apache/phoenix/pull/883#issuecomment-693643381
@jpisaac verified that the TTL is honored when modified via admin API
This is an automated message from
ChinmaySKulkarni commented on pull request #883:
URL: https://github.com/apache/phoenix/pull/883#issuecomment-693643215
Thanks for the reviews @twdsilva @yanxinyi @jpisaac.
This is an automated message from the Apache Git
ChinmaySKulkarni closed pull request #883:
URL: https://github.com/apache/phoenix/pull/883
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jpisaac commented on pull request #883:
URL: https://github.com/apache/phoenix/pull/883#issuecomment-693635611
LGTM, other than the modifyTable check.
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/PHOENIX-6139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197205#comment-17197205
]
Kadir OZDEMIR commented on PHOENIX-6139:
PHOENIX-6058 could be the reason. I will fix it and
jpisaac commented on a change in pull request #883:
URL: https://github.com/apache/phoenix/pull/883#discussion_r489707106
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##
@@ -3286,6 +3288,43 @@ void
jpisaac commented on a change in pull request #883:
URL: https://github.com/apache/phoenix/pull/883#discussion_r489703786
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java
##
@@ -338,48 +448,53 @@
BIND_PARAMETERS + " VARCHAR,
[
https://issues.apache.org/jira/browse/PHOENIX-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197194#comment-17197194
]
Chinmay Kulkarni commented on PHOENIX-6072:
---
Opened
ChinmaySKulkarni commented on a change in pull request #883:
URL: https://github.com/apache/phoenix/pull/883#discussion_r489674458
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##
@@ -3286,6 +3288,43 @@ void
[
https://issues.apache.org/jira/browse/PHOENIX-6139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197193#comment-17197193
]
Chinmay Kulkarni commented on PHOENIX-6139:
---
Mentioning people who have worked on this test
[
https://issues.apache.org/jira/browse/PHOENIX-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197167#comment-17197167
]
Hadoop QA commented on PHOENIX-6119:
{color:red}-1 overall{color}. Here are the results of testing
ankitsinghal commented on pull request #884:
URL: https://github.com/apache/phoenix/pull/884#issuecomment-693566508
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/PHOENIX-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197157#comment-17197157
]
Hadoop QA commented on PHOENIX-6119:
{color:red}-1 overall{color}. Here are the results of testing
gokceni commented on a change in pull request #864:
URL: https://github.com/apache/phoenix/pull/864#discussion_r489613600
##
File path: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
##
@@ -1524,6 +1525,40 @@ public Integer getBucketNum() {
gokceni commented on a change in pull request #864:
URL: https://github.com/apache/phoenix/pull/864#discussion_r489613073
##
File path: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
##
@@ -1524,6 +1525,40 @@ public Integer getBucketNum() {
gokceni commented on a change in pull request #864:
URL: https://github.com/apache/phoenix/pull/864#discussion_r489612638
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
##
@@ -3800,6 +3814,27 @@ public MutationState addColumn(PTable
gokceni commented on a change in pull request #864:
URL: https://github.com/apache/phoenix/pull/864#discussion_r489611043
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterAddCascadeIndexIT.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/PHOENIX-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197086#comment-17197086
]
Hadoop QA commented on PHOENIX-6119:
{color:red}-1 overall{color}. Here are the results of testing
stoty closed pull request #885:
URL: https://github.com/apache/phoenix/pull/885
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/PHOENIX-6138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196782#comment-17196782
]
Richard Antal commented on PHOENIX-6138:
I have checked the change and it fixes
stoty closed pull request #865:
URL: https://github.com/apache/phoenix/pull/865
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/PHOENIX-6138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196737#comment-17196737
]
Hadoop QA commented on PHOENIX-6138:
{color:red}-1 overall{color}. Here are the results of testing
stoty closed pull request #868:
URL: https://github.com/apache/phoenix/pull/868
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/PHOENIX-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196723#comment-17196723
]
Hadoop QA commented on PHOENIX-6136:
{color:red}-1 overall{color}. Here are the results of testing
stoty opened a new pull request #885:
URL: https://github.com/apache/phoenix/pull/885
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
32 matches
Mail list logo