[jira] [Commented] (PHOENIX-7156) Run integration tests based on @Category

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802384#comment-17802384 ] ASF GitHub Bot commented on PHOENIX-7156: - nikita15p commented on PR #1770: URL:

Re: [PR] PHOENIX-7156 enabling category-wise integration test execution capability [phoenix]

2024-01-03 Thread via GitHub
nikita15p commented on PR #1770: URL: https://github.com/apache/phoenix/pull/1770#issuecomment-1876264913 @stoty I dont have access but I checked the link you have shared, it was triggered

[jira] [Commented] (PHOENIX-628) Support native JSON data type

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802347#comment-17802347 ] ASF GitHub Bot commented on PHOENIX-628: virajjasani commented on PR #1780: URL:

Re: [PR] PHOENIX-628 Support native JSON data type [phoenix]

2024-01-03 Thread via GitHub
virajjasani commented on PR #1780: URL: https://github.com/apache/phoenix/pull/1780#issuecomment-1876107380 It's good to continue the review, however just wanted to bring up this discuss thread: Discuss thread: https://lists.apache.org/thread/xhwqfwytlklylt6kwqm1botsxr7dd4zb I am

[jira] [Commented] (PHOENIX-7069) Initializing list of live region servers in CQSI.init causes failures in Permission related ITs

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802317#comment-17802317 ] ASF GitHub Bot commented on PHOENIX-7069: - virajjasani commented on PR #1749: URL:

Re: [PR] PHOENIX-7069 : Fix permission related ITs when initializing list of region servers in CQSI.init [phoenix]

2024-01-03 Thread via GitHub
virajjasani commented on PR #1749: URL: https://github.com/apache/phoenix/pull/1749#issuecomment-1875933508 Got it, now if we provide the access to the user, i wonder if the intent of the original test would remain the same. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (PHOENIX-7069) Initializing list of live region servers in CQSI.init causes failures in Permission related ITs

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802315#comment-17802315 ] ASF GitHub Bot commented on PHOENIX-7069: - palashc commented on PR #1749: URL:

Re: [PR] PHOENIX-7069 : Fix permission related ITs when initializing list of region servers in CQSI.init [phoenix]

2024-01-03 Thread via GitHub
palashc commented on PR #1749: URL: https://github.com/apache/phoenix/pull/1749#issuecomment-1875929679 @virajjasani Here is the stack trace from one of the tests in `PermissionNSDisabledIT.java`. It occurs when we try to initialize list of live region servers in `CQSI.init()`. ```

[jira] [Commented] (PHOENIX-7139) Create phoenix-mapreduce-byo-shaded-hbase artifact for use by connectors

2024-01-03 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802285#comment-17802285 ] Istvan Toth commented on PHOENIX-7139: -- It also works fine with either

Re: [PR] PHOENIX-7130 Support skipping of shade sources jar creation [phoenix]

2024-01-03 Thread via GitHub
stoty commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1875727262 Ouch. That's extremley slow. Is it on a spinning rust HDD ? Or some slow NAS ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802273#comment-17802273 ] ASF GitHub Bot commented on PHOENIX-7130: - stoty commented on PR #1745: URL:

[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802201#comment-17802201 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1745: URL:

Re: [PR] PHOENIX-7130 Support skipping of shade sources jar creation [phoenix]

2024-01-03 Thread via GitHub
NihalJain commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1875472586 > I have tested this now, but the shading time difference is seems to be minimal. On my machine it takes ~3:20 with the shaded sources, and ~3:05 without them. In our internal

[jira] [Comment Edited] (PHOENIX-7139) Create phoenix-mapreduce-byo-shaded-hbase artifact for use by connectors

2024-01-03 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802196#comment-17802196 ] Istvan Toth edited comment on PHOENIX-7139 at 1/3/24 2:11 PM: -- For some

[jira] [Commented] (PHOENIX-7139) Create phoenix-mapreduce-byo-shaded-hbase artifact for use by connectors

2024-01-03 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802196#comment-17802196 ] Istvan Toth commented on PHOENIX-7139: -- For some reason hbase mapredcp doesn't include the Hadoop

[jira] [Commented] (PHOENIX-7157) Upgrade to phoenix-thirdparty 2.1.0

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802178#comment-17802178 ] ASF GitHub Bot commented on PHOENIX-7157: - NihalJain commented on PR #1772: URL:

Re: [PR] PHOENIX-7157 Upgrade to phoenix-thirdparty 2.1.0 [phoenix]

2024-01-03 Thread via GitHub
NihalJain commented on PR #1772: URL: https://github.com/apache/phoenix/pull/1772#issuecomment-1875393756 Seems build had passed in Jenkins, but result was not sent back to github somehow. See

[jira] [Commented] (PHOENIX-7157) Upgrade to phoenix-thirdparty 2.1.0

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802176#comment-17802176 ] ASF GitHub Bot commented on PHOENIX-7157: - NihalJain commented on PR #1772: URL:

Re: [PR] PHOENIX-7157 Upgrade to phoenix-thirdparty 2.1.0 [phoenix]

2024-01-03 Thread via GitHub
NihalJain commented on PR #1772: URL: https://github.com/apache/phoenix/pull/1772#issuecomment-1875384911 No build happened for this, need to check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PHOENIX-628) Support native JSON data type

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802141#comment-17802141 ] ASF GitHub Bot commented on PHOENIX-628: stoty commented on PR #1780: URL:

Re: [PR] PHOENIX-628 Support native JSON data type [phoenix]

2024-01-03 Thread via GitHub
stoty commented on PR #1780: URL: https://github.com/apache/phoenix/pull/1780#issuecomment-1875276038 The convention is to use the JIRA description for the first line of the commit message. If you think that the JIRA description is not sufficient, you may want to change the JIRA

[jira] [Commented] (PHOENIX-7139) Create phoenix-mapreduce-byo-shaded-hbase artifact for use by connectors

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802140#comment-17802140 ] ASF GitHub Bot commented on PHOENIX-7139: - stoty opened a new pull request, #1781: URL:

[PR] PHOENIX-7139 Create phoenix-mapreduce-byo-shaded-hbase artifact for u… [phoenix]

2024-01-03 Thread via GitHub
stoty opened a new pull request, #1781: URL: https://github.com/apache/phoenix/pull/1781 …se by connectors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (PHOENIX-628) Support native JSON data type

2024-01-03 Thread Ranganath Govardhanagiri (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802113#comment-17802113 ] Ranganath Govardhanagiri commented on PHOENIX-628: -- Added the same description as the

[jira] [Commented] (PHOENIX-628) Support native JSON data type

2024-01-03 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802109#comment-17802109 ] Istvan Toth commented on PHOENIX-628: - The convention is to use the same text. You may want to

[jira] [Commented] (PHOENIX-628) Support native JSON data type

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802106#comment-17802106 ] ASF GitHub Bot commented on PHOENIX-628: ranganathg commented on PR #1780: URL:

Re: [PR] PHOENIX-628 Support native JSON data type [phoenix]

2024-01-03 Thread via GitHub
ranganathg commented on PR #1780: URL: https://github.com/apache/phoenix/pull/1780#issuecomment-1875156638 > The commit message doesn't match the JIRA ticket description Can it be different from the JIRA description? I think the description has a recommendation - can I add the

[jira] [Commented] (PHOENIX-628) Support native JSON data type

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802103#comment-17802103 ] ASF GitHub Bot commented on PHOENIX-628: stoty commented on PR #1780: URL:

Re: [PR] PHOENIX-628 Support native JSON data type [phoenix]

2024-01-03 Thread via GitHub
stoty commented on PR #1780: URL: https://github.com/apache/phoenix/pull/1780#issuecomment-1875139603 The commit message doesn't match the JIRA ticket description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (PHOENIX-628) Support native JSON data type

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802094#comment-17802094 ] ASF GitHub Bot commented on PHOENIX-628: stoty commented on PR #1780: URL:

Re: [PR] PHOENIX-628 JSON support in Phoenix [phoenix]

2024-01-03 Thread via GitHub
stoty commented on PR #1780: URL: https://github.com/apache/phoenix/pull/1780#issuecomment-1875099311 Can you clean up the commit message ? Use of colons, dashes, etc is inconsitent. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (PHOENIX-628) Support native JSON data type

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802086#comment-17802086 ] ASF GitHub Bot commented on PHOENIX-628: ranganathg opened a new pull request, #1780: URL:

[PR] PHOENIX-628 JSON support in Phoenix [phoenix]

2024-01-03 Thread via GitHub
ranganathg opened a new pull request, #1780: URL: https://github.com/apache/phoenix/pull/1780 * PHOENIX-628 - Support native JSON data type (#1667) * PHOENIX-7058 : Implement json_query function on the json object (#1696) * PHOENIX-7044 : Support Index on a generated column

[jira] [Commented] (PHOENIX-628) Support native JSON data type

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802085#comment-17802085 ] ASF GitHub Bot commented on PHOENIX-628: ranganathg closed pull request #1769: PHOENIX-628:

Re: [PR] PHOENIX-628: Support native JSON data type [phoenix]

2024-01-03 Thread via GitHub
ranganathg closed pull request #1769: PHOENIX-628: Support native JSON data type URL: https://github.com/apache/phoenix/pull/1769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (PHOENIX-7165) Compilers should use PhoenixRuntime#getTable

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802084#comment-17802084 ] ASF GitHub Bot commented on PHOENIX-7165: - kadirozde commented on PR #1777: URL:

Re: [PR] PHOENIX-7165 Compilers should use PhoenixRuntime#getTable [phoenix]

2024-01-03 Thread via GitHub
kadirozde commented on PR #1777: URL: https://github.com/apache/phoenix/pull/1777#issuecomment-1875071311 > > > Also, I wonder if we should make this functionalitiy available from the Connection object as a new method. > > > > > > Ideally yes we should. We tried that before while

[jira] [Commented] (PHOENIX-7156) Run integration tests based on @Category

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802061#comment-17802061 ] ASF GitHub Bot commented on PHOENIX-7156: - stoty commented on PR #1770: URL:

Re: [PR] PHOENIX-7156 enabling category-wise integration test execution capability [phoenix]

2024-01-03 Thread via GitHub
stoty commented on PR #1770: URL: https://github.com/apache/phoenix/pull/1770#issuecomment-1875018196 That result has aged out. If you have ASF Jenkins access, you can trigger a re-run it from

Re: [PR] OMID-254 Upgrade to phoenix-thirdparty 2.1.0 [phoenix-omid]

2024-01-03 Thread via GitHub
chrajeshbabu merged PR #151: URL: https://github.com/apache/phoenix-omid/pull/151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: