[jira] [Commented] (PHOENIX-7108) Provide support for pruning expired rows of views using Phoenix level compactions

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828578#comment-17828578 ] ASF GitHub Bot commented on PHOENIX-7108: - jpisaac commented on code in PR #1855: URL:

Re: [PR] PHOENIX-7108 Provide support for pruning expired rows of views using Phoenix level compactions [phoenix]

2024-03-19 Thread via GitHub
jpisaac commented on code in PR #1855: URL: https://github.com/apache/phoenix/pull/1855#discussion_r1531462861 ## phoenix-core/src/main/java/org/apache/phoenix/coprocessor/CompactionScanner.java: ## @@ -160,17 +240,390 @@ public void close() throws IOException {

[jira] [Commented] (PHOENIX-7108) Provide support for pruning expired rows of views using Phoenix level compactions

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828577#comment-17828577 ] ASF GitHub Bot commented on PHOENIX-7108: - jpisaac commented on code in PR #1855: URL:

Re: [PR] PHOENIX-7108 Provide support for pruning expired rows of views using Phoenix level compactions [phoenix]

2024-03-19 Thread via GitHub
jpisaac commented on code in PR #1855: URL: https://github.com/apache/phoenix/pull/1855#discussion_r1531462382 ## phoenix-core/src/main/java/org/apache/phoenix/coprocessor/CompactionScanner.java: ## @@ -84,45 +110,99 @@ public CompactionScanner(RegionCoprocessorEnvironment env,

[jira] [Commented] (PHOENIX-7108) Provide support for pruning expired rows of views using Phoenix level compactions

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828576#comment-17828576 ] ASF GitHub Bot commented on PHOENIX-7108: - jpisaac commented on code in PR #1855: URL:

Re: [PR] PHOENIX-7108 Provide support for pruning expired rows of views using Phoenix level compactions [phoenix]

2024-03-19 Thread via GitHub
jpisaac commented on code in PR #1855: URL: https://github.com/apache/phoenix/pull/1855#discussion_r1531461947 ## phoenix-core/src/main/java/org/apache/phoenix/coprocessor/CompactionScanner.java: ## @@ -84,45 +110,99 @@ public CompactionScanner(RegionCoprocessorEnvironment env,

[jira] [Commented] (PHOENIX-7108) Provide support for pruning expired rows of views using Phoenix level compactions

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828575#comment-17828575 ] ASF GitHub Bot commented on PHOENIX-7108: - jpisaac commented on code in PR #1855: URL:

Re: [PR] PHOENIX-7108 Provide support for pruning expired rows of views using Phoenix level compactions [phoenix]

2024-03-19 Thread via GitHub
jpisaac commented on code in PR #1855: URL: https://github.com/apache/phoenix/pull/1855#discussion_r1531461363 ## phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java: ## @@ -19,6 +19,7 @@ import edu.umd.cs.findbugs.annotations.NonNull; +import

[jira] [Commented] (PHOENIX-7280) Test failure: ViewMetadataIT#testViewAndTableAndDropCascadeWithIndexes

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828521#comment-17828521 ] ASF GitHub Bot commented on PHOENIX-7280: - shahrs87 commented on PR #1858: URL:

[jira] [Commented] (PHOENIX-7280) Test failure: ViewMetadataIT#testViewAndTableAndDropCascadeWithIndexes

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828520#comment-17828520 ] ASF GitHub Bot commented on PHOENIX-7280: - shahrs87 merged PR #1858: URL:

Re: [PR] PHOENIX-7280 Test failure: ViewMetadataIT#testViewAndTableAndDropCascadeWithIndexes [phoenix]

2024-03-19 Thread via GitHub
shahrs87 commented on PR #1858: URL: https://github.com/apache/phoenix/pull/1858#issuecomment-2008177160 Thank you @palashc for the review. Merged the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] PHOENIX-7280 Test failure: ViewMetadataIT#testViewAndTableAndDropCascadeWithIndexes [phoenix]

2024-03-19 Thread via GitHub
shahrs87 merged PR #1858: URL: https://github.com/apache/phoenix/pull/1858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (PHOENIX-7166) Set default values of feature flags introduced by metadata caching redesign

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828515#comment-17828515 ] ASF GitHub Bot commented on PHOENIX-7166: - palashc opened a new pull request, #1859: URL:

[PR] PHOENIX-7166 : Enable feature flags introduced by metadata caching redesign [phoenix]

2024-03-19 Thread via GitHub
palashc opened a new pull request, #1859: URL: https://github.com/apache/phoenix/pull/1859 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (PHOENIX-7280) Test failure: ViewMetadataIT#testViewAndTableAndDropCascadeWithIndexes

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828507#comment-17828507 ] ASF GitHub Bot commented on PHOENIX-7280: - palashc commented on PR #1858: URL:

Re: [PR] PHOENIX-7280 Test failure: ViewMetadataIT#testViewAndTableAndDropCascadeWithIndexes [phoenix]

2024-03-19 Thread via GitHub
palashc commented on PR #1858: URL: https://github.com/apache/phoenix/pull/1858#issuecomment-2008073469 @shahrs87 We can get this in. Thank you for the fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Comment Edited] (PHOENIX-6714) Return update status from Conditional Upserts

2024-03-19 Thread Jing Yu (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827198#comment-17827198 ] Jing Yu edited comment on PHOENIX-6714 at 3/19/24 6:59 PM: --- Design document: 

[jira] [Commented] (PHOENIX-7015) Extend UncoveredGlobalIndexRegionScanner for CDC region scanner usecase

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828410#comment-17828410 ] ASF GitHub Bot commented on PHOENIX-7015: - virajjasani commented on PR #1813: URL:

[jira] [Commented] (PHOENIX-7015) Extend UncoveredGlobalIndexRegionScanner for CDC region scanner usecase

2024-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828411#comment-17828411 ] ASF GitHub Bot commented on PHOENIX-7015: - virajjasani merged PR #1813: URL:

Re: [PR] PHOENIX-7015 Implementing CDCGlobalIndexRegionScanner [phoenix]

2024-03-19 Thread via GitHub
virajjasani merged PR #1813: URL: https://github.com/apache/phoenix/pull/1813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] PHOENIX-7015 Implementing CDCGlobalIndexRegionScanner [phoenix]

2024-03-19 Thread via GitHub
virajjasani commented on PR #1813: URL: https://github.com/apache/phoenix/pull/1813#issuecomment-2007493596 Merging to unblock final PR against master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL