[GitHub] phoenix pull request #360: PHOENIX-4731 Make running transactional unit test...

2018-10-03 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/360#discussion_r222508350 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -184,9 +184,24 @@ public boolean apply(PTable index) {

[GitHub] phoenix pull request #360: PHOENIX-4731 Make running transactional unit test...

2018-10-03 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/360#discussion_r222506752 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/PhoenixTxIndexMutationGenerator.java --- @@ -313,7 +326,18 @@ public int compare(Cell

[GitHub] phoenix pull request #360: PHOENIX-4731 Make running transactional unit test...

2018-10-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/360#discussion_r222480439 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/execute/PhoenixTxIndexMutationGenerator.java --- @@ -313,7 +326,18 @@ public int compare(Cell o1,

[GitHub] phoenix pull request #360: PHOENIX-4731 Make running transactional unit test...

2018-10-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/360#discussion_r222480675 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -184,9 +184,24 @@ public boolean apply(PTable index) {

[GitHub] phoenix pull request #360: PHOENIX-4731 Make running transactional unit test...

2018-10-02 Thread JamesRTaylor
GitHub user JamesRTaylor opened a pull request: https://github.com/apache/phoenix/pull/360 PHOENIX-4731 Make running transactional unit tests for a given provider optional Enables turning transaction tests off for Tephra and/or Omid. Please review, @ohadshacham and/or @twdsilva. Th