[jira] [Commented] (PHOENIX-7056) Update the LAST_DDL_TIMESTAMP of the parent table/view when we add/drop an index.

2023-09-30 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770757#comment-17770757 ] Viraj Jasani commented on PHOENIX-7056: --- When we add/drop index of the child view, correct? >

[jira] [Commented] (PHOENIX-7039) Snapshot scanner should skip replay WAL and update seqid while opening region

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770748#comment-17770748 ] ASF GitHub Bot commented on PHOENIX-7039: - virajjasani commented on PR #1677: URL:

[GitHub] [phoenix] virajjasani commented on pull request #1677: PHOENIX-7039 Snapshot scanner should skip replay WAL and update seqid while opening region

2023-09-30 Thread via GitHub
virajjasani commented on PR #1677: URL: https://github.com/apache/phoenix/pull/1677#issuecomment-1741835630 Let me add TODO before merging this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PHOENIX-6968) Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770761#comment-17770761 ] ASF GitHub Bot commented on PHOENIX-6968: - shahrs87 commented on code in PR #1691: URL:

[GitHub] [phoenix] shahrs87 commented on a diff in pull request #1691: PHOENIX-6968 Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread via GitHub
shahrs87 commented on code in PR #1691: URL: https://github.com/apache/phoenix/pull/1691#discussion_r1342003493 ## phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java: ## @@ -3416,6 +3437,167 @@ private MetaDataMutationResult mutateColumn(

[jira] [Commented] (PHOENIX-7056) Update the LAST_DDL_TIMESTAMP of the parent table/view when we add/drop an index.

2023-09-30 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770769#comment-17770769 ] Rushabh Shah commented on PHOENIX-7056: --- > When we add/drop index of the child view, we want to

[jira] [Comment Edited] (PHOENIX-7056) Update the LAST_DDL_TIMESTAMP of the parent table/view when we add/drop an index.

2023-09-30 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770757#comment-17770757 ] Viraj Jasani edited comment on PHOENIX-7056 at 9/30/23 7:31 PM: When we

[GitHub] [phoenix] shahrs87 commented on a diff in pull request #1691: PHOENIX-6968 Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread via GitHub
shahrs87 commented on code in PR #1691: URL: https://github.com/apache/phoenix/pull/1691#discussion_r1342003712 ## phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java: ## @@ -3416,6 +3437,167 @@ private MetaDataMutationResult mutateColumn(

[jira] [Commented] (PHOENIX-6968) Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770763#comment-17770763 ] ASF GitHub Bot commented on PHOENIX-6968: - shahrs87 commented on code in PR #1691: URL:

[jira] [Commented] (PHOENIX-7039) Snapshot scanner should skip replay WAL and update seqid while opening region

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770750#comment-17770750 ] ASF GitHub Bot commented on PHOENIX-7039: - virajjasani merged PR #1677: URL:

[GitHub] [phoenix] virajjasani merged pull request #1677: PHOENIX-7039 Snapshot scanner should skip replay WAL and update seqid while opening region

2023-09-30 Thread via GitHub
virajjasani merged PR #1677: URL: https://github.com/apache/phoenix/pull/1677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [phoenix] shahrs87 commented on a diff in pull request #1691: PHOENIX-6968 Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread via GitHub
shahrs87 commented on code in PR #1691: URL: https://github.com/apache/phoenix/pull/1691#discussion_r1342003921 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/InvalidateMetadataCacheIT.java: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (PHOENIX-6968) Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770765#comment-17770765 ] ASF GitHub Bot commented on PHOENIX-6968: - shahrs87 commented on code in PR #1691: URL:

[GitHub] [phoenix] shahrs87 commented on a diff in pull request #1691: PHOENIX-6968 Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread via GitHub
shahrs87 commented on code in PR #1691: URL: https://github.com/apache/phoenix/pull/1691#discussion_r1342004049 ## phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java: ## @@ -3165,10 +3184,12 @@ private MetaDataMutationResult mutateColumn(

[jira] [Commented] (PHOENIX-6968) Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770767#comment-17770767 ] ASF GitHub Bot commented on PHOENIX-6968: - shahrs87 commented on code in PR #1691: URL:

[jira] [Commented] (PHOENIX-6968) Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770768#comment-17770768 ] ASF GitHub Bot commented on PHOENIX-6968: - shahrs87 commented on code in PR #1691: URL:

[GitHub] [phoenix] shahrs87 commented on a diff in pull request #1691: PHOENIX-6968 Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread via GitHub
shahrs87 commented on code in PR #1691: URL: https://github.com/apache/phoenix/pull/1691#discussion_r1342004085 ## phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java: ## @@ -3165,10 +3184,12 @@ private MetaDataMutationResult mutateColumn(

[jira] [Commented] (PHOENIX-6968) Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770766#comment-17770766 ] ASF GitHub Bot commented on PHOENIX-6968: - shahrs87 commented on code in PR #1691: URL:

[GitHub] [phoenix] shahrs87 commented on a diff in pull request #1691: PHOENIX-6968 Create PhoenixRegionServerEndpoint#invalidateCache method to invalidate cache.

2023-09-30 Thread via GitHub
shahrs87 commented on code in PR #1691: URL: https://github.com/apache/phoenix/pull/1691#discussion_r1342003895 ## phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java: ## @@ -3416,6 +3437,167 @@ private MetaDataMutationResult mutateColumn(