jparkzz commented on PR #1987:
URL: https://github.com/apache/polaris/pull/1987#issuecomment-3026679054
Thanks @dimas-b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jparkzz opened a new pull request, #1987:
URL: https://github.com/apache/polaris/pull/1987
Through documentation review and testing, I confirmed that the **db-kind**
is determined at build time and cannot be modified at runtime.
To prevent user confusion, this PR removes the
eric-maynard commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2179239000
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
If we are going by number of PRs
flyrain commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2179135551
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software Foundation (
flyrain commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2179067937
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software Foundation (
jbonofre commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2179066976
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
It's ok for me as soon as it's not an
MonkeyCanCode commented on PR #1954:
URL: https://github.com/apache/polaris/pull/1954#issuecomment-3026383721
> > @MonkeyCanCode what exactly did you run here btw? I still see
conflicts/changes on #1912 after running `ruff check client/python/cli --fix`
there.
>
> For the above, I am
MonkeyCanCode opened a new pull request, #1986:
URL: https://github.com/apache/polaris/pull/1986
Here is a sample PR for enable python code format/check from conclusion
derived from https://github.com/apache/polaris/pull/1954 (as it is a sample PR,
I didn't update the doc as I would like to
github-actions[bot] commented on PR #1595:
URL: https://github.com/apache/polaris/pull/1595#issuecomment-3026111821
This PR is stale because it has been open 30 days with no activity. Remove
stale label or comment or this will be closed in 5 days.
--
This is an automated message from the
eric-maynard commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2146083284
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/SparkCatalog.java:
##
@@ -156,15 +159,23 @@ public Table createTable(
throw new Unsuppo
eric-maynard commented on PR #1954:
URL: https://github.com/apache/polaris/pull/1954#issuecomment-3026098018
@MonkeyCanCode what exactly did you run here btw? I still see conflict on
#1912 after running `ruff check client/python/cli --fix` there.
--
This is an automated message from the A
eric-maynard merged PR #1912:
URL: https://github.com/apache/polaris/pull/1912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
MonkeyCanCode commented on PR #1954:
URL: https://github.com/apache/polaris/pull/1954#issuecomment-3026124075
> @MonkeyCanCode what exactly did you run here btw? I still see
conflicts/changes on #1912 after running `ruff check client/python/cli --fix`
there.
For the above, I am using
flyrain commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2178824185
##
plugins/spark/v3.5/integration/src/intTest/java/org/apache/polaris/spark/quarkus/it/SparkCatalogIcebergIT.java:
##
@@ -19,33 +19,19 @@
package org.apache.polaris.sp
flyrain commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2178823978
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software Foundation (
gh-yzou commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2178694967
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software Foundation (
flyrain commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2178698033
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software Foundation (
Copilot commented on code in PR #1985:
URL: https://github.com/apache/polaris/pull/1985#discussion_r2178628508
##
integration-tests/src/main/java/org/apache/polaris/service/it/ext/SparkSessionBuilder.java:
##
@@ -0,0 +1,293 @@
+/*
+ * Licensed to the Apache Software Foundation (
flyrain opened a new pull request, #1985:
URL: https://github.com/apache/polaris/pull/1985
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
flyrain commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178432751
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
That's reasonable. One of metrics we c
eric-maynard commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178385892
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
If we are going to try to keep th
eric-maynard commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178385892
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
If we are going to try to keep th
gh-yzou commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2178168915
##
plugins/spark/v3.5/integration/build.gradle.kts:
##
@@ -60,12 +60,51 @@ dependencies {
exclude("org.apache.logging.log4j", "log4j-core")
exclude("org.slf4j
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2178107734
##
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##
@@ -263,12 +264,14 @@ public static void enforceFeatureEnabledOrThrow
eric-maynard commented on PR #1982:
URL: https://github.com/apache/polaris/pull/1982#issuecomment-3024583440
> a) the BufferedReader is created somewhere inside some function calls
What function calls? It's created inside a try-with-resources which is
visible in the diff
[here](http
singhpk234 commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178036844
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
if this is possible i would persona
singhpk234 commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178032694
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
How does it works for projects like
singhpk234 commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178032694
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
How does it works for projects like
flyrain commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178029612
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
It's 10 now, also added a comment.
flyrain commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178025390
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
Let me adjust a bit
--
This is an
eric-maynard commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178023199
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
Honestly I don't think having to
jbonofre commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178020827
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
If we want more we need to send a req
singhpk234 commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178020017
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
should we go with the more frequent
jbonofre commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178015955
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
The parser will fail and it won't wor
eric-maynard merged PR #1983:
URL: https://github.com/apache/polaris/pull/1983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
flyrain commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178010186
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
What happened if we add more than 10?
jbonofre commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2178005071
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
Careful: we are limited to 10 contrib
flyrain opened a new pull request, #1984:
URL: https://github.com/apache/polaris/pull/1984
It's great to see a lot of new contributors. Add them to avoid manual
triggering the github CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Copilot commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2177979409
##
plugins/spark/v3.5/spark/build.gradle.kts:
##
@@ -46,6 +46,47 @@ dependencies {
// TODO: extract a polaris-rest module as a thin layer for
// client to depend
rahil-c commented on PR #1862:
URL: https://github.com/apache/polaris/pull/1862#issuecomment-3024556170
cc @flyrain @gh-yzou @singhpk234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
gfakbar20 commented on issue #780:
URL: https://github.com/apache/polaris/issues/780#issuecomment-3024379513
Hi, before opening a PR, I want to know is there any guideline that i can
read regarding the standard of unit tests/integration tests? Like is there a
coverage threshold that must be
snazy commented on PR #1982:
URL: https://github.com/apache/polaris/pull/1982#issuecomment-3024069435
@eric-maynard you see that a) the `BufferedReader` is created somewhere
inside some function calls and b) that the given stream should be closed
nontheless, right?
--
This is an automate
adutra commented on PR #1937:
URL: https://github.com/apache/polaris/pull/1937#issuecomment-3022008096
> @dimas-b noted ! Apologies, I missed your comment there, I saw @adutra's
approval and I was also +1 so i merged.
>
> I agree with you here that db-kind should configured at build
43 matches
Mail list logo
