sebbASF opened a new issue #463: Bug: Archiver#msgbody: poor handling of conversion to string URL: https://github.com/apache/incubator-ponymail/issues/463 The method msgbody returns a string. This is converted here: https://github.com/apache/incubator-ponymail/blob/ec0a76eb8b6836a3675800a65829a48fe90156f9/tools/archiver.py#L255 There are some problems with this: 1) it's only needed if type(body) is bytes 2) if multiple charsets are present it will try them all. If the last one fails, this will override any successful earlier decodes 3) pm_charsets() uses a set to hold the result of calling msg.get_charsets(). This does not preserve the order. Does it even make sense to look at all the charsets associated with a message? If so, then surely each part should be treated separately.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
