[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621470#comment-16621470 ] Sergey Soldatov commented on RATIS-317: --- [~vrodionov] yep, I understand. Just expressed my opinion

[jira] [Comment Edited] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621422#comment-16621422 ] Vladimir Rodionov edited comment on RATIS-317 at 9/20/18 2:26 AM: -- As I

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621422#comment-16621422 ] Vladimir Rodionov commented on RATIS-317: - Every RatisGroup is served by a dedicated RaftServer,

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621307#comment-16621307 ] Sergey Soldatov commented on RATIS-317: --- [~vrodionov] my point is whether we really need that

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621296#comment-16621296 ] Vladimir Rodionov commented on RATIS-317: - [~sergey.soldatov], having separate log files for

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621293#comment-16621293 ] Sergey Soldatov commented on RATIS-317: --- [~vrodionov] ah. Got it. Was confused with the two layers

[jira] [Assigned] (RATIS-221) Support new operations in Arithmetic-Example (append, remove/delete)

2018-09-19 Thread Jing Chen (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Chen reassigned RATIS-221: --- Assignee: (was: Jing Chen) > Support new operations in Arithmetic-Example (append,

[jira] [Comment Edited] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621212#comment-16621212 ] Vladimir Rodionov edited comment on RATIS-317 at 9/19/18 9:15 PM: -- I

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621212#comment-16621212 ] Vladimir Rodionov commented on RATIS-317: - I think read messages (queries) won't be stored i a

[jira] [Comment Edited] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621212#comment-16621212 ] Vladimir Rodionov edited comment on RATIS-317 at 9/19/18 9:07 PM: -- I

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621211#comment-16621211 ] Sergey Soldatov commented on RATIS-317: --- bq. For example, where are you going to store log stream

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621182#comment-16621182 ] Sergey Soldatov commented on RATIS-317: --- {quote} LogService communicates (read/write) with a service

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621163#comment-16621163 ] Vladimir Rodionov commented on RATIS-317: - {quote} I think we definitely have use-cases from HBase

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621159#comment-16621159 ] Vladimir Rodionov commented on RATIS-317: - {quote} The question is ... {quote} For example, where

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621154#comment-16621154 ] Josh Elser commented on RATIS-317: -- {quote}The question is why we should store anything in the state

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621141#comment-16621141 ] Vladimir Rodionov commented on RATIS-317: - OK, This is what I suggest as a next steps (how to

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621131#comment-16621131 ] Sergey Soldatov commented on RATIS-317: --- The question is why we should store anything in the state

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621116#comment-16621116 ] Vladimir Rodionov commented on RATIS-317: - Yes, State Machine just holds pair of LogName and

[jira] [Updated] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated RATIS-317: Attachment: RATIS-317-v3.patch > Log service state machine > - > >

[jira] [Comment Edited] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621113#comment-16621113 ] Vladimir Rodionov edited comment on RATIS-317 at 9/19/18 7:48 PM: -- Patch

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621113#comment-16621113 ] Vladimir Rodionov commented on RATIS-317: - Patch v3 > Log service state machine >

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621112#comment-16621112 ] Sergey Soldatov commented on RATIS-317: --- If I understand the code correctly, all operations like

[jira] [Created] (RATIS-326) Introduce RemoveStateMachine Data in StateMachine interface in Ratis

2018-09-19 Thread Shashikant Banerjee (JIRA)
Shashikant Banerjee created RATIS-326: - Summary: Introduce RemoveStateMachine Data in StateMachine interface in Ratis Key: RATIS-326 URL: https://issues.apache.org/jira/browse/RATIS-326 Project:

[jira] [Updated] (RATIS-326) Introduce RemoveStateMachineData API in StateMachine interface in Ratis

2018-09-19 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee updated RATIS-326: -- Summary: Introduce RemoveStateMachineData API in StateMachine interface in Ratis (was:

[jira] [Commented] (RATIS-324) Rename grpc classes

2018-09-19 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620942#comment-16620942 ] Tsz Wo Nicholas Sze commented on RATIS-324: --- Please try the following command to apply patch:

[jira] [Commented] (RATIS-317) Log service state machine

2018-09-19 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620891#comment-16620891 ] Josh Elser commented on RATIS-317: -- {quote}I would commit this patch (after minor corrections you

[jira] [Comment Edited] (RATIS-265) Ratis Leader flow control request from raft client to avoid OOM errors

2018-09-19 Thread Rajeshbabu Chintaguntla (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620562#comment-16620562 ] Rajeshbabu Chintaguntla edited comment on RATIS-265 at 9/19/18 1:18 PM:

[jira] [Commented] (RATIS-265) Ratis Leader flow control request from raft client to avoid OOM errors

2018-09-19 Thread Rajeshbabu Chintaguntla (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620562#comment-16620562 ] Rajeshbabu Chintaguntla commented on RATIS-265: --- [~szetszwo] [~msingh] Here is the wip

[jira] [Updated] (RATIS-265) Ratis Leader flow control request from raft client to avoid OOM errors

2018-09-19 Thread Rajeshbabu Chintaguntla (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajeshbabu Chintaguntla updated RATIS-265: -- Attachment: RATIS-265_wip.patch > Ratis Leader flow control request from raft

[jira] [Commented] (RATIS-324) Rename grpc classes

2018-09-19 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620467#comment-16620467 ] Lokesh Jain commented on RATIS-324: --- [~szetszwo] Thanks for working on this! The patch looks very good

[jira] [Commented] (RATIS-325) RetryPolicies should not import com.google.common.annotations.VisibleForTesting.

2018-09-19 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620366#comment-16620366 ] Lokesh Jain commented on RATIS-325: --- [~szetszwo] Thanks for the contribution! [~shashikant] Thanks for

[jira] [Commented] (RATIS-325) RetryPolicies should not import com.google.common.annotations.VisibleForTesting.

2018-09-19 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620358#comment-16620358 ] Lokesh Jain commented on RATIS-325: --- Thanks [~szetszwo] for working on this. The patch looks good to me.

[jira] [Comment Edited] (RATIS-325) RetryPolicies should not import com.google.common.annotations.VisibleForTesting.

2018-09-19 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620246#comment-16620246 ] Shashikant Banerjee edited comment on RATIS-325 at 9/19/18 9:23 AM:

[jira] [Commented] (RATIS-321) RaftLog should validate appendEntries

2018-09-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620343#comment-16620343 ] Hadoop QA commented on RATIS-321: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-321) RaftLog should validate appendEntries

2018-09-19 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620304#comment-16620304 ] Lokesh Jain commented on RATIS-321: --- [~szetszwo] Thanks for reviewing the patch! v2 patch fixes the test

[jira] [Updated] (RATIS-321) RaftLog should validate appendEntries

2018-09-19 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Jain updated RATIS-321: -- Attachment: (was: RATIS-321.001.patch) > RaftLog should validate appendEntries >

[jira] [Updated] (RATIS-321) RaftLog should validate appendEntries

2018-09-19 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Jain updated RATIS-321: -- Attachment: RATIS-321.002.patch > RaftLog should validate appendEntries >

***UNCHECKED*** [jira] [Commented] (RATIS-325) RetryPolicies should not import com.google.common.annotations.VisibleForTesting.

2018-09-19 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620246#comment-16620246 ] Shashikant Banerjee commented on RATIS-325: --- Thanks [~szetszwo], for the review. Patch looks