[jira] [Commented] (RATIS-691) Fix checkstyle violations in ratis-logservice

[ https://issues.apache.org/jira/browse/RATIS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941526#comment-16941526 ] Hadoop QA commented on RATIS-691: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-650) Add metrics to track commit index of each peer in a RaftGroup

[ https://issues.apache.org/jira/browse/RATIS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941527#comment-16941527 ] Hadoop QA commented on RATIS-650: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Comment Edited] (RATIS-691) Fix checkstyle violations in ratis-logservice

[ https://issues.apache.org/jira/browse/RATIS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941522#comment-16941522 ] Dinesh Chitlangia edited comment on RATIS-691 at 10/1/19 4:52 AM: --

[jira] [Commented] (RATIS-691) Fix checkstyle violations in ratis-logservice

[ https://issues.apache.org/jira/browse/RATIS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941522#comment-16941522 ] Dinesh Chitlangia commented on RATIS-691: - [~szetszwo] Thank you for reviewing. I have addressed

[jira] [Updated] (RATIS-691) Fix checkstyle violations in ratis-logservice

[ https://issues.apache.org/jira/browse/RATIS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated RATIS-691: Attachment: RATIS-691.002.patch > Fix checkstyle violations in ratis-logservice >

[jira] [Commented] (RATIS-650) Add metrics to track commit index of each peer in a RaftGroup

[ https://issues.apache.org/jira/browse/RATIS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941520#comment-16941520 ] Supratim Deka commented on RATIS-650: - Thanks for looking into it [~shashikant]. Rebased the patch.

[jira] [Updated] (RATIS-650) Add metrics to track commit index of each peer in a RaftGroup

[ https://issues.apache.org/jira/browse/RATIS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Supratim Deka updated RATIS-650: Attachment: RATIS-650.005.patch > Add metrics to track commit index of each peer in a RaftGroup >

[jira] [Commented] (RATIS-693) Combine notifyLeader and notifyLeaderChanged calls on StateMachine

[ https://issues.apache.org/jira/browse/RATIS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941509#comment-16941509 ] Hadoop QA commented on RATIS-693: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-691) Fix checkstyle violations in ratis-logservice

[ https://issues.apache.org/jira/browse/RATIS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941508#comment-16941508 ] Hadoop QA commented on RATIS-691: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Comment Edited] (RATIS-691) Fix checkstyle violations in ratis-logservice

[ https://issues.apache.org/jira/browse/RATIS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941490#comment-16941490 ] Tsz-wo Sze edited comment on RATIS-691 at 10/1/19 3:17 AM: --- Thanks

[jira] [Commented] (RATIS-691) Fix checkstyle violations in ratis-logservice

[ https://issues.apache.org/jira/browse/RATIS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941490#comment-16941490 ] Tsz-wo Sze commented on RATIS-691: -- Thanks [~dineshchitlangia] for working on this. Some comments: -

[jira] [Updated] (RATIS-691) Fix checkstyle violations in ratis-logservice

[ https://issues.apache.org/jira/browse/RATIS-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated RATIS-691: Attachment: RATIS-691.001.patch > Fix checkstyle violations in ratis-logservice >

[jira] [Commented] (RATIS-693) Combine notifyLeader and notifyLeaderChanged calls on StateMachine

[ https://issues.apache.org/jira/browse/RATIS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941484#comment-16941484 ] Tsz-wo Sze commented on RATIS-693: -- +1 the 02 patch looks good. > Combine notifyLeader and

[jira] [Updated] (RATIS-693) Combine notifyLeader and notifyLeaderChanged calls on StateMachine

[ https://issues.apache.org/jira/browse/RATIS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Wagle updated RATIS-693: -- Attachment: RATIS-693.02.patch > Combine notifyLeader and notifyLeaderChanged calls on

[jira] [Commented] (RATIS-693) Combine notifyLeader and notifyLeaderChanged calls on StateMachine

[ https://issues.apache.org/jira/browse/RATIS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941479#comment-16941479 ] Siddharth Wagle commented on RATIS-693: --- Thanks [~szetszwo] for review, updated the patch. >

[jira] [Commented] (RATIS-693) Combine notifyLeader and notifyLeaderChanged calls on StateMachine

[ https://issues.apache.org/jira/browse/RATIS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941384#comment-16941384 ] Hadoop QA commented on RATIS-693: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-693) Combine notifyLeader and notifyLeaderChanged calls on StateMachine

[ https://issues.apache.org/jira/browse/RATIS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941370#comment-16941370 ] Tsz-wo Sze commented on RATIS-693: -- Thanks [~swagle]. In ServerState, just call getMemberId(), i.e. no

[jira] [Updated] (RATIS-693) Combine notifyLeader and notifyLeaderChanged calls on StateMachine

[ https://issues.apache.org/jira/browse/RATIS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Wagle updated RATIS-693: -- Attachment: RATIS-693.01.patch > Combine notifyLeader and notifyLeaderChanged calls on

[jira] [Commented] (RATIS-676) Add a metric in RaftServer to track the Log Commit Index

[ https://issues.apache.org/jira/browse/RATIS-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941159#comment-16941159 ] Hadoop QA commented on RATIS-676: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-650) Add metrics to track commit index of each peer in a RaftGroup

[ https://issues.apache.org/jira/browse/RATIS-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941121#comment-16941121 ] Shashikant Banerjee commented on RATIS-650: --- Thanks [~sdeka] for working on this. The patch

[jira] [Commented] (RATIS-648) Add metrics related to GrpcLogAppendRequests

[ https://issues.apache.org/jira/browse/RATIS-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941120#comment-16941120 ] Shashikant Banerjee commented on RATIS-648: --- Thanks [~swagle] for working on this. The patch

[jira] [Created] (RATIS-697) Provide helper scripts for code quality checks

Marton Elek created RATIS-697: - Summary: Provide helper scripts for code quality checks Key: RATIS-697 URL: https://issues.apache.org/jira/browse/RATIS-697 Project: Ratis Issue Type: Improvement

[jira] [Commented] (RATIS-679) Add counters for append entries and number of times raft log is flushed

[ https://issues.apache.org/jira/browse/RATIS-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940869#comment-16940869 ] Lokesh Jain commented on RATIS-679: --- [~shashikant] Thanks for reviewing the patch! I have committed this

[jira] [Commented] (RATIS-679) Add counters for append entries and number of times raft log is flushed

[ https://issues.apache.org/jira/browse/RATIS-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940793#comment-16940793 ] Shashikant Banerjee commented on RATIS-679: --- Thanks [~ljain] for working on this. I am +1 on

[jira] [Commented] (RATIS-679) Add counters for append entries and number of times raft log is flushed

[ https://issues.apache.org/jira/browse/RATIS-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940777#comment-16940777 ] Hadoop QA commented on RATIS-679: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||