[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-12-04 Thread Rajeshbabu Chintaguntla (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709005#comment-16709005 ] Rajeshbabu Chintaguntla commented on RATIS-378: --- [~elserj] The patch looks g

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-12-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707970#comment-16707970 ] Hadoop QA commented on RATIS-378: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-12-03 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707927#comment-16707927 ] Josh Elser commented on RATIS-378: -- [~rajeshbabu], can you take a look at v4 for me, plea

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702592#comment-16702592 ] Hadoop QA commented on RATIS-378: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-28 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702557#comment-16702557 ] Josh Elser commented on RATIS-378: -- .003 tries to make checkstyle happier. > Consolidate

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702402#comment-16702402 ] Hadoop QA commented on RATIS-378: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-28 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702384#comment-16702384 ] Josh Elser commented on RATIS-378: -- .002 Makes the raft group IDs configurable and tries

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-28 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702231#comment-16702231 ] Josh Elser commented on RATIS-378: -- {quote}To use daemon threads in servers. In this case

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-28 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702220#comment-16702220 ] Josh Elser commented on RATIS-378: -- {quote}In the code above, [~elserj]*metaGroupID* refe

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-15 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688755#comment-16688755 ] Vladimir Rodionov commented on RATIS-378: - One more suggestion: To use daemon thr

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-15 Thread Vladimir Rodionov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688754#comment-16688754 ] Vladimir Rodionov commented on RATIS-378: - {code} public void start() throws I

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688671#comment-16688671 ] Hadoop QA commented on RATIS-378: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-15 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688643#comment-16688643 ] Josh Elser commented on RATIS-378: -- .001 consolidates naming conventions: "Server" is a J

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-14 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687569#comment-16687569 ] Josh Elser commented on RATIS-378: -- Things not quite working here, but this has been sitt

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-10-27 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665970#comment-16665970 ] Sergey Soldatov commented on RATIS-378: --- At the moment they look similar (the differ

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-10-26 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665599#comment-16665599 ] Josh Elser commented on RATIS-378: -- Some things I see: * state machine data directory *