[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-09-03 Thread Tsz Wo Nicholas Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921628#comment-16921628 ] Tsz Wo Nicholas Sze commented on RATIS-661: --- > I mean an api which can tell that the group is in

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-09-03 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921316#comment-16921316 ] Lokesh Jain commented on RATIS-661: --- [~szetszwo] Thanks for reviewing and committing the patch!  |

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-30 Thread Tsz Wo Nicholas Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919851#comment-16919851 ] Tsz Wo Nicholas Sze commented on RATIS-661: --- +1 the 005 patch looks good. > Add call in state

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-30 Thread Tsz Wo Nicholas Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919850#comment-16919850 ] Tsz Wo Nicholas Sze commented on RATIS-661: --- > Should we support an api called groupExists in

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-28 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917792#comment-16917792 ] Hadoop QA commented on RATIS-661: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-28 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917464#comment-16917464 ] Lokesh Jain commented on RATIS-661: --- [~szetszwo] Thanks for reviewing the patch! v5 patch addresses your

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-27 Thread Tsz Wo Nicholas Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917069#comment-16917069 ] Tsz Wo Nicholas Sze commented on RATIS-661: --- >  Since the impl is removed earlier,

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-27 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917067#comment-16917067 ] Hadoop QA commented on RATIS-661: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-27 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917059#comment-16917059 ] Lokesh Jain commented on RATIS-661: --- [~szetszwo] Thanks for reviewing the patch! | Why changing

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-27 Thread Tsz Wo Nicholas Sze (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916965#comment-16916965 ] Tsz Wo Nicholas Sze commented on RATIS-661: --- [~ljain], thanks for working on this. - Why

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-27 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916572#comment-16916572 ] Lokesh Jain commented on RATIS-661: --- [~msingh] Thanks for reviewing the patch! v4 patch addresses your

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-27 Thread Mukul Kumar Singh (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916540#comment-16916540 ] Mukul Kumar Singh commented on RATIS-661: - Thanks for working on this [~ljain]. The patch

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915537#comment-16915537 ] Hadoop QA commented on RATIS-661: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-25 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915494#comment-16915494 ] Lokesh Jain commented on RATIS-661: --- [~shashikant] Thanks for reviewing the patch! v3 patch addresses

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-23 Thread Shashikant Banerjee (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914197#comment-16914197 ] Shashikant Banerjee commented on RATIS-661: --- Thanks [~ljain] for working on this. The patch

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911059#comment-16911059 ] Hadoop QA commented on RATIS-661: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-661) Add call in state machine to handle group removal

2019-08-20 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911034#comment-16911034 ] Lokesh Jain commented on RATIS-661: --- v2 patch fixes the compilation failure. > Add call in state