[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-23 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090785#comment-17090785 ] Hanisha Koneru commented on RATIS-850: -- Thank you [~ljain] and [~msingh] for the reviews and

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090343#comment-17090343 ] Lokesh Jain commented on RATIS-850: --- [~hanishakoneru] Thanks for the contribution! [~msingh] Thanks for

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-23 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090324#comment-17090324 ] Lokesh Jain commented on RATIS-850: --- [~hanishakoneru] Thanks for updating the patch! The changes look

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-22 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089915#comment-17089915 ] Hadoop QA commented on RATIS-850: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-22 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089870#comment-17089870 ] Hanisha Koneru commented on RATIS-850: -- Snapshots are a function of the StateMachine. So they should

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-22 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089316#comment-17089316 ] Lokesh Jain commented on RATIS-850: --- [~hanishakoneru] I agree. What I am wondering is if deleting till

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-21 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089114#comment-17089114 ] Hanisha Koneru commented on RATIS-850: -- On second thoughts, purging only upto snapshotIndex always

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-21 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088980#comment-17088980 ] Hanisha Koneru commented on RATIS-850: -- Thank you [~ljain] and [~msingh] for the reviews. {quote}bq. 

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-21 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088494#comment-17088494 ] Lokesh Jain commented on RATIS-850: --- [~hanishakoneru] Thanks for working on this! The changes look good

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-21 Thread Mukul Kumar Singh (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088433#comment-17088433 ] Mukul Kumar Singh commented on RATIS-850: - Thanks for updating the patch. +1, the patch looks good

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-17 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085970#comment-17085970 ] Hanisha Koneru commented on RATIS-850: -- Unit tests pass locally. [~msingh] , [~lokeshjain] can you

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-15 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084508#comment-17084508 ] Hadoop QA commented on RATIS-850: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-15 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084485#comment-17084485 ] Hanisha Koneru commented on RATIS-850: -- Fixed the checkstyle and one related failing unit test - 

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083804#comment-17083804 ] Hadoop QA commented on RATIS-850: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-14 Thread Mukul Kumar Singh (Jira)
[ https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083774#comment-17083774 ] Mukul Kumar Singh commented on RATIS-850: - [~hanishakoneru], This was done on Ozone's datanode to