[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090785#comment-17090785
]
Hanisha Koneru commented on RATIS-850:
--
Thank you [~ljain] and [~msingh] for the reviews and
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090343#comment-17090343
]
Lokesh Jain commented on RATIS-850:
---
[~hanishakoneru] Thanks for the contribution! [~msingh] Thanks for
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090324#comment-17090324
]
Lokesh Jain commented on RATIS-850:
---
[~hanishakoneru] Thanks for updating the patch! The changes look
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089915#comment-17089915
]
Hadoop QA commented on RATIS-850:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089870#comment-17089870
]
Hanisha Koneru commented on RATIS-850:
--
Snapshots are a function of the StateMachine. So they should
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089316#comment-17089316
]
Lokesh Jain commented on RATIS-850:
---
[~hanishakoneru] I agree. What I am wondering is if deleting till
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089114#comment-17089114
]
Hanisha Koneru commented on RATIS-850:
--
On second thoughts, purging only upto snapshotIndex always
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088980#comment-17088980
]
Hanisha Koneru commented on RATIS-850:
--
Thank you [~ljain] and [~msingh] for the reviews.
{quote}bq.
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088494#comment-17088494
]
Lokesh Jain commented on RATIS-850:
---
[~hanishakoneru] Thanks for working on this! The changes look good
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088433#comment-17088433
]
Mukul Kumar Singh commented on RATIS-850:
-
Thanks for updating the patch. +1, the patch looks good
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085970#comment-17085970
]
Hanisha Koneru commented on RATIS-850:
--
Unit tests pass locally.
[~msingh] , [~lokeshjain] can you
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084508#comment-17084508
]
Hadoop QA commented on RATIS-850:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084485#comment-17084485
]
Hanisha Koneru commented on RATIS-850:
--
Fixed the checkstyle and one related failing unit test -
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083804#comment-17083804
]
Hadoop QA commented on RATIS-850:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083774#comment-17083774
]
Mukul Kumar Singh commented on RATIS-850:
-
[~hanishakoneru], This was done on Ozone's datanode to
15 matches
Mail list logo