[
https://issues.apache.org/jira/browse/RATIS-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elek, Marton updated RATIS-102:
-------------------------------
Comment: was deleted
(was: The nightly build seems to be ok:
https://builds.apache.org/job/ratis-qbt-master-java8-linux-x86/3/
There is one ASF licence warning by the .travis.yaml on RATIS-4. I will remove
this file from the RATIS-4 patch. It could be usefull to test PR/custom forks,
but it should be adjusted first to use yetus. Will remove now.
The other problem is a real unit test failure which IMHO a real unit test
problem and should be fixed.
The precommit hook is more trickier. There is a lot of compilation error (see
https://builds.apache.org/job/PreCommit-RATIS-Build/9/console). I think because
the shading is bind to the package phase, so a simple mvn clean compile is not
supported on the source code. I am still investigating it.)
> Clean generated sources as part of the default clean lifecycle
> --------------------------------------------------------------
>
> Key: RATIS-102
> URL: https://issues.apache.org/jira/browse/RATIS-102
> Project: Ratis
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: build
> Attachments: RATIS-102.000.patch, RATIS-102.001.patch,
> RATIS-102.002.patch
>
>
> RATIS-49 introduced new profiles to cleanup the generated sources/proto files
> in the shaded artifacts.
> I suggest to make it more easier by binding the additional {clean:clean}
> plugin calls to the clean phase of the default clean lifecycle instead of
> trigger them from a separated profile.
> In RATIS-4 I experimenting with build scripts and yetus test-patch script.
> As the simple {{mvn clean}} command is more common, it would be easier to
> switch to the simple clean without the profile.
> The cleanup could be done with triggering additional clean plugin execution.
> To test:
> {code}
> git checkout 52c4b64
> mvn clean package -DskipTests
> git checkout master
> mvn clean package -DskipTests
> {code}
> Without the patch the second only works with -Pclean-shade, with the proposed
> patch it works without activating any additional profile
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
