[jira] [Comment Edited] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-10 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285503#comment-16285503 ] Lokesh Jain edited comment on RATIS-160 at 12/11/17 4:38 AM: - > The bug happens

[jira] [Commented] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285515#comment-16285515 ] Jing Zhao commented on RATIS-160: - bq. Actually the bug occurs when new leader creates a new log entry

[jira] [Commented] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-10 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285454#comment-16285454 ] Lokesh Jain commented on RATIS-160: --- [~jingzhao] thanks for the review! The failed cache entry is in the

[jira] [Comment Edited] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285467#comment-16285467 ] Jing Zhao edited comment on RATIS-160 at 12/11/17 3:11 AM: --- The reason I do not

[jira] [Commented] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-10 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285477#comment-16285477 ] Lokesh Jain commented on RATIS-160: --- > Do you think the proposed fix in my previous comment can fix the

[jira] [Commented] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-10 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285503#comment-16285503 ] Lokesh Jain commented on RATIS-160: --- > The bug happens actually in the new leader, while it is committing

[jira] [Commented] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285491#comment-16285491 ] Jing Zhao commented on RATIS-160: - bq. The exception is raised by follower when they see a completed cache

[jira] [Commented] (RATIS-161) gRPC Log appender should check if the appended request size is less than max message size of the server

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285151#comment-16285151 ] Tsz Wo Nicholas Sze commented on RATIS-161: --- - GrpcConfigKeys.MESSAGE_SIZE_MAX_KEY specifies the

[jira] [Comment Edited] (RATIS-170) Add an async FileStore test

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285138#comment-16285138 ] Tsz Wo Nicholas Sze edited comment on RATIS-170 at 12/10/17 9:23 AM: - >

[jira] [Comment Edited] (RATIS-170) Add an async FileStore test

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285138#comment-16285138 ] Tsz Wo Nicholas Sze edited comment on RATIS-170 at 12/10/17 9:23 AM: - >

[jira] [Commented] (RATIS-161) gRPC Log appender should check if the appended request size is less than max message size of the server

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285152#comment-16285152 ] Tsz Wo Nicholas Sze commented on RATIS-161: --- BTW, let's also change LogEntryBuffer.addEntry. It

[jira] [Commented] (RATIS-140) Raft client should reuse the gRPC stream for all async calls

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285137#comment-16285137 ] Tsz Wo Nicholas Sze commented on RATIS-140: --- The patch has passed 99 times the new async

[jira] [Commented] (RATIS-170) Add an async FileStore test

2017-12-10 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285138#comment-16285138 ] Tsz Wo Nicholas Sze commented on RATIS-170: --- > But it is about 50% faster than the multi-threaded

[jira] [Commented] (RATIS-154) Add setter functions for Raft Config keys

2017-12-10 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285315#comment-16285315 ] Lokesh Jain commented on RATIS-154: --- Thanks for working on this [~shashikant]. The patch looks good.