[jira] [Comment Edited] (RATIS-386) Raft Client Async API's should honor Retry Policy

2018-11-14 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686481#comment-16686481 ] Shashikant Banerjee edited comment on RATIS-386 at 11/15/18 1:07 AM: -

[jira] [Created] (RATIS-416) Fix checkstyle warnings in ClientImplUtils

2018-11-14 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-416: - Summary: Fix checkstyle warnings in ClientImplUtils Key: RATIS-416 URL: https://issues.apache.org/jira/browse/RATIS-416 Project: Ratis Issue Type:

[jira] [Commented] (RATIS-406) In RaftServerImpl, the RaftLog.append(entries) call should not hold the RaftServerImpl lock

2018-11-14 Thread Jitendra Nath Pandey (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687344#comment-16687344 ] Jitendra Nath Pandey commented on RATIS-406: +1 for the patch. > In RaftServerImpl, the

[jira] [Commented] (RATIS-409) Watch requests may not work if there is a conf change

2018-11-14 Thread Jitendra Nath Pandey (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687343#comment-16687343 ] Jitendra Nath Pandey commented on RATIS-409: {{commitIndexChanged}} method doesn't set

[jira] [Commented] (RATIS-409) Watch requests may not work if there is a conf change

2018-11-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687364#comment-16687364 ] Tsz Wo Nicholas Sze commented on RATIS-409: --- > commitIndexChanged method doesn't set

[jira] [Created] (RATIS-417) Fix checkstyle warnings in PureJavaCrc32C

2018-11-14 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-417: - Summary: Fix checkstyle warnings in PureJavaCrc32C Key: RATIS-417 URL: https://issues.apache.org/jira/browse/RATIS-417 Project: Ratis Issue Type:

[jira] [Commented] (RATIS-413) [Umbrella] Fix checkstyle warnings

2018-11-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687382#comment-16687382 ] Tsz Wo Nicholas Sze commented on RATIS-413: --- The warnings can be generated by {code} $mvn

[jira] [Commented] (RATIS-406) In RaftServerImpl, the RaftLog.append(entries) call should not hold the RaftServerImpl lock

2018-11-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687220#comment-16687220 ] Hadoop QA commented on RATIS-406: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Created] (RATIS-413) [Umbrella] Fix checkstyle warnings

2018-11-14 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-413: - Summary: [Umbrella] Fix checkstyle warnings Key: RATIS-413 URL: https://issues.apache.org/jira/browse/RATIS-413 Project: Ratis Issue Type:

[jira] [Created] (RATIS-415) Fix checkstyle warnings in RaftClientRpcWithProxy

2018-11-14 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-415: - Summary: Fix checkstyle warnings in RaftClientRpcWithProxy Key: RATIS-415 URL: https://issues.apache.org/jira/browse/RATIS-415 Project: Ratis

[jira] [Created] (RATIS-414) Fix checkstyle warnings in RaftClient and RaftClientImpl

2018-11-14 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-414: - Summary: Fix checkstyle warnings in RaftClient and RaftClientImpl Key: RATIS-414 URL: https://issues.apache.org/jira/browse/RATIS-414 Project: Ratis

[jira] [Commented] (RATIS-386) Raft Client Async API's should honor Retry Policy

2018-11-14 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686481#comment-16686481 ] Shashikant Banerjee commented on RATIS-386: --- Thanks [~szetszwo] for the comments. Moving the

[jira] [Commented] (RATIS-409) Watch requests may not work if there is a conf change

2018-11-14 Thread Jitendra Nath Pandey (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687494#comment-16687494 ] Jitendra Nath Pandey commented on RATIS-409: {{leaderState.commitIndexChanged()}} is being

[jira] [Updated] (RATIS-386) Raft Client Async API's should honor Retry Policy

2018-11-14 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee updated RATIS-386: -- Attachment: (was: RATIS-386.000.patch) > Raft Client Async API's should honor Retry

[jira] [Updated] (RATIS-386) Raft Client Async API's should honor Retry Policy

2018-11-14 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee updated RATIS-386: -- Attachment: RATIS-386.001.patch > Raft Client Async API's should honor Retry Policy >

[jira] [Updated] (RATIS-386) Raft Client Async API's should honor Retry Policy

2018-11-14 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee updated RATIS-386: -- Attachment: RATIS-386.001.patch > Raft Client Async API's should honor Retry Policy >

[jira] [Updated] (RATIS-386) Raft Client Async API's should honor Retry Policy

2018-11-14 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee updated RATIS-386: -- Attachment: (was: RATIS-386.001.patch) > Raft Client Async API's should honor Retry

[jira] [Commented] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-14 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687569#comment-16687569 ] Josh Elser commented on RATIS-378: -- Things not quite working here, but this has been sitting locally too

[jira] [Updated] (RATIS-378) Consolidate MasterServer and LogServiceWorker

2018-11-14 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated RATIS-378: - Attachment: RATIS-378.wip.patch > Consolidate MasterServer and LogServiceWorker >

[jira] [Assigned] (RATIS-415) Disable checkstyle DesignForExtension rule

2018-11-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze reassigned RATIS-415: - Assignee: Tsz Wo Nicholas Sze Description: The DesignForExtension rule

[jira] [Commented] (RATIS-386) Raft Client Async API's should honor Retry Policy

2018-11-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687417#comment-16687417 ] Hadoop QA commented on RATIS-386: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-386) Raft Client Async API's should honor Retry Policy

2018-11-14 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687401#comment-16687401 ] Shashikant Banerjee commented on RATIS-386: --- Thanks [~szetszwo], as per our discussion/comments,

[jira] [Commented] (RATIS-386) Raft Client Async API's should honor Retry Policy

2018-11-14 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687585#comment-16687585 ] Shashikant Banerjee commented on RATIS-386: --- Patch v3 addresses the issues discussed.  > Raft

[jira] [Commented] (RATIS-386) Raft Client Async API's should honor Retry Policy

2018-11-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687609#comment-16687609 ] Hadoop QA commented on RATIS-386: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (RATIS-406) In RaftServerImpl, the RaftLog.append(entries) call should not hold the RaftServerImpl lock

2018-11-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687014#comment-16687014 ] Tsz Wo Nicholas Sze commented on RATIS-406: --- > ... Would it be simpler to either force only one

[jira] [Commented] (RATIS-406) In RaftServerImpl, the RaftLog.append(entries) call should not hold the RaftServerImpl lock

2018-11-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687033#comment-16687033 ] Tsz Wo Nicholas Sze commented on RATIS-406: --- > ... I think instead of blocking the thread we

[jira] [Commented] (RATIS-386) Raft Client Async API's should honor Retry Policy

2018-11-14 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687040#comment-16687040 ] Tsz Wo Nicholas Sze commented on RATIS-386: --- > I think ,we probably should have same result for

[jira] [Commented] (RATIS-406) In RaftServerImpl, the RaftLog.append(entries) call should not hold the RaftServerImpl lock

2018-11-14 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686937#comment-16686937 ] Lokesh Jain commented on RATIS-406: --- [~szetszwo] Thanks for working on this! I had a few thoughts on

[jira] [Commented] (RATIS-131) Add checkstyle configuration

2018-11-14 Thread Jitendra Nath Pandey (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687145#comment-16687145 ] Jitendra Nath Pandey commented on RATIS-131: +1 > Add checkstyle configuration >