[jira] [Created] (RATIS-28) Create RaftServerRpc using ServerFactory
Tsz Wo Nicholas Sze created RATIS-28: Summary: Create RaftServerRpc using ServerFactory Key: RATIS-28 URL: https://issues.apache.org/jira/browse/RATIS-28 Project: Ratis Issue Type: Sub-task Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze In order to support pluggable rpc, user is supposed to first choose an rpc implementation to create a RaftServerRpc rpc. Then create a RaftServer server. Finally, call server.setServerRpc(rpc) to connect these two objects. In this JIRA, we add a RpcType property and use it to initialize RaftServer and then automatically create RaftServerRpc from the RpcType. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (RATIS-26) Make shaded source compilation as a default action
[ https://issues.apache.org/jira/browse/RATIS-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879723#comment-15879723 ] Enis Soztutar commented on RATIS-26: Actually I need to make bigger changes in this patch: - Flatten out the maven structure. It should not be like the hadoop's layout with -project and -project-dist, etc. Keep it simple. - Some cleanup in poms - compile + shade by default Some things to do after this patch: - Add missing sections (developers, mailing lists, etc) to pom. - Clean up dependencies - Fix assembly, tarball, etc > Make shaded source compilation as a default action > -- > > Key: RATIS-26 > URL: https://issues.apache.org/jira/browse/RATIS-26 > Project: Ratis > Issue Type: Improvement >Reporter: Jing Zhao >Assignee: Enis Soztutar > Attachments: RATIS-26.000.patch > > > Currently developers need to enter the ratis-proto-shaded directory and run > "mvn package -Dcompile-protobuf" to compile shaded sources. This is not > convenient when updating protobuf definitions. We can make this step a > default step. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (RATIS-26) Make shaded source compilation as a default action
[ https://issues.apache.org/jira/browse/RATIS-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879601#comment-15879601 ] Jing Zhao commented on RATIS-26: [~szetszwo] pointed out that this patch made "mvn clean" and "-DskipShade" conflict. Since [~enis] is working on a more systematic solution, reassign this jira to him. > Make shaded source compilation as a default action > -- > > Key: RATIS-26 > URL: https://issues.apache.org/jira/browse/RATIS-26 > Project: Ratis > Issue Type: Improvement >Reporter: Jing Zhao >Assignee: Jing Zhao > Attachments: RATIS-26.000.patch > > > Currently developers need to enter the ratis-proto-shaded directory and run > "mvn package -Dcompile-protobuf" to compile shaded sources. This is not > convenient when updating protobuf definitions. We can make this step a > default step. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RATIS-27) Use factory methods to create MiniRaftCluster
[ https://issues.apache.org/jira/browse/RATIS-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-27: - Attachment: r27_20170222.patch r27_20170222.patch: 1st patch. > Use factory methods to create MiniRaftCluster > - > > Key: RATIS-27 > URL: https://issues.apache.org/jira/browse/RATIS-27 > Project: Ratis > Issue Type: Improvement >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r27_20170222.patch > > > Enforce all the tests to use the factory methods to create MiniRaftCluster so > that we may setup RaftProperties in centralized locations. > We also change the HadoopRpcService to not throwing IOException. Then, > MiniRaftCluster creation also no longer needs to throw IOException. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (RATIS-7) Code cleanup for SimpleStateMachine4Testing
[ https://issues.apache.org/jira/browse/RATIS-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-7. --- Resolution: Fixed Fix Version/s: 0.1 I've committed this patch. Thanks for the contribution, [~garvitbansal]. > Code cleanup for SimpleStateMachine4Testing > --- > > Key: RATIS-7 > URL: https://issues.apache.org/jira/browse/RATIS-7 > Project: Ratis > Issue Type: Improvement >Reporter: Jing Zhao >Assignee: garvit >Priority: Minor > Fix For: 0.1 > > Attachments: ratis7.patch > > > The current SimpleStateMachine4Testing code can be further cleaned. E.g., > # There is an unused import > # some member fields' access can be private > We can use this jira to cleanup it code. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RATIS-7) Code cleanup for SimpleStateMachine4Testing
[ https://issues.apache.org/jira/browse/RATIS-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] garvit updated RATIS-7: --- Attachment: ratis7.patch This is patch which includes code cleanup for SimpleStateMachine4Testing. > Code cleanup for SimpleStateMachine4Testing > --- > > Key: RATIS-7 > URL: https://issues.apache.org/jira/browse/RATIS-7 > Project: Ratis > Issue Type: Improvement >Reporter: Jing Zhao >Assignee: garvit >Priority: Minor > Attachments: ratis7.patch > > > The current SimpleStateMachine4Testing code can be further cleaned. E.g., > # There is an unused import > # some member fields' access can be private > We can use this jira to cleanup it code. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
