[jira] [Commented] (RATIS-140) Raft client should reuse the gRPC stream for all async calls

2017-12-12 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288768#comment-16288768 ] Jing Zhao commented on RATIS-140: - Thanks for updating the patch, Nicholas! I will post comments these

[jira] [Updated] (RATIS-171) The FileStore tests fail with NullPointerException

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-171: -- Description: In the RaftLogWorker.WriteLog constructor, stateMachineFuture can be null

[jira] [Commented] (RATIS-124) RaftLog should be sync'ed on all the entries appended but not the last entry

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287779#comment-16287779 ] Tsz Wo Nicholas Sze commented on RATIS-124: --- The failures of TestFileStoreWithNetty and

[jira] [Created] (RATIS-171) The FileStore tests fails with NullPointerException

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
Tsz Wo Nicholas Sze created RATIS-171: - Summary: The FileStore tests fails with NullPointerException Key: RATIS-171 URL: https://issues.apache.org/jira/browse/RATIS-171 Project: Ratis

[jira] [Updated] (RATIS-161) gRPC Log appender should check if the appended request size is less than max message size of the server

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-161: -- +1 patch looks good. > gRPC Log appender should check if the appended request size is less

[jira] [Commented] (RATIS-124) RaftLog should be sync'ed on all the entries appended but not the last entry

2017-12-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287399#comment-16287399 ] Hadoop QA commented on RATIS-124: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Updated] (RATIS-124) RaftLog should be sync'ed on all the entries appended but not the last entry

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-124: -- Attachment: r124_20171212b_committed.patch +1 the 20171212b patch looks good.

[jira] [Commented] (RATIS-161) gRPC Log appender should check if the appended request size is less than max message size of the server

2017-12-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287384#comment-16287384 ] Hadoop QA commented on RATIS-161: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Updated] (RATIS-161) gRPC Log appender should check if the appended request size is less than max message size of the server

2017-12-12 Thread Mukul Kumar Singh (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh updated RATIS-161: Attachment: RATIS-161.003.patch Thanks for the review [~szetszwo], Patch v3 fixes the review

[jira] [Updated] (RATIS-154) Add setter functions for Raft Config keys

2017-12-12 Thread Shashikant Banerjee (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee updated RATIS-154: -- Attachment: RATIS-154.002.patch Thanks [~ljain], for the review comments. As per our

[jira] [Updated] (RATIS-124) RaftLog should be sync'ed on all the entries appended but not the last entry

2017-12-12 Thread Kit Hui (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kit Hui updated RATIS-124: -- Attachment: r124_20171212b.patch Addressed review comment. > RaftLog should be sync'ed on all the entries

[jira] [Commented] (RATIS-124) RaftLog should be sync'ed on all the entries appended but not the last entry

2017-12-12 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287253#comment-16287253 ] Tsz Wo Nicholas Sze commented on RATIS-124: --- Patch looks good. Some minor comments: - Let's