[jira] [Commented] (RATIS-228) Handle zero size log_inprogress file

2018-04-23 Thread Kit Hui (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449191#comment-16449191 ] Kit Hui commented on RATIS-228: --- Thanks, I have added a test case and uploaded a new patch. > Handle zero

[jira] [Updated] (RATIS-228) Handle zero size log_inprogress file

2018-04-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-228: -- Attachment: (was: r228_20180420.patch) > Handle zero size log_inprogress file >

[jira] [Updated] (RATIS-228) Handle zero size log_inprogress file

2018-04-23 Thread Kit Hui (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kit Hui updated RATIS-228: -- Attachment: r228_20180424.patch > Handle zero size log_inprogress file > >

[jira] [Commented] (RATIS-231) Grpc server should reconnect if there is an exception

2018-04-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449160#comment-16449160 ] Tsz Wo Nicholas Sze commented on RATIS-231: --- r231_20180423.patch: this patch is mainly a

[jira] [Updated] (RATIS-231) Grpc server should reconnect if there is an exception

2018-04-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-231: -- Attachment: r231_20180423.patch > Grpc server should reconnect if there is an exception

[jira] [Commented] (RATIS-231) Grpc server should reconnect if there is an exception

2018-04-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449142#comment-16449142 ] Tsz Wo Nicholas Sze commented on RATIS-231: --- RaftGRpcService should extend

[jira] [Commented] (RATIS-229) GRpcLogAppender should trigger a heartbeat when appendEntries timeout

2018-04-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449079#comment-16449079 ] Tsz Wo Nicholas Sze commented on RATIS-229: --- I see what is going on: when timeout,

[jira] [Commented] (RATIS-229) GRpcLogAppender should trigger a heartbeat when appendEntries timeout

2018-04-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449037#comment-16449037 ] Tsz Wo Nicholas Sze commented on RATIS-229: --- Just checked

[jira] [Commented] (RATIS-228) Handle zero size log_inprogress file

2018-04-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448654#comment-16448654 ] Tsz Wo Nicholas Sze commented on RATIS-228: --- Patch looks good. Please see if you could add a

[jira] [Commented] (RATIS-227) TestRaftWithGrpc.testBasicAppendEntriesWithAllReplication fails

2018-04-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448650#comment-16448650 ] Tsz Wo Nicholas Sze commented on RATIS-227: --- When there is an unexpected leader election, it

[jira] [Commented] (RATIS-229) GRpcLogAppender should trigger a heartbeat when appendEntries timeout

2018-04-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448582#comment-16448582 ] Tsz Wo Nicholas Sze commented on RATIS-229: --- The restarted follower should wait until timeout

[jira] [Commented] (RATIS-229) GRpcLogAppender should trigger a heartbeat when appendEntries timeout

2018-04-23 Thread Lokesh Jain (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448240#comment-16448240 ] Lokesh Jain commented on RATIS-229: --- I think the restarted follower would start an election with an

[jira] [Commented] (RATIS-229) GRpcLogAppender should trigger a heartbeat when appendEntries timeout

2018-04-23 Thread Kit Hui (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447633#comment-16447633 ] Kit Hui commented on RATIS-229: --- Thanks Lokesh for the comments.  In RATIS-227, I do see a leader election