[jira] [Commented] (RATIS-714) Limit the byte size used by the message in pending requests
[
https://issues.apache.org/jira/browse/RATIS-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958521#comment-16958521
]
Hadoop QA commented on RATIS-714:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} RATIS-714 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.8.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | RATIS-714 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12982961/r714_20191014.patch |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1105/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Limit the byte size used by the message in pending requests
> ---
>
> Key: RATIS-714
> URL: https://issues.apache.org/jira/browse/RATIS-714
> Project: Ratis
> Issue Type: Improvement
> Components: server
>Reporter: Tsz-wo Sze
>Assignee: Tsz-wo Sze
>Priority: Major
> Attachments: r714_20191014.patch
>
>
> In PendingRequests, the number of outstanding requests is limited but the
> byte size is not. The byte size should also be limited in order to avoid
> out of memory.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RATIS-699) Dependency is relying on system dependency jdk:tools:1.X
[ https://issues.apache.org/jira/browse/RATIS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958520#comment-16958520 ] Andy Wu commented on RATIS-699: --- Sounds perfect! Thanks [~szetszwo]! > Dependency is relying on system dependency jdk:tools:1.X > > > Key: RATIS-699 > URL: https://issues.apache.org/jira/browse/RATIS-699 > Project: Ratis > Issue Type: Bug > Components: metrics >Affects Versions: 0.4.0 >Reporter: Henrik Hegardt >Assignee: Henrik Hegardt >Priority: Minor > Attachments: RATIS-699.03.patch, tree_new, tree_orig > > > Ratis-Metric is depending on the dependency > com.github.joshelser:dropwizard-metrics-hadoop-metrics2-reporter: 0.1.2. This > in turn depends on the org.apache.hadoop:hadoop-common:2.6.0. This in turn > depends on org.apache.hadoop:hadoop-annotations:2.6.0 which have an > dependency on a system scoped dependency named jdk.tools:1.6. I'm running > java 11 and this dependency doesn't exist in my environment so I can't > compile with ratis included in my project because it fails trying to resolve > that dependency. > However, the project ratis-hadoop depends on the the dependency > org.apache.hadoop:hadoop-common:3.1.1 (which should be upgraded to 3.1.2 > because the sources are missing in 3.1.1) which doesn't have the > jdk.tools:1.6 dependency. So if I depend on this I can build the project > because the faulty 2.6.0 dependency is shadowed transitively by the 3.1.1 > dependency and everything is compiling. > The simple fix would be updating so ratis-metric is depending directly on the > 3.1.2 dependency instead since it effectively will be the 3.1.1 code you are > going run with anyway when running with the ratis-hadoop dependency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-734) TestRaftServerWithGrpc.testRaftClientMetrics times out after 100s
[ https://issues.apache.org/jira/browse/RATIS-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated RATIS-734: Attachment: stdout.txt > TestRaftServerWithGrpc.testRaftClientMetrics times out after 100s > - > > Key: RATIS-734 > URL: https://issues.apache.org/jira/browse/RATIS-734 > Project: Ratis > Issue Type: Bug > Components: test >Affects Versions: 0.4.0 >Reporter: Dinesh Chitlangia >Priority: Major > Attachments: stdout.txt > > > Attached the stdout. > > Originally seen during CI run of RATIS-694 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (RATIS-734) TestRaftServerWithGrpc.testRaftClientMetrics times out after 100s
Dinesh Chitlangia created RATIS-734: --- Summary: TestRaftServerWithGrpc.testRaftClientMetrics times out after 100s Key: RATIS-734 URL: https://issues.apache.org/jira/browse/RATIS-734 Project: Ratis Issue Type: Bug Components: test Affects Versions: 0.4.0 Reporter: Dinesh Chitlangia Attached the stdout. Originally seen during CI run of RATIS-694 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-733) TestRaftOutputStreamWithGrpc.testSimpleWrite times out after 30s
[ https://issues.apache.org/jira/browse/RATIS-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated RATIS-733: Attachment: stdout.txt > TestRaftOutputStreamWithGrpc.testSimpleWrite times out after 30s > > > Key: RATIS-733 > URL: https://issues.apache.org/jira/browse/RATIS-733 > Project: Ratis > Issue Type: Bug > Components: test >Affects Versions: 0.4.0 >Reporter: Dinesh Chitlangia >Priority: Major > Attachments: stdout.txt > > > Attached the stdout. > > Originally seen during CI run of RATIS-694 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (RATIS-733) TestRaftOutputStreamWithGrpc.testSimpleWrite times out after 30s
Dinesh Chitlangia created RATIS-733: --- Summary: TestRaftOutputStreamWithGrpc.testSimpleWrite times out after 30s Key: RATIS-733 URL: https://issues.apache.org/jira/browse/RATIS-733 Project: Ratis Issue Type: Bug Components: test Affects Versions: 0.4.0 Reporter: Dinesh Chitlangia Attached the stdout. Originally seen during CI run of RATIS-694 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (RATIS-732) TestRaftAsyncExceptionWithGrpc.testTimeoutException times out after 100s
Dinesh Chitlangia created RATIS-732: --- Summary: TestRaftAsyncExceptionWithGrpc.testTimeoutException times out after 100s Key: RATIS-732 URL: https://issues.apache.org/jira/browse/RATIS-732 Project: Ratis Issue Type: Bug Components: test Affects Versions: 0.4.0 Reporter: Dinesh Chitlangia Attachments: stdout.txt Attached the stdout. Originally seen during CI run of RATIS-694 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-732) TestRaftAsyncExceptionWithGrpc.testTimeoutException times out after 100s
[ https://issues.apache.org/jira/browse/RATIS-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dinesh Chitlangia updated RATIS-732: Attachment: stdout.txt > TestRaftAsyncExceptionWithGrpc.testTimeoutException times out after 100s > > > Key: RATIS-732 > URL: https://issues.apache.org/jira/browse/RATIS-732 > Project: Ratis > Issue Type: Bug > Components: test >Affects Versions: 0.4.0 >Reporter: Dinesh Chitlangia >Priority: Major > Attachments: stdout.txt > > > Attached the stdout. > > Originally seen during CI run of RATIS-694 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (RATIS-731) TestFileStoreAsyncWithGrpc.testFileStoreAsync times out after 100s
Dinesh Chitlangia created RATIS-731: --- Summary: TestFileStoreAsyncWithGrpc.testFileStoreAsync times out after 100s Key: RATIS-731 URL: https://issues.apache.org/jira/browse/RATIS-731 Project: Ratis Issue Type: Bug Components: test Affects Versions: 0.4.0 Reporter: Dinesh Chitlangia Attached the stdout. Originally seen during CI run of RATIS-694 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (RATIS-730) Fix checkstyle violations in ratis-examples
Dinesh Chitlangia created RATIS-730: --- Summary: Fix checkstyle violations in ratis-examples Key: RATIS-730 URL: https://issues.apache.org/jira/browse/RATIS-730 Project: Ratis Issue Type: Sub-task Reporter: Dinesh Chitlangia Assignee: Dinesh Chitlangia Jira to fix checkstyle violations in ratis-examples module -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-694) Fix checkstyle violations in ratis-metrics
[
https://issues.apache.org/jira/browse/RATIS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958476#comment-16958476
]
Hadoop QA commented on RATIS-694:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} root: The patch generated 0 new + 0 unchanged - 7
fixed = 0 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 2s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 49s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestRaftAsyncExceptionWithGrpc |
| | ratis.grpc.TestRaftOutputStreamWithGrpc |
| | ratis.grpc.TestRaftReconfigurationWithGrpc |
| | ratis.grpc.TestRaftServerWithGrpc |
| | ratis.netty.TestRaftReconfigurationWithNetty |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.netty.TestRaftWithNetty |
| | ratis.grpc.TestLeaderElectionWithGrpc |
| | ratis.examples.filestore.TestFileStoreAsyncWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/ratis:date2019-10-24 |
| JIRA Issue | RATIS-694 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983881/RATIS-694.001.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux a484a7611cd8 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 55cbfbb |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1104/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1104/testReport/ |
| Max. process+thread count | 1155 (vs. ulimit of 5000) |
| modules | C: ratis-metrics U: ratis-metrics |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1104/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Fix checkstyle violations in ratis-metrics
> --
>
> Key: RATIS-694
> URL:
[jira] [Commented] (RATIS-728) TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till it times out even though request succeeds
[
https://issues.apache.org/jira/browse/RATIS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958428#comment-16958428
]
Hadoop QA commented on RATIS-728:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 11s{color} | {color:orange} root: The patch generated 3 new + 3 unchanged -
0 fixed = 6 total (was 3) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 32m 1s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 14s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestRaftAsyncExceptionWithGrpc |
| | ratis.grpc.TestRaftOutputStreamWithGrpc |
| | ratis.grpc.TestRaftWithGrpc |
| | ratis.grpc.TestRaftServerWithGrpc |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/ratis:date2019-10-23 |
| JIRA Issue | RATIS-728 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983876/r728_20191023b.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux 3224e45bae39 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 55cbfbb |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/1103/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1103/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1103/testReport/ |
| Max. process+thread count | 1958 (vs. ulimit of 5000) |
| modules | C: ratis-grpc U: ratis-grpc |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1103/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till
> it times out even though request succeeds
>
[jira] [Commented] (RATIS-692) RaftStorageDirectory.tryLock throws a very deep IOException
[
https://issues.apache.org/jira/browse/RATIS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958407#comment-16958407
]
Hadoop QA commented on RATIS-692:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
55s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 32m 19s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 41s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.server.TestMetaServer |
| | ratis.grpc.TestRaftAsyncExceptionWithGrpc |
| | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.grpc.TestRaftOutputStreamWithGrpc |
| | ratis.grpc.TestRaftServerWithGrpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.grpc.TestLeaderElectionWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithGrpc |
| | ratis.examples.filestore.TestFileStoreAsyncWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/ratis:date2019-10-23 |
| JIRA Issue | RATIS-692 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12982035/r692_20191003.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux 72d4e94dd3dc 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 55cbfbb |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1102/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1102/testReport/ |
| Max. process+thread count | 1285 (vs. ulimit of 5000) |
| modules | C: ratis-common ratis-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1102/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> RaftStorageDirectory.tryLock throws a very deep IOException
>
[jira] [Commented] (RATIS-692) RaftStorageDirectory.tryLock throws a very deep IOException
[
https://issues.apache.org/jira/browse/RATIS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958324#comment-16958324
]
Jitendra Nath Pandey commented on RATIS-692:
+1 for the patch, pending jenkins.
> RaftStorageDirectory.tryLock throws a very deep IOException
> ---
>
> Key: RATIS-692
> URL: https://issues.apache.org/jira/browse/RATIS-692
> Project: Ratis
> Issue Type: Sub-task
> Components: server
>Reporter: Clay B.
>Assignee: Tsz-wo Sze
>Priority: Major
> Labels: namazu
> Attachments: r692_20190928.patch, r692_20191002.patch,
> r692_20191003.patch
>
>
> Working with our Namazu infrastructure, the first issue I hit when dialing up
> the faulty I/O injection rate is as follows:
> {code}
> 2019-09-27 14:13:45 ERROR RaftStorageDirectory:336 - Failed to acquire lock
> on
> /home/vagrant/test_data/data0_slowed/64656d6f-5261-6674-4772-6f7570313233/in_use.lock.
> If this storage directory is mounted via NFS, ensure that the appropriate
> nfs lock services are running.
> java.io.IOException: Input/output error
> at java.io.RandomAccessFile.writeBytes(Native Method)
> at java.io.RandomAccessFile.write(RandomAccessFile.java:512)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.tryLock(RaftStorageDirectory.java:327)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.lock(RaftStorageDirectory.java:291)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.analyzeStorage(RaftStorageDirectory.java:264)
> at
> org.apache.ratis.server.storage.RaftStorage.analyzeAndRecoverStorage(RaftStorage.java:100)
> at
> org.apache.ratis.server.storage.RaftStorage.(RaftStorage.java:63)
> at
> org.apache.ratis.server.impl.ServerState.(ServerState.java:109)
> at
> org.apache.ratis.server.impl.RaftServerImpl.(RaftServerImpl.java:110)
> at
> org.apache.ratis.server.impl.RaftServerProxy.lambda$newRaftServerImpl$2(RaftServerProxy.java:208)
> at
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Exception in thread "main" java.io.IOException: Input/output error
> at java.io.RandomAccessFile.writeBytes(Native Method)
> at java.io.RandomAccessFile.write(RandomAccessFile.java:512)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.tryLock(RaftStorageDirectory.java:327)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.lock(RaftStorageDirectory.java:291)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.analyzeStorage(RaftStorageDirectory.java:264)
> at
> org.apache.ratis.server.storage.RaftStorage.analyzeAndRecoverStorage(RaftStorage.java:100)
> at
> org.apache.ratis.server.storage.RaftStorage.(RaftStorage.java:63)
> at
> org.apache.ratis.server.impl.ServerState.(ServerState.java:109)
> at
> org.apache.ratis.server.impl.RaftServerImpl.(RaftServerImpl.java:110)
> at
> org.apache.ratis.server.impl.RaftServerProxy.lambda$newRaftServerImpl$2(RaftServerProxy.java:208)
> at
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> It looks like the call chain does not re-try anywhere however.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RATIS-728) TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till it times out even though request succeeds
[ https://issues.apache.org/jira/browse/RATIS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958320#comment-16958320 ] Tsz-wo Sze commented on RATIS-728: -- r728_20191023b.patch: changes also GrpcClientProtocolClient to not holding the request in TimeoutScheduler. > TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till > it times out even though request succeeds > -- > > Key: RATIS-728 > URL: https://issues.apache.org/jira/browse/RATIS-728 > Project: Ratis > Issue Type: Bug > Components: gRPC >Reporter: Shashikant Banerjee >Assignee: Tsz-wo Sze >Priority: Major > Attachments: r728_20191023.patch, r728_20191023b.patch > > > As discussed in RATIS-726, we need a similar fix for Append Request in > GrpcLogAppender to remove the references to appendEntryRequest as soon as the > response is received, thereby avoiding any memory pressure creation on the > server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-728) TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till it times out even though request succeeds
[ https://issues.apache.org/jira/browse/RATIS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze updated RATIS-728: - Attachment: r728_20191023b.patch > TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till > it times out even though request succeeds > -- > > Key: RATIS-728 > URL: https://issues.apache.org/jira/browse/RATIS-728 > Project: Ratis > Issue Type: Bug > Components: gRPC >Reporter: Shashikant Banerjee >Assignee: Tsz-wo Sze >Priority: Major > Attachments: r728_20191023.patch, r728_20191023b.patch > > > As discussed in RATIS-726, we need a similar fix for Append Request in > GrpcLogAppender to remove the references to appendEntryRequest as soon as the > response is received, thereby avoiding any memory pressure creation on the > server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (RATIS-648) Add metrics related to GrpcLogAppendRequests
[ https://issues.apache.org/jira/browse/RATIS-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze resolved RATIS-648. -- Resolution: Fixed > Add metrics related to GrpcLogAppendRequests > - > > Key: RATIS-648 > URL: https://issues.apache.org/jira/browse/RATIS-648 > Project: Ratis > Issue Type: Sub-task > Components: server >Affects Versions: 0.4.0 >Reporter: Shashikant Banerjee >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: RATIS-648.00.patch, RATIS-648.01.patch, > RATIS-648.02.patch, RATIS-648.03.patch, RATIS-648.04.patch, RATIS-648.05.patch > > > Following metrics would be useful related to GrpcLogAppends for performance > and health monitoring and tuning: > |GrpcLogAppenderLatency|Time taken to append a log entry to each follower and > get acknowledgement| > |logAppendRetryCount|Total no of retried logAppends requests| > |logAppendRequestCount|Total no of logAppendRequest| > |appendEntryProcessingLatency|Time required to process an append entry > request on each follower| -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (RATIS-648) Add metrics related to GrpcLogAppendRequests
[ https://issues.apache.org/jira/browse/RATIS-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958307#comment-16958307 ] Tsz-wo Sze edited comment on RATIS-648 at 10/23/19 10:35 PM: - Discussed with [~swagle]. Let's fix this in RATIS-728 since it is change the code. was (Author: szetszwo): Discussed with [~swagle]. Let's fix this in RATIS-728. > Add metrics related to GrpcLogAppendRequests > - > > Key: RATIS-648 > URL: https://issues.apache.org/jira/browse/RATIS-648 > Project: Ratis > Issue Type: Sub-task > Components: server >Affects Versions: 0.4.0 >Reporter: Shashikant Banerjee >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: RATIS-648.00.patch, RATIS-648.01.patch, > RATIS-648.02.patch, RATIS-648.03.patch, RATIS-648.04.patch, RATIS-648.05.patch > > > Following metrics would be useful related to GrpcLogAppends for performance > and health monitoring and tuning: > |GrpcLogAppenderLatency|Time taken to append a log entry to each follower and > get acknowledgement| > |logAppendRetryCount|Total no of retried logAppends requests| > |logAppendRequestCount|Total no of logAppendRequest| > |appendEntryProcessingLatency|Time required to process an append entry > request on each follower| -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (RATIS-648) Add metrics related to GrpcLogAppendRequests
[ https://issues.apache.org/jira/browse/RATIS-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958307#comment-16958307 ] Tsz-wo Sze edited comment on RATIS-648 at 10/23/19 10:35 PM: - Discussed with [~swagle]. Let's fix this in RATIS-728 since it is changing the code. was (Author: szetszwo): Discussed with [~swagle]. Let's fix this in RATIS-728 since it is change the code. > Add metrics related to GrpcLogAppendRequests > - > > Key: RATIS-648 > URL: https://issues.apache.org/jira/browse/RATIS-648 > Project: Ratis > Issue Type: Sub-task > Components: server >Affects Versions: 0.4.0 >Reporter: Shashikant Banerjee >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: RATIS-648.00.patch, RATIS-648.01.patch, > RATIS-648.02.patch, RATIS-648.03.patch, RATIS-648.04.patch, RATIS-648.05.patch > > > Following metrics would be useful related to GrpcLogAppends for performance > and health monitoring and tuning: > |GrpcLogAppenderLatency|Time taken to append a log entry to each follower and > get acknowledgement| > |logAppendRetryCount|Total no of retried logAppends requests| > |logAppendRequestCount|Total no of logAppendRequest| > |appendEntryProcessingLatency|Time required to process an append entry > request on each follower| -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-648) Add metrics related to GrpcLogAppendRequests
[ https://issues.apache.org/jira/browse/RATIS-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958307#comment-16958307 ] Tsz-wo Sze commented on RATIS-648: -- Discussed with [~swagle]. Let's fix this in RATIS-728. > Add metrics related to GrpcLogAppendRequests > - > > Key: RATIS-648 > URL: https://issues.apache.org/jira/browse/RATIS-648 > Project: Ratis > Issue Type: Sub-task > Components: server >Affects Versions: 0.4.0 >Reporter: Shashikant Banerjee >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: RATIS-648.00.patch, RATIS-648.01.patch, > RATIS-648.02.patch, RATIS-648.03.patch, RATIS-648.04.patch, RATIS-648.05.patch > > > Following metrics would be useful related to GrpcLogAppends for performance > and health monitoring and tuning: > |GrpcLogAppenderLatency|Time taken to append a log entry to each follower and > get acknowledgement| > |logAppendRetryCount|Total no of retried logAppends requests| > |logAppendRequestCount|Total no of logAppendRequest| > |appendEntryProcessingLatency|Time required to process an append entry > request on each follower| -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-728) TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till it times out even though request succeeds
[ https://issues.apache.org/jira/browse/RATIS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze updated RATIS-728: - Attachment: r728_20191023.patch > TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till > it times out even though request succeeds > -- > > Key: RATIS-728 > URL: https://issues.apache.org/jira/browse/RATIS-728 > Project: Ratis > Issue Type: Bug > Components: gRPC >Reporter: Shashikant Banerjee >Assignee: Tsz-wo Sze >Priority: Major > Attachments: r728_20191023.patch > > > As discussed in RATIS-726, we need a similar fix for Append Request in > GrpcLogAppender to remove the references to appendEntryRequest as soon as the > response is received, thereby avoiding any memory pressure creation on the > server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-686) Enforce standard getter and setter names in config keys
[
https://issues.apache.org/jira/browse/RATIS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958273#comment-16958273
]
Hadoop QA commented on RATIS-686:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
57s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 39s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 5s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestRaftAsyncExceptionWithGrpc |
| | ratis.grpc.TestRaftOutputStreamWithGrpc |
| | ratis.grpc.TestRaftWithGrpc |
| | ratis.grpc.TestRaftServerWithGrpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.grpc.TestLeaderElectionWithGrpc |
| | ratis.examples.filestore.TestFileStoreAsyncWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/ratis:date2019-10-23 |
| JIRA Issue | RATIS-686 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983867/r686_20191023.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux bcd900c31c1c 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 55cbfbb |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1100/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1100/testReport/ |
| Max. process+thread count | 3293 (vs. ulimit of 5000) |
| modules | C: ratis-common ratis-client ratis-server ratis-grpc ratis-test
ratis-examples ratis-logservice U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1100/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Enforce standard getter and setter names in config keys
> ---
>
>
[jira] [Updated] (RATIS-728) TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till it times out even though request succeeds
[ https://issues.apache.org/jira/browse/RATIS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze updated RATIS-728: - Component/s: gRPC > TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till > it times out even though request succeeds > -- > > Key: RATIS-728 > URL: https://issues.apache.org/jira/browse/RATIS-728 > Project: Ratis > Issue Type: Bug > Components: gRPC >Reporter: Shashikant Banerjee >Assignee: Tsz-wo Sze >Priority: Major > > As discussed in RATIS-726, we need a similar fix for Append Request in > GrpcLogAppender to remove the references to appendEntryRequest as soon as the > response is received, thereby avoiding any memory pressure creation on the > server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-692) RaftStorageDirectory.tryLock throws a very deep IOException
[
https://issues.apache.org/jira/browse/RATIS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz-wo Sze updated RATIS-692:
-
Attachment: (was: image.png)
> RaftStorageDirectory.tryLock throws a very deep IOException
> ---
>
> Key: RATIS-692
> URL: https://issues.apache.org/jira/browse/RATIS-692
> Project: Ratis
> Issue Type: Sub-task
> Components: server
>Reporter: Clay B.
>Assignee: Tsz-wo Sze
>Priority: Major
> Labels: namazu
> Attachments: r692_20190928.patch, r692_20191002.patch,
> r692_20191003.patch
>
>
> Working with our Namazu infrastructure, the first issue I hit when dialing up
> the faulty I/O injection rate is as follows:
> {code}
> 2019-09-27 14:13:45 ERROR RaftStorageDirectory:336 - Failed to acquire lock
> on
> /home/vagrant/test_data/data0_slowed/64656d6f-5261-6674-4772-6f7570313233/in_use.lock.
> If this storage directory is mounted via NFS, ensure that the appropriate
> nfs lock services are running.
> java.io.IOException: Input/output error
> at java.io.RandomAccessFile.writeBytes(Native Method)
> at java.io.RandomAccessFile.write(RandomAccessFile.java:512)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.tryLock(RaftStorageDirectory.java:327)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.lock(RaftStorageDirectory.java:291)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.analyzeStorage(RaftStorageDirectory.java:264)
> at
> org.apache.ratis.server.storage.RaftStorage.analyzeAndRecoverStorage(RaftStorage.java:100)
> at
> org.apache.ratis.server.storage.RaftStorage.(RaftStorage.java:63)
> at
> org.apache.ratis.server.impl.ServerState.(ServerState.java:109)
> at
> org.apache.ratis.server.impl.RaftServerImpl.(RaftServerImpl.java:110)
> at
> org.apache.ratis.server.impl.RaftServerProxy.lambda$newRaftServerImpl$2(RaftServerProxy.java:208)
> at
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Exception in thread "main" java.io.IOException: Input/output error
> at java.io.RandomAccessFile.writeBytes(Native Method)
> at java.io.RandomAccessFile.write(RandomAccessFile.java:512)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.tryLock(RaftStorageDirectory.java:327)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.lock(RaftStorageDirectory.java:291)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.analyzeStorage(RaftStorageDirectory.java:264)
> at
> org.apache.ratis.server.storage.RaftStorage.analyzeAndRecoverStorage(RaftStorage.java:100)
> at
> org.apache.ratis.server.storage.RaftStorage.(RaftStorage.java:63)
> at
> org.apache.ratis.server.impl.ServerState.(ServerState.java:109)
> at
> org.apache.ratis.server.impl.RaftServerImpl.(RaftServerImpl.java:110)
> at
> org.apache.ratis.server.impl.RaftServerProxy.lambda$newRaftServerImpl$2(RaftServerProxy.java:208)
> at
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> It looks like the call chain does not re-try anywhere however.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RATIS-692) RaftStorageDirectory.tryLock throws a very deep IOException
[
https://issues.apache.org/jira/browse/RATIS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958266#comment-16958266
]
Hadoop QA commented on RATIS-692:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} RATIS-692 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.8.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | RATIS-692 |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1101/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> RaftStorageDirectory.tryLock throws a very deep IOException
> ---
>
> Key: RATIS-692
> URL: https://issues.apache.org/jira/browse/RATIS-692
> Project: Ratis
> Issue Type: Sub-task
> Components: server
>Reporter: Clay B.
>Assignee: Tsz-wo Sze
>Priority: Major
> Labels: namazu
> Attachments: image.png, r692_20190928.patch, r692_20191002.patch,
> r692_20191003.patch
>
>
> Working with our Namazu infrastructure, the first issue I hit when dialing up
> the faulty I/O injection rate is as follows:
> {code}
> 2019-09-27 14:13:45 ERROR RaftStorageDirectory:336 - Failed to acquire lock
> on
> /home/vagrant/test_data/data0_slowed/64656d6f-5261-6674-4772-6f7570313233/in_use.lock.
> If this storage directory is mounted via NFS, ensure that the appropriate
> nfs lock services are running.
> java.io.IOException: Input/output error
> at java.io.RandomAccessFile.writeBytes(Native Method)
> at java.io.RandomAccessFile.write(RandomAccessFile.java:512)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.tryLock(RaftStorageDirectory.java:327)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.lock(RaftStorageDirectory.java:291)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.analyzeStorage(RaftStorageDirectory.java:264)
> at
> org.apache.ratis.server.storage.RaftStorage.analyzeAndRecoverStorage(RaftStorage.java:100)
> at
> org.apache.ratis.server.storage.RaftStorage.(RaftStorage.java:63)
> at
> org.apache.ratis.server.impl.ServerState.(ServerState.java:109)
> at
> org.apache.ratis.server.impl.RaftServerImpl.(RaftServerImpl.java:110)
> at
> org.apache.ratis.server.impl.RaftServerProxy.lambda$newRaftServerImpl$2(RaftServerProxy.java:208)
> at
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Exception in thread "main" java.io.IOException: Input/output error
> at java.io.RandomAccessFile.writeBytes(Native Method)
> at java.io.RandomAccessFile.write(RandomAccessFile.java:512)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.tryLock(RaftStorageDirectory.java:327)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.lock(RaftStorageDirectory.java:291)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.analyzeStorage(RaftStorageDirectory.java:264)
> at
> org.apache.ratis.server.storage.RaftStorage.analyzeAndRecoverStorage(RaftStorage.java:100)
> at
> org.apache.ratis.server.storage.RaftStorage.(RaftStorage.java:63)
> at
> org.apache.ratis.server.impl.ServerState.(ServerState.java:109)
> at
> org.apache.ratis.server.impl.RaftServerImpl.(RaftServerImpl.java:110)
> at
> org.apache.ratis.server.impl.RaftServerProxy.lambda$newRaftServerImpl$2(RaftServerProxy.java:208)
> at
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> It looks like the call chain does not re-try anywhere however.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RATIS-695) Improve running in the face of flakey disks
[
https://issues.apache.org/jira/browse/RATIS-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958264#comment-16958264
]
Jitendra Nath Pandey commented on RATIS-695:
Thanks [~clayb] for this effort. This will go a long way in hardening Ratis
amidst failures.
> Improve running in the face of flakey disks
> ---
>
> Key: RATIS-695
> URL: https://issues.apache.org/jira/browse/RATIS-695
> Project: Ratis
> Issue Type: Improvement
> Components: server
>Reporter: Clay B.
>Priority: Minor
> Labels: namazu
>
> In testing with
> [Namazu|https://github.com/apache/incubator-ratis/blob/35838f032a4096d78843130fa1435bcddf5ce961/dev-support/vagrant/README.md#ratis-hdd-slowdown-vm]
> disk paths which fail in the face of {{IOException}}s are found. This
> umbrella-JIRA is to track the code paths found that need hardening. These
> code paths seem to be fatal to the Ratis server performing actions but does
> not cause the server to abort out.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (RATIS-695) Improve running in the face of flakey disks
[
https://issues.apache.org/jira/browse/RATIS-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jitendra Nath Pandey updated RATIS-695:
---
Labels: namazu (was: )
> Improve running in the face of flakey disks
> ---
>
> Key: RATIS-695
> URL: https://issues.apache.org/jira/browse/RATIS-695
> Project: Ratis
> Issue Type: Improvement
> Components: server
>Reporter: Clay B.
>Priority: Minor
> Labels: namazu
>
> In testing with
> [Namazu|https://github.com/apache/incubator-ratis/blob/35838f032a4096d78843130fa1435bcddf5ce961/dev-support/vagrant/README.md#ratis-hdd-slowdown-vm]
> disk paths which fail in the face of {{IOException}}s are found. This
> umbrella-JIRA is to track the code paths found that need hardening. These
> code paths seem to be fatal to the Ratis server performing actions but does
> not cause the server to abort out.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (RATIS-692) RaftStorageDirectory.tryLock throws a very deep IOException
[
https://issues.apache.org/jira/browse/RATIS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jitendra Nath Pandey updated RATIS-692:
---
Labels: namazu (was: )
> RaftStorageDirectory.tryLock throws a very deep IOException
> ---
>
> Key: RATIS-692
> URL: https://issues.apache.org/jira/browse/RATIS-692
> Project: Ratis
> Issue Type: Sub-task
> Components: server
>Reporter: Clay B.
>Assignee: Tsz-wo Sze
>Priority: Major
> Labels: namazu
> Attachments: image.png, r692_20190928.patch, r692_20191002.patch,
> r692_20191003.patch
>
>
> Working with our Namazu infrastructure, the first issue I hit when dialing up
> the faulty I/O injection rate is as follows:
> {code}
> 2019-09-27 14:13:45 ERROR RaftStorageDirectory:336 - Failed to acquire lock
> on
> /home/vagrant/test_data/data0_slowed/64656d6f-5261-6674-4772-6f7570313233/in_use.lock.
> If this storage directory is mounted via NFS, ensure that the appropriate
> nfs lock services are running.
> java.io.IOException: Input/output error
> at java.io.RandomAccessFile.writeBytes(Native Method)
> at java.io.RandomAccessFile.write(RandomAccessFile.java:512)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.tryLock(RaftStorageDirectory.java:327)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.lock(RaftStorageDirectory.java:291)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.analyzeStorage(RaftStorageDirectory.java:264)
> at
> org.apache.ratis.server.storage.RaftStorage.analyzeAndRecoverStorage(RaftStorage.java:100)
> at
> org.apache.ratis.server.storage.RaftStorage.(RaftStorage.java:63)
> at
> org.apache.ratis.server.impl.ServerState.(ServerState.java:109)
> at
> org.apache.ratis.server.impl.RaftServerImpl.(RaftServerImpl.java:110)
> at
> org.apache.ratis.server.impl.RaftServerProxy.lambda$newRaftServerImpl$2(RaftServerProxy.java:208)
> at
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Exception in thread "main" java.io.IOException: Input/output error
> at java.io.RandomAccessFile.writeBytes(Native Method)
> at java.io.RandomAccessFile.write(RandomAccessFile.java:512)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.tryLock(RaftStorageDirectory.java:327)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.lock(RaftStorageDirectory.java:291)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.analyzeStorage(RaftStorageDirectory.java:264)
> at
> org.apache.ratis.server.storage.RaftStorage.analyzeAndRecoverStorage(RaftStorage.java:100)
> at
> org.apache.ratis.server.storage.RaftStorage.(RaftStorage.java:63)
> at
> org.apache.ratis.server.impl.ServerState.(ServerState.java:109)
> at
> org.apache.ratis.server.impl.RaftServerImpl.(RaftServerImpl.java:110)
> at
> org.apache.ratis.server.impl.RaftServerProxy.lambda$newRaftServerImpl$2(RaftServerProxy.java:208)
> at
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> It looks like the call chain does not re-try anywhere however.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RATIS-704) Invoke sendAsync as soon as OrderedAsync is created
[
https://issues.apache.org/jira/browse/RATIS-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958259#comment-16958259
]
Hadoop QA commented on RATIS-704:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
8s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 18m 34s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 12s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.grpc.TestRaftReconfigurationWithGrpc |
| | ratis.grpc.TestRaftWithGrpc |
| | ratis.netty.TestRaftExceptionWithNetty |
| | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.grpc.TestLeaderElectionWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/ratis:date2019-10-23 |
| JIRA Issue | RATIS-704 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983866/r704_20191023.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux ae396ad9cee7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 55cbfbb |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1099/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1099/testReport/ |
| Max. process+thread count | 3487 (vs. ulimit of 5000) |
| modules | C: ratis-common ratis-client ratis-server ratis-grpc U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1099/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Invoke sendAsync as soon as OrderedAsync is created
> ---
>
> Key: RATIS-704
> URL:
[jira] [Updated] (RATIS-692) RaftStorageDirectory.tryLock throws a very deep IOException
[
https://issues.apache.org/jira/browse/RATIS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz-wo Sze updated RATIS-692:
-
Attachment: image.png
> RaftStorageDirectory.tryLock throws a very deep IOException
> ---
>
> Key: RATIS-692
> URL: https://issues.apache.org/jira/browse/RATIS-692
> Project: Ratis
> Issue Type: Sub-task
> Components: server
>Reporter: Clay B.
>Assignee: Tsz-wo Sze
>Priority: Major
> Attachments: image.png, r692_20190928.patch, r692_20191002.patch,
> r692_20191003.patch
>
>
> Working with our Namazu infrastructure, the first issue I hit when dialing up
> the faulty I/O injection rate is as follows:
> {code}
> 2019-09-27 14:13:45 ERROR RaftStorageDirectory:336 - Failed to acquire lock
> on
> /home/vagrant/test_data/data0_slowed/64656d6f-5261-6674-4772-6f7570313233/in_use.lock.
> If this storage directory is mounted via NFS, ensure that the appropriate
> nfs lock services are running.
> java.io.IOException: Input/output error
> at java.io.RandomAccessFile.writeBytes(Native Method)
> at java.io.RandomAccessFile.write(RandomAccessFile.java:512)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.tryLock(RaftStorageDirectory.java:327)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.lock(RaftStorageDirectory.java:291)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.analyzeStorage(RaftStorageDirectory.java:264)
> at
> org.apache.ratis.server.storage.RaftStorage.analyzeAndRecoverStorage(RaftStorage.java:100)
> at
> org.apache.ratis.server.storage.RaftStorage.(RaftStorage.java:63)
> at
> org.apache.ratis.server.impl.ServerState.(ServerState.java:109)
> at
> org.apache.ratis.server.impl.RaftServerImpl.(RaftServerImpl.java:110)
> at
> org.apache.ratis.server.impl.RaftServerProxy.lambda$newRaftServerImpl$2(RaftServerProxy.java:208)
> at
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Exception in thread "main" java.io.IOException: Input/output error
> at java.io.RandomAccessFile.writeBytes(Native Method)
> at java.io.RandomAccessFile.write(RandomAccessFile.java:512)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.tryLock(RaftStorageDirectory.java:327)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.lock(RaftStorageDirectory.java:291)
> at
> org.apache.ratis.server.storage.RaftStorageDirectory.analyzeStorage(RaftStorageDirectory.java:264)
> at
> org.apache.ratis.server.storage.RaftStorage.analyzeAndRecoverStorage(RaftStorage.java:100)
> at
> org.apache.ratis.server.storage.RaftStorage.(RaftStorage.java:63)
> at
> org.apache.ratis.server.impl.ServerState.(ServerState.java:109)
> at
> org.apache.ratis.server.impl.RaftServerImpl.(RaftServerImpl.java:110)
> at
> org.apache.ratis.server.impl.RaftServerProxy.lambda$newRaftServerImpl$2(RaftServerProxy.java:208)
> at
> java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1590)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> It looks like the call chain does not re-try anywhere however.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RATIS-686) Enforce standard getter and setter names in config keys
[ https://issues.apache.org/jira/browse/RATIS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958251#comment-16958251 ] Tsz-wo Sze commented on RATIS-686: -- r686_20191023.patch: updated with master. > Enforce standard getter and setter names in config keys > --- > > Key: RATIS-686 > URL: https://issues.apache.org/jira/browse/RATIS-686 > Project: Ratis > Issue Type: Improvement > Components: conf >Reporter: Tsz-wo Sze >Assignee: Tsz-wo Sze >Priority: Major > Attachments: r686_20190919.patch, r686_20190919b.patch, > r686_20190919c.patch, r686_20191023.patch > > > In the conf keys, some getter/setter methods are missing. Some of the method > names are not using the standard naming convention. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-686) Enforce standard getter and setter names in config keys
[ https://issues.apache.org/jira/browse/RATIS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze updated RATIS-686: - Attachment: r686_20191023.patch > Enforce standard getter and setter names in config keys > --- > > Key: RATIS-686 > URL: https://issues.apache.org/jira/browse/RATIS-686 > Project: Ratis > Issue Type: Improvement > Components: conf >Reporter: Tsz-wo Sze >Assignee: Tsz-wo Sze >Priority: Major > Attachments: r686_20190919.patch, r686_20190919b.patch, > r686_20190919c.patch, r686_20191023.patch > > > In the conf keys, some getter/setter methods are missing. Some of the method > names are not using the standard naming convention. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (RATIS-648) Add metrics related to GrpcLogAppendRequests
[ https://issues.apache.org/jira/browse/RATIS-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze reopened RATIS-648: -- Any plan fixing this? > Add metrics related to GrpcLogAppendRequests > - > > Key: RATIS-648 > URL: https://issues.apache.org/jira/browse/RATIS-648 > Project: Ratis > Issue Type: Sub-task > Components: server >Affects Versions: 0.4.0 >Reporter: Shashikant Banerjee >Assignee: Siddharth Wagle >Priority: Major > Fix For: 0.5.0 > > Attachments: RATIS-648.00.patch, RATIS-648.01.patch, > RATIS-648.02.patch, RATIS-648.03.patch, RATIS-648.04.patch, RATIS-648.05.patch > > > Following metrics would be useful related to GrpcLogAppends for performance > and health monitoring and tuning: > |GrpcLogAppenderLatency|Time taken to append a log entry to each follower and > get acknowledgement| > |logAppendRetryCount|Total no of retried logAppends requests| > |logAppendRequestCount|Total no of logAppendRequest| > |appendEntryProcessingLatency|Time required to process an append entry > request on each follower| -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-704) Invoke sendAsync as soon as OrderedAsync is created
[
https://issues.apache.org/jira/browse/RATIS-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958244#comment-16958244
]
Hadoop QA commented on RATIS-704:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
2s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m 55s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 30s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.examples.filestore.TestFileStoreWithNetty |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.grpc.TestRaftReconfigurationWithGrpc |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.grpc.TestLeaderElectionWithGrpc |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.grpc.TestServerRestartWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/ratis:date2019-10-23 |
| JIRA Issue | RATIS-704 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983866/r704_20191023.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux d880d48aed3d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 55cbfbb |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1098/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1098/testReport/ |
| Max. process+thread count | 4849 (vs. ulimit of 5000) |
| modules | C: ratis-common ratis-client ratis-server ratis-grpc U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1098/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Invoke sendAsync as soon as OrderedAsync is created
>
[jira] [Commented] (RATIS-699) Dependency is relying on system dependency jdk:tools:1.X
[ https://issues.apache.org/jira/browse/RATIS-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958224#comment-16958224 ] Tsz-wo Sze commented on RATIS-699: -- How about we roll a 0.5.0 release, say, within one or two weeks? Does it work for you? > Dependency is relying on system dependency jdk:tools:1.X > > > Key: RATIS-699 > URL: https://issues.apache.org/jira/browse/RATIS-699 > Project: Ratis > Issue Type: Bug > Components: metrics >Affects Versions: 0.4.0 >Reporter: Henrik Hegardt >Assignee: Henrik Hegardt >Priority: Minor > Attachments: RATIS-699.03.patch, tree_new, tree_orig > > > Ratis-Metric is depending on the dependency > com.github.joshelser:dropwizard-metrics-hadoop-metrics2-reporter: 0.1.2. This > in turn depends on the org.apache.hadoop:hadoop-common:2.6.0. This in turn > depends on org.apache.hadoop:hadoop-annotations:2.6.0 which have an > dependency on a system scoped dependency named jdk.tools:1.6. I'm running > java 11 and this dependency doesn't exist in my environment so I can't > compile with ratis included in my project because it fails trying to resolve > that dependency. > However, the project ratis-hadoop depends on the the dependency > org.apache.hadoop:hadoop-common:3.1.1 (which should be upgraded to 3.1.2 > because the sources are missing in 3.1.1) which doesn't have the > jdk.tools:1.6 dependency. So if I depend on this I can build the project > because the faulty 2.6.0 dependency is shadowed transitively by the 3.1.1 > dependency and everything is compiling. > The simple fix would be updating so ratis-metric is depending directly on the > 3.1.2 dependency instead since it effectively will be the 3.1.1 code you are > going run with anyway when running with the ratis-hadoop dependency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-704) Invoke sendAsync as soon as OrderedAsync is created
[ https://issues.apache.org/jira/browse/RATIS-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958221#comment-16958221 ] Tsz-wo Sze commented on RATIS-704: -- Thanks [~ljain]. r704_20191023.patch: fixes TestRaftAsyncExceptionWithGrpc. The patch also fixes a bug from RATIS-726 which breaks TestRaftAsyncExceptionWithGrpc.testTimeoutException. > Invoke sendAsync as soon as OrderedAsync is created > --- > > Key: RATIS-704 > URL: https://issues.apache.org/jira/browse/RATIS-704 > Project: Ratis > Issue Type: Improvement > Components: client >Reporter: Tsz-wo Sze >Assignee: Tsz-wo Sze >Priority: Major > Labels: ozone > Attachments: r704_20191009.patch, r704_20191011.patch, > r704_20191018.patch, r704_20191022.patch, r704_20191023.patch > > > In OrderedAsync, the messages are sent asynchronously except for the first > message. The first message is used to establish the connection. > OrderedAsync will wait for the first message to complete before sending the > following messages. > Note that, when sending only two messages, the performance of sending the > messages asynchronously is degenerated to sending them sequentially > [~msingh] has discovered a case that can be optimized: an application may > send two or more messages and the first message may take a long time to > process. In this case, we may send a dummy lightweighted message establish > the connection, and then send real messages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-704) Invoke sendAsync as soon as OrderedAsync is created
[ https://issues.apache.org/jira/browse/RATIS-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze updated RATIS-704: - Attachment: r704_20191023.patch > Invoke sendAsync as soon as OrderedAsync is created > --- > > Key: RATIS-704 > URL: https://issues.apache.org/jira/browse/RATIS-704 > Project: Ratis > Issue Type: Improvement > Components: client >Reporter: Tsz-wo Sze >Assignee: Tsz-wo Sze >Priority: Major > Labels: ozone > Attachments: r704_20191009.patch, r704_20191011.patch, > r704_20191018.patch, r704_20191022.patch, r704_20191023.patch > > > In OrderedAsync, the messages are sent asynchronously except for the first > message. The first message is used to establish the connection. > OrderedAsync will wait for the first message to complete before sending the > following messages. > Note that, when sending only two messages, the performance of sending the > messages asynchronously is degenerated to sending them sequentially > [~msingh] has discovered a case that can be optimized: an application may > send two or more messages and the first message may take a long time to > process. In this case, we may send a dummy lightweighted message establish > the connection, and then send real messages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-704) Invoke sendAsync as soon as OrderedAsync is created
[ https://issues.apache.org/jira/browse/RATIS-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze updated RATIS-704: - Attachment: (was: r704_20191023.patch) > Invoke sendAsync as soon as OrderedAsync is created > --- > > Key: RATIS-704 > URL: https://issues.apache.org/jira/browse/RATIS-704 > Project: Ratis > Issue Type: Improvement > Components: client >Reporter: Tsz-wo Sze >Assignee: Tsz-wo Sze >Priority: Major > Labels: ozone > Attachments: r704_20191009.patch, r704_20191011.patch, > r704_20191018.patch, r704_20191022.patch, r704_20191023.patch > > > In OrderedAsync, the messages are sent asynchronously except for the first > message. The first message is used to establish the connection. > OrderedAsync will wait for the first message to complete before sending the > following messages. > Note that, when sending only two messages, the performance of sending the > messages asynchronously is degenerated to sending them sequentially > [~msingh] has discovered a case that can be optimized: an application may > send two or more messages and the first message may take a long time to > process. In this case, we may send a dummy lightweighted message establish > the connection, and then send real messages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-704) Invoke sendAsync as soon as OrderedAsync is created
[ https://issues.apache.org/jira/browse/RATIS-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze updated RATIS-704: - Attachment: r704_20191023.patch > Invoke sendAsync as soon as OrderedAsync is created > --- > > Key: RATIS-704 > URL: https://issues.apache.org/jira/browse/RATIS-704 > Project: Ratis > Issue Type: Improvement > Components: client >Reporter: Tsz-wo Sze >Assignee: Tsz-wo Sze >Priority: Major > Labels: ozone > Attachments: r704_20191009.patch, r704_20191011.patch, > r704_20191018.patch, r704_20191022.patch, r704_20191023.patch > > > In OrderedAsync, the messages are sent asynchronously except for the first > message. The first message is used to establish the connection. > OrderedAsync will wait for the first message to complete before sending the > following messages. > Note that, when sending only two messages, the performance of sending the > messages asynchronously is degenerated to sending them sequentially > [~msingh] has discovered a case that can be optimized: an application may > send two or more messages and the first message may take a long time to > process. In this case, we may send a dummy lightweighted message establish > the connection, and then send real messages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-407) Update grpc version to 1.24.0 and protobuf to 3.10.0 in Ratis thirdparty
[
https://issues.apache.org/jira/browse/RATIS-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958002#comment-16958002
]
Josh Elser commented on RATIS-407:
--
Talked to Mukul offline – he didn't have any reason that we should have to bump
to 3.1.2 and neither of us know of anything that we would be proactively
fixing. So we can leave the Hadoop version as-is for now.
{quote}I already tested this with Ratis-thrdparty unit test, Ratis unit test
and have also used this version in Ozone for verification.
{quote}
Thanks for testing that. +1 if all of that looks good.
> Update grpc version to 1.24.0 and protobuf to 3.10.0 in Ratis thirdparty
>
>
> Key: RATIS-407
> URL: https://issues.apache.org/jira/browse/RATIS-407
> Project: Ratis
> Issue Type: Bug
> Components: thirdparty
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Attachments: RATIS-407.001.patch, RATIS-407.002.patch
>
>
> Ratis currently uses Grpc version 1.14.0. This can be updated to 1.16.0.
> Along with this protobuf version can be updated to 3.5.1 and Netty to
> 4.1.30.Final.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (RATIS-603) Add a logStringSupplier for RaftServerImpl to optionally print SmLogEntry on errors
[
https://issues.apache.org/jira/browse/RATIS-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957783#comment-16957783
]
Hadoop QA commented on RATIS-603:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 19m 34s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 51s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.grpc.TestRaftWithGrpc |
| | ratis.netty.TestRaftReconfigurationWithNetty |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/ratis:date2019-10-23 |
| JIRA Issue | RATIS-603 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983827/RATIS-603.008.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux 7819ec89a859 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build@2/yetus-personality.sh
|
| git revision | master / c76ab77 |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1097/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1097/testReport/ |
| Max. process+thread count | 1800 (vs. ulimit of 5000) |
| modules | C: ratis-server U: ratis-server |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1097/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Add a logStringSupplier for RaftServerImpl to optionally print SmLogEntry on
> errors
> ---
>
> Key: RATIS-603
> URL: https://issues.apache.org/jira/browse/RATIS-603
> Project: Ratis
> Issue Type: New Feature
> Components: server
>Affects
[jira] [Resolved] (RATIS-346) Provide an option for raft server to not join Raft ring on restart
[ https://issues.apache.org/jira/browse/RATIS-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh resolved RATIS-346. - Resolution: Invalid > Provide an option for raft server to not join Raft ring on restart > -- > > Key: RATIS-346 > URL: https://issues.apache.org/jira/browse/RATIS-346 > Project: Ratis > Issue Type: Bug > Components: server >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > > On restart on a Ratis server, it may be desirable to not allow the node to > rejoin the raft ring. This jira proposes to add a config parameter to let the > server do this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-603) Add a logStringSupplier for RaftServerImpl to optionally print SmLogEntry on errors
[
https://issues.apache.org/jira/browse/RATIS-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957771#comment-16957771
]
Hadoop QA commented on RATIS-603:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 55s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 6s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.server.TestMetaServer |
| | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.grpc.TestRaftWithGrpc |
| | ratis.netty.TestRaftReconfigurationWithNetty |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.grpc.TestLeaderElectionWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/ratis:date2019-10-23 |
| JIRA Issue | RATIS-603 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983826/RATIS-603.007.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux 1ef769d315fc 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / c76ab77 |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1096/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1096/testReport/ |
| Max. process+thread count | 3452 (vs. ulimit of 5000) |
| modules | C: ratis-server U: ratis-server |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1096/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Add a logStringSupplier for RaftServerImpl to optionally print SmLogEntry on
> errors
> ---
>
> Key: RATIS-603
> URL: https://issues.apache.org/jira/browse/RATIS-603
> Project: Ratis
> Issue Type: New Feature
> Components: server
>Affects Versions: 0.4.0
>
[jira] [Commented] (RATIS-707) Test failures caused by minTimeout set to zero
[
https://issues.apache.org/jira/browse/RATIS-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957762#comment-16957762
]
Mukul Kumar Singh commented on RATIS-707:
-
[~swagle] [~szetszwo] should we reopen RATIS-698 ? To start the discussion on
how we can solve the initial leader election issue ?
> Test failures caused by minTimeout set to zero
> --
>
> Key: RATIS-707
> URL: https://issues.apache.org/jira/browse/RATIS-707
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.5.0
>Reporter: Siddharth Wagle
>Assignee: Siddharth Wagle
>Priority: Major
> Fix For: 0.5.0
>
> Attachments: RATIS-707.01.patch, RATIS-707.01.patch
>
>
> TestRaftAsyncWithGrpc#testBasicAppendEntriesAsync and other tests fail if the
> initial minTimeout is 0 then the server can trigger a leader election much
> more frequently because the heartbeat interval is still at minTimeoutMs/2
> {code}
> 2019-10-11 00:45:47,813 INFO impl.FollowerState
> (FollowerState.java:run(108)) - s0@group-C51B0F2AC202-FollowerState: change
> to CANDIDATE, lastRpcTime:21ms, electionTimeout:17ms
> 2019-10-11 00:45:47,870 INFO impl.FollowerState
> (FollowerState.java:run(108)) - s0@group-C51B0F2AC202-FollowerState: change
> to CANDIDATE, lastRpcTime:35ms, electionTimeout:31ms
> 2019-10-11 00:45:47,933 INFO impl.FollowerState
> (FollowerState.java:run(108)) - s0@group-C51B0F2AC202-FollowerState: change
> to CANDIDATE, lastRpcTime:51ms, electionTimeout:51ms
> 2019-10-11 00:45:47,969 INFO impl.FollowerState
> (FollowerState.java:run(108)) - s0@group-C51B0F2AC202-FollowerState: change
> to CANDIDATE, lastRpcTime:22ms, electionTimeout:21ms
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (RATIS-603) Add a logStringSupplier for RaftServerImpl to optionally print SmLogEntry on errors
[ https://issues.apache.org/jira/browse/RATIS-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh updated RATIS-603: Attachment: RATIS-603.008.patch > Add a logStringSupplier for RaftServerImpl to optionally print SmLogEntry on > errors > --- > > Key: RATIS-603 > URL: https://issues.apache.org/jira/browse/RATIS-603 > Project: Ratis > Issue Type: New Feature > Components: server >Affects Versions: 0.4.0 >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Labels: ozone > Attachments: RATIS-603.001.patch, RATIS-603.002.patch, > RATIS-603.003.patch, RATIS-603.004.patch, RATIS-603.005.patch, > RATIS-603.006.patch, RATIS-603.007.patch, RATIS-603.008.patch > > > This jira proposes to add a SmLogEntryProto to toString converter so that > logEntry information can be printed on errors/exceptions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-603) Add a logStringSupplier for RaftServerImpl to optionally print SmLogEntry on errors
[ https://issues.apache.org/jira/browse/RATIS-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957756#comment-16957756 ] Mukul Kumar Singh commented on RATIS-603: - Thanks for the review [~szetszwo]. Patch v8 fixes the review comments. > Add a logStringSupplier for RaftServerImpl to optionally print SmLogEntry on > errors > --- > > Key: RATIS-603 > URL: https://issues.apache.org/jira/browse/RATIS-603 > Project: Ratis > Issue Type: New Feature > Components: server >Affects Versions: 0.4.0 >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Labels: ozone > Attachments: RATIS-603.001.patch, RATIS-603.002.patch, > RATIS-603.003.patch, RATIS-603.004.patch, RATIS-603.005.patch, > RATIS-603.006.patch, RATIS-603.007.patch, RATIS-603.008.patch > > > This jira proposes to add a SmLogEntryProto to toString converter so that > logEntry information can be printed on errors/exceptions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-603) Add a logStringSupplier for RaftServerImpl to optionally print SmLogEntry on errors
[ https://issues.apache.org/jira/browse/RATIS-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh updated RATIS-603: Attachment: RATIS-603.007.patch > Add a logStringSupplier for RaftServerImpl to optionally print SmLogEntry on > errors > --- > > Key: RATIS-603 > URL: https://issues.apache.org/jira/browse/RATIS-603 > Project: Ratis > Issue Type: New Feature > Components: server >Affects Versions: 0.4.0 >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Labels: ozone > Attachments: RATIS-603.001.patch, RATIS-603.002.patch, > RATIS-603.003.patch, RATIS-603.004.patch, RATIS-603.005.patch, > RATIS-603.006.patch, RATIS-603.007.patch > > > This jira proposes to add a SmLogEntryProto to toString converter so that > logEntry information can be printed on errors/exceptions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-704) Invoke sendAsync as soon as OrderedAsync is created
[ https://issues.apache.org/jira/browse/RATIS-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957729#comment-16957729 ] Lokesh Jain commented on RATIS-704: --- [~szetszwo] Thanks for updating the patch! TestRaftAsyncExceptionWithGrpc fails consistently with the patch. > Invoke sendAsync as soon as OrderedAsync is created > --- > > Key: RATIS-704 > URL: https://issues.apache.org/jira/browse/RATIS-704 > Project: Ratis > Issue Type: Improvement > Components: client >Reporter: Tsz-wo Sze >Assignee: Tsz-wo Sze >Priority: Major > Labels: ozone > Attachments: r704_20191009.patch, r704_20191011.patch, > r704_20191018.patch, r704_20191022.patch > > > In OrderedAsync, the messages are sent asynchronously except for the first > message. The first message is used to establish the connection. > OrderedAsync will wait for the first message to complete before sending the > following messages. > Note that, when sending only two messages, the performance of sending the > messages asynchronously is degenerated to sending them sequentially > [~msingh] has discovered a case that can be optimized: an application may > send two or more messages and the first message may take a long time to > process. In this case, we may send a dummy lightweighted message establish > the connection, and then send real messages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index
[
https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957650#comment-16957650
]
Hadoop QA commented on RATIS-457:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
55s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} root: The patch generated 0 new + 8 unchanged - 1
fixed = 8 total (was 9) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 22m 13s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 31m 39s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestRaftWithGrpc |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.examples.filestore.TestFileStoreWithNetty |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/ratis:date2019-10-23 |
| JIRA Issue | RATIS-457 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983811/RATIS-457.004.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile cc |
| uname | Linux e00cbddf5f68 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / c76ab77 |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1095/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1095/testReport/ |
| Max. process+thread count | 1378 (vs. ulimit of 5000) |
| modules | C: ratis-proto ratis-server ratis-grpc U: . |
| Console output |
[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957638#comment-16957638 ] Lokesh Jain commented on RATIS-457: --- v4 patch fixes checkstyle issue. The unit tests pass in my local machine. > Timed out append entry reply should update follower match index, commit index > - > > Key: RATIS-457 > URL: https://issues.apache.org/jira/browse/RATIS-457 > Project: Ratis > Issue Type: Bug >Reporter: Lokesh Jain >Assignee: Lokesh Jain >Priority: Major > Labels: ozone > Attachments: RATIS-457.001.patch, RATIS-457.002.patch, > RATIS-457.003.patch, RATIS-457.004.patch > > > Currently all the timed out append entry replies are ignored by the leader. > These replies have information like match index which can be updated by > leader. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-457) Timed out append entry reply should update follower match index, commit index
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Jain updated RATIS-457: -- Attachment: RATIS-457.004.patch > Timed out append entry reply should update follower match index, commit index > - > > Key: RATIS-457 > URL: https://issues.apache.org/jira/browse/RATIS-457 > Project: Ratis > Issue Type: Bug >Reporter: Lokesh Jain >Assignee: Lokesh Jain >Priority: Major > Labels: ozone > Attachments: RATIS-457.001.patch, RATIS-457.002.patch, > RATIS-457.003.patch, RATIS-457.004.patch > > > Currently all the timed out append entry replies are ignored by the leader. > These replies have information like match index which can be updated by > leader. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index
[
https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957632#comment-16957632
]
Hadoop QA commented on RATIS-457:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m
54s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 10s{color} | {color:orange} root: The patch generated 1 new + 8 unchanged -
1 fixed = 9 total (was 9) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 23s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 53m 11s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.TestLogServiceWithNetty |
| | ratis.logservice.server.TestMetaServer |
| | ratis.logservice.TestLogServiceWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithNetty |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.grpc.TestRetryCacheWithGrpc |
| | ratis.server.simulation.TestServerRestartWithSimulatedRpc |
| | ratis.server.raftlog.TestRaftLogMetrics |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.grpc.TestRaftStateMachineExceptionWithGrpc |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/ratis:date2019-10-23 |
| JIRA Issue | RATIS-457 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983805/RATIS-457.003.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile cc |
| uname | Linux fba5576257a5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / c76ab77 |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
[jira] [Created] (RATIS-729) ClientProtoUtils#toRaftClientReplyProto should consider all RaftException types
Lokesh Jain created RATIS-729: - Summary: ClientProtoUtils#toRaftClientReplyProto should consider all RaftException types Key: RATIS-729 URL: https://issues.apache.org/jira/browse/RATIS-729 Project: Ratis Issue Type: Bug Reporter: Lokesh Jain In one of the runs it is seen that client receives RaftClientReply with exception as null and success flag as false. This happens because currently ClientProtoUtils#toRaftClientReplyProto only considers a few RaftException types while creating a RaftClientReplyProto. We should also add handling for other exception types.Similar changes will be required in ClientProtoUtils#toRaftClientReply. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-704) Invoke sendAsync as soon as OrderedAsync is created
[ https://issues.apache.org/jira/browse/RATIS-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh updated RATIS-704: Labels: ozone (was: ) > Invoke sendAsync as soon as OrderedAsync is created > --- > > Key: RATIS-704 > URL: https://issues.apache.org/jira/browse/RATIS-704 > Project: Ratis > Issue Type: Improvement > Components: client >Reporter: Tsz-wo Sze >Assignee: Tsz-wo Sze >Priority: Major > Labels: ozone > Attachments: r704_20191009.patch, r704_20191011.patch, > r704_20191018.patch, r704_20191022.patch > > > In OrderedAsync, the messages are sent asynchronously except for the first > message. The first message is used to establish the connection. > OrderedAsync will wait for the first message to complete before sending the > following messages. > Note that, when sending only two messages, the performance of sending the > messages asynchronously is degenerated to sending them sequentially > [~msingh] has discovered a case that can be optimized: an application may > send two or more messages and the first message may take a long time to > process. In this case, we may send a dummy lightweighted message establish > the connection, and then send real messages. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RATIS-726) TimeoutScheduler holds on to the raftClientRequest till it times out even though request succeeds
[ https://issues.apache.org/jira/browse/RATIS-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957616#comment-16957616 ] Shashikant Banerjee commented on RATIS-726: --- Thanks [~szetszwo]. The changes look good to me. I am +1 on this change. I will commit this shortly. Filed RATIS-728 to address the similar issue in Server side. > TimeoutScheduler holds on to the raftClientRequest till it times out even > though request succeeds > - > > Key: RATIS-726 > URL: https://issues.apache.org/jira/browse/RATIS-726 > Project: Ratis > Issue Type: Bug > Components: client >Reporter: Shashikant Banerjee >Assignee: Tsz-wo Sze >Priority: Major > Attachments: r726_20191022.patch > > > While running freon with 1 Node ratis, it was observed that the > TimeoutScheduler holds on to the raftClientObject atleast for 3s(default for > requestTimeoutDuration) even though the request is processed successfully and > acknowledged back. This ends up creating a memory pressure causing ozone > client to go OOM . > Heapdump analysis of HDDS-2331 , it seems the timeout schduler holding onto > total of 176 requests, (88 of writeChunk containing actual data and 88 > putBlock requests) although data write is happening sequentially key by key > in ozone. > Thanks [~adoroszlai] for helping out discovering this. > cc ~ [~ljain] [~msingh] [~szetszwo] [~jnpandey] > Similar fix may be required in GrpCLogAppender as well it uses the same > TimeoutScheduler. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (RATIS-728) TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till it times out even though request succeeds
[ https://issues.apache.org/jira/browse/RATIS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee reassigned RATIS-728: - Assignee: Tsz-wo Sze > TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till > it times out even though request succeeds > -- > > Key: RATIS-728 > URL: https://issues.apache.org/jira/browse/RATIS-728 > Project: Ratis > Issue Type: Bug >Reporter: Shashikant Banerjee >Assignee: Tsz-wo Sze >Priority: Major > > As discussed in RATIS-726, we need a similar fix for Append Request in > GrpcLogAppender to remove the references to appendEntryRequest as soon as the > response is received, thereby avoiding any memory pressure creation on the > server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (RATIS-728) TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till it times out even though request succeeds
Shashikant Banerjee created RATIS-728: - Summary: TimeoutScheduler for GrpcLogAppender holds on to the AppendEntryRequest till it times out even though request succeeds Key: RATIS-728 URL: https://issues.apache.org/jira/browse/RATIS-728 Project: Ratis Issue Type: Bug Reporter: Shashikant Banerjee As discussed in RATIS-726, we need a similar fix for Append Request in GrpcLogAppender to remove the references to appendEntryRequest as soon as the response is received, thereby avoiding any memory pressure creation on the server. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (RATIS-724) Leader election seem to timeout in Ratis
[
https://issues.apache.org/jira/browse/RATIS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Kumar Singh resolved RATIS-724.
-
Resolution: Not A Problem
Adding hostname entry to /etc/hosts resolves the issue. Closing this.
> Leader election seem to timeout in Ratis
>
>
> Key: RATIS-724
> URL: https://issues.apache.org/jira/browse/RATIS-724
> Project: Ratis
> Issue Type: Bug
>Reporter: Shashikant Banerjee
>Priority: Blocker
> Fix For: 0.5.0
>
>
> {code:java}
> java.util.concurrent.ExecutionException:
> org.apache.ratis.thirdparty.io.grpc.StatusRuntimeException: INTERNAL:
> e9477db3-627c-447b-9726-7a0202331e44@group-284D2F681BFD is not in [RUNNING]:
> current state is NEWjava.util.concurrent.ExecutionException:
> org.apache.ratis.thirdparty.io.grpc.StatusRuntimeException: INTERNAL:
> e9477db3-627c-447b-9726-7a0202331e44@group-284D2F681BFD is not in [RUNNING]:
> current state is NEW at
> java.util.concurrent.FutureTask.report(FutureTask.java:122) at
> java.util.concurrent.FutureTask.get(FutureTask.java:192) at
> org.apache.ratis.server.impl.LeaderElection.waitForResults(LeaderElection.java:259)
> at
> org.apache.ratis.server.impl.LeaderElection.askForVotes(LeaderElection.java:197)
> at org.apache.ratis.server.impl.LeaderElection.run(LeaderElection.java:133)
> at java.lang.Thread.run(Thread.java:748)Caused by:
> org.apache.ratis.thirdparty.io.grpc.StatusRuntimeException: INTERNAL:
> e9477db3-627c-447b-9726-7a0202331e44@group-284D2F681BFD is not in [RUNNING]:
> current state is NEW at
> org.apache.ratis.thirdparty.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:233)
> at
> org.apache.ratis.thirdparty.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:214)
> at
> org.apache.ratis.thirdparty.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:139)
> at
> org.apache.ratis.proto.grpc.RaftServerProtocolServiceGrpc$RaftServerProtocolServiceBlockingStub.requestVote(RaftServerProtocolServiceGrpc.java:265)
> at
> org.apache.ratis.grpc.server.GrpcServerProtocolClient.requestVote(GrpcServerProtocolClient.java:99)
> at
> org.apache.ratis.grpc.server.GrpcService.requestVote(GrpcService.java:204) at
> org.apache.ratis.server.impl.LeaderElection.lambda$submitRequests$1(LeaderElection.java:234)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at
> java.util.concurrent.FutureTask.run(FutureTask.java:266) at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> ... 1 more2019-10-21 17:40:18,702
> [4ed74939-427d-455d-852a-df3499c9dbb2@group-284D2F681BFD-LeaderElection1]
> INFO impl.LeaderElection (LogUtils.java:infoOrTrace(149)) -
> 4ed74939-427d-455d-852a-df3499c9dbb2@group-284D2F681BFD-LeaderElection1 got
> exception when requesting votes: {}java.util.concurrent.ExecutionException:
> org.apache.ratis.thirdparty.io.grpc.StatusRuntimeException:
> DEADLINE_EXCEEDED: deadline exceeded after 2998885738ns at
> java.util.concurrent.FutureTask.report(FutureTask.java:122) at
> java.util.concurrent.FutureTask.get(FutureTask.java:192) at
> org.apache.ratis.server.impl.LeaderElection.waitForResults(LeaderElection.java:259)
> at
> org.apache.ratis.server.impl.LeaderElection.askForVotes(LeaderElection.java:197)
> at org.apache.ratis.server.impl.LeaderElection.run(LeaderElection.java:133)
> at java.lang.Thread.run(Thread.java:748)Caused by:
> org.apache.ratis.thirdparty.io.grpc.StatusRuntimeException:
> DEADLINE_EXCEEDED: deadline exceeded after 2998885738ns at
> org.apache.ratis.thirdparty.io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:233)
> at
> org.apache.ratis.thirdparty.io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:214)
> at
> org.apache.ratis.thirdparty.io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:139)
> at
> org.apache.ratis.proto.grpc.RaftServerProtocolServiceGrpc$RaftServerProtocolServiceBlockingStub.requestVote(RaftServerProtocolServiceGrpc.java:265)
> at
> org.apache.ratis.grpc.server.GrpcServerProtocolClient.requestVote(GrpcServerProtocolClient.java:99)
> at
> org.apache.ratis.grpc.server.GrpcService.requestVote(GrpcService.java:204) at
> org.apache.ratis.server.impl.LeaderElection.lambda$submitRequests$1(LeaderElection.java:234)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at
> java.util.concurrent.FutureTask.run(FutureTask.java:266) at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
>
[jira] [Commented] (RATIS-457) Timed out append entry reply should update follower match index, commit index
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957602#comment-16957602 ] Lokesh Jain commented on RATIS-457: --- v3 patch fixes unit test failures. > Timed out append entry reply should update follower match index, commit index > - > > Key: RATIS-457 > URL: https://issues.apache.org/jira/browse/RATIS-457 > Project: Ratis > Issue Type: Bug >Reporter: Lokesh Jain >Assignee: Lokesh Jain >Priority: Major > Labels: ozone > Attachments: RATIS-457.001.patch, RATIS-457.002.patch, > RATIS-457.003.patch > > > Currently all the timed out append entry replies are ignored by the leader. > These replies have information like match index which can be updated by > leader. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RATIS-457) Timed out append entry reply should update follower match index, commit index
[ https://issues.apache.org/jira/browse/RATIS-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Jain updated RATIS-457: -- Attachment: RATIS-457.003.patch > Timed out append entry reply should update follower match index, commit index > - > > Key: RATIS-457 > URL: https://issues.apache.org/jira/browse/RATIS-457 > Project: Ratis > Issue Type: Bug >Reporter: Lokesh Jain >Assignee: Lokesh Jain >Priority: Major > Labels: ozone > Attachments: RATIS-457.001.patch, RATIS-457.002.patch, > RATIS-457.003.patch > > > Currently all the timed out append entry replies are ignored by the leader. > These replies have information like match index which can be updated by > leader. -- This message was sent by Atlassian Jira (v8.3.4#803005)
