[jira] [Commented] (RATIS-160) Retry cache should handle leader change after log commit

2018-01-16 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328295#comment-16328295 ] Jing Zhao commented on RATIS-160: - The patch looks good to me. The only minor comment is that it may be

[jira] [Commented] (RATIS-140) Raft client should reuse the gRPC stream for all async calls

2017-12-27 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304859#comment-16304859 ] Jing Zhao commented on RATIS-140: - Looks like the failed test is unrelated. Could you please confirm it?

[jira] [Commented] (RATIS-140) Raft client should reuse the gRPC stream for all async calls

2017-12-18 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296311#comment-16296311 ] Jing Zhao commented on RATIS-140: - Some comments so far (after discussion with Nicholas offline): # Maybe

[jira] [Commented] (RATIS-140) Raft client should reuse the gRPC stream for all async calls

2017-12-12 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288768#comment-16288768 ] Jing Zhao commented on RATIS-140: - Thanks for updating the patch, Nicholas! I will post comments these

[jira] [Commented] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285515#comment-16285515 ] Jing Zhao commented on RATIS-160: - bq. Actually the bug occurs when new leader creates a new log entry

[jira] [Commented] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285491#comment-16285491 ] Jing Zhao commented on RATIS-160: - bq. The exception is raised by follower when they see a completed cache

[jira] [Comment Edited] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285467#comment-16285467 ] Jing Zhao edited comment on RATIS-160 at 12/11/17 3:11 AM: --- The reason I do not

[jira] [Commented] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-09 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284973#comment-16284973 ] Jing Zhao commented on RATIS-160: - Thanks a lot Lokesh! I've downloaded the log and will dig into the issue

[jira] [Commented] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-07 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283117#comment-16283117 ] Jing Zhao commented on RATIS-160: - Thanks again for reporting the issue, Lokesh. bq. This occurs when

[jira] [Commented] (RATIS-160) Retry cache should handle leader change after log commit

2017-12-06 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281259#comment-16281259 ] Jing Zhao commented on RATIS-160: - Thanks for working on this, [~ljain]. I will review your patch

[jira] [Commented] (RATIS-140) Server may see out-of-order gRPC messages sent from the same client

2017-12-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278052#comment-16278052 ] Jing Zhao commented on RATIS-140: - Thanks a lot, Nicholas! For gRpc, my feeling is we have duplicated

[jira] [Commented] (RATIS-6) Project logo

2017-11-20 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259787#comment-16259787 ] Jing Zhao commented on RATIS-6: --- +1 on logo-finalist.png > Project logo > > >

[jira] [Assigned] (RATIS-149) TestRaftStream.testSimpleWrite may fail

2017-11-20 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao reassigned RATIS-149: --- Assignee: Jing Zhao > TestRaftStream.testSimpleWrite may fail >

[jira] [Resolved] (RATIS-142) Test ArithmeticStateMachine with the Gauss–Legendre algorithm

2017-11-17 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-142. - Resolution: Fixed Fix Version/s: 0.2.0-alpha I've committed the patch. Thanks Nicholas! > Test

[jira] [Commented] (RATIS-141) In RaftClientProtocolService, the assumption of consecutive callId is invalid

2017-11-13 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250460#comment-16250460 ] Jing Zhao commented on RATIS-141: - Yeah, sounds good to me. In the meanwhile, let me check why we made this

[jira] [Commented] (RATIS-133) Raft gRPC client should check proto size before sending a message

2017-11-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248283#comment-16248283 ] Jing Zhao commented on RATIS-133: - [~msingh], I see your point. Thanks for the explanation. That makes

[jira] [Commented] (RATIS-117) Add test for situation when old leader can/cannot commit log

2017-11-09 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246390#comment-16246390 ] Jing Zhao commented on RATIS-117: - Looks like the Jenkins failure is unrelated. All the tests passed in my

[jira] [Commented] (RATIS-139) RaftLogWorker should use two task queues.

2017-11-08 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245077#comment-16245077 ] Jing Zhao commented on RATIS-139: - I think there're two problems here: # when-to-sync: this is the same

[jira] [Commented] (RATIS-139) RaftLogWorker should use two task queues.

2017-11-08 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244933#comment-16244933 ] Jing Zhao commented on RATIS-139: - [~jnp], have you seen a performance penalty with the current

[jira] [Assigned] (RATIS-139) RaftLogWorker should use two task queues.

2017-11-08 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao reassigned RATIS-139: --- Assignee: Jing Zhao > RaftLogWorker should use two task queues. >

[jira] [Commented] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent

2017-11-08 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244522#comment-16244522 ] Jing Zhao commented on RATIS-77: It's because if the incoming request is a stream, we expect response for

[jira] [Commented] (RATIS-117) Add test for situation when old leader can/cannot commit log

2017-11-08 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244489#comment-16244489 ] Jing Zhao commented on RATIS-117: - The latest patch looks pretty good to me. Just some minors: # Let's use

[jira] [Commented] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent

2017-11-07 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242810#comment-16242810 ] Jing Zhao commented on RATIS-77: I think the original comment is correct, and we should change the protobuf

[jira] [Assigned] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent

2017-11-07 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao reassigned RATIS-77: -- Assignee: (was: Jing Zhao) > "RaftServerProtocolService" and " GRpc.proto" inconsistent >

[jira] [Commented] (RATIS-129) Compile protobuf and shade if the shaded source directory is missing

2017-11-03 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238584#comment-16238584 ] Jing Zhao commented on RATIS-129: - +1 > Compile protobuf and shade if the shaded source directory is

[jira] [Commented] (RATIS-117) Add test for situation when old leader can/cannot commit log

2017-11-03 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238581#comment-16238581 ] Jing Zhao commented on RATIS-117: - Looks like TestRaftWithSimulatedRpc fails consistently. Will do some

[jira] [Commented] (RATIS-102) Clean generated sources as part of the default clean lifecycle

2017-11-03 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238472#comment-16238472 ] Jing Zhao commented on RATIS-102: - Looks like with ratis-102, if I run "mvn package -DskipTests" and then

[jira] [Resolved] (RATIS-128) Missing maven plugin version for protobuf and shade plugins

2017-11-03 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-128. - Resolution: Fixed Fix Version/s: 0.2.0-alpha I've committed the patch. Thanks for the fix,

[jira] [Commented] (RATIS-128) Missing maven plugin version for protobuf and shade plugins

2017-11-03 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238447#comment-16238447 ] Jing Zhao commented on RATIS-128: - +1. I will commit the patch shortly. > Missing maven plugin version for

[jira] [Commented] (RATIS-121) In RaftServer.Builder, allow serverId and group to be initialized automatically

2017-10-25 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219705#comment-16219705 ] Jing Zhao commented on RATIS-121: - bq. This patch just sets the default to host:port hmm, I guess I missed

[jira] [Commented] (RATIS-121) In RaftServer.Builder, allow serverId and group to be initialized automatically

2017-10-25 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219633#comment-16219633 ] Jing Zhao commented on RATIS-121: - bq. I found that we don't really need unique raft server IDs since we

[jira] [Commented] (RATIS-119) RaftServerImpl.registerMBean may throw MalformedObjectNameException

2017-10-24 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217677#comment-16217677 ] Jing Zhao commented on RATIS-119: - +1 > RaftServerImpl.registerMBean may throw

[jira] [Commented] (RATIS-121) In RaftServer.Builder, allow serverId and group to be initialized automatically

2017-10-24 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217670#comment-16217670 ] Jing Zhao commented on RATIS-121: - If the serverId is not specified directly, I think the application (that

[jira] [Commented] (RATIS-120) In RaftClient.Builder, allow clientRpc to be initialized automatically

2017-10-24 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217400#comment-16217400 ] Jing Zhao commented on RATIS-120: - +1 > In RaftClient.Builder, allow clientRpc to be initialized

[jira] [Commented] (RATIS-119) RaftServerImpl.registerMBean may throw MalformedObjectNameException

2017-10-24 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217384#comment-16217384 ] Jing Zhao commented on RATIS-119: - The patch looks great to me. Some minors: # # For {{public synchronized

[jira] [Commented] (RATIS-117) Add test for situation when old leader can/cannot commit log

2017-10-03 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189485#comment-16189485 ] Jing Zhao commented on RATIS-117: - Thanks for adding the new tests, [~yubox]! The patch looks good to me

[jira] [Commented] (RATIS-116) In PendingRequests, the requests are never removed from the map

2017-09-28 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183818#comment-16183818 ] Jing Zhao commented on RATIS-116: - +1 > In PendingRequests, the requests are never removed from the map >

[jira] [Commented] (RATIS-118) Add missing license headers for the ServerInformation feature

2017-09-28 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183814#comment-16183814 ] Jing Zhao commented on RATIS-118: - +1 > Add missing license headers for the ServerInformation feature >

[jira] [Commented] (RATIS-107) Restrict reinitialize to be from/to an empty group

2017-09-14 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167159#comment-16167159 ] Jing Zhao commented on RATIS-107: - I think one state machine managing all the storage containers can be the

[jira] [Commented] (RATIS-114) TestRaftWithHadoopRpc.testWithLoad may timeout

2017-09-06 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156482#comment-16156482 ] Jing Zhao commented on RATIS-114: - Is this because the retry policy of the hadoop rpc client? >

[jira] [Commented] (RATIS-111) RaftLogWorker may throw IllegalStateException

2017-09-06 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156481#comment-16156481 ] Jing Zhao commented on RATIS-111: - Yes the change of the patch is good. We can commit it first and fix the

[jira] [Commented] (RATIS-107) Restrict reinitialize to be from/to an empty group

2017-09-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152997#comment-16152997 ] Jing Zhao commented on RATIS-107: - Thanks for working on this, Nicholas. Here I think we may want to change

[jira] [Commented] (RATIS-102) Clean generated sources as part of the default clean lifecycle

2017-09-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152995#comment-16152995 ] Jing Zhao commented on RATIS-102: - The patch looks good to me. +1 Do you also want to take a look at the

[jira] [Updated] (RATIS-111) RaftLogWorker may throw IllegalStateException

2017-09-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-111: Attachment: org.apache.ratis.hadooprpc.TestRaftWithHadoopRpc-output.txt Upload the log file. Looks like in

[jira] [Comment Edited] (RATIS-111) RaftLogWorker may throw IllegalStateException

2017-09-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152965#comment-16152965 ] Jing Zhao edited comment on RATIS-111 at 9/4/17 10:34 PM: -- Thanks for the fix,

[jira] [Commented] (RATIS-111) RaftLogWorker may throw IllegalStateException

2017-09-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152965#comment-16152965 ] Jing Zhao commented on RATIS-111: - Thanks for the fix, Nicholas! The patch looks good to me. But

[jira] [Commented] (RATIS-105) Server should check group id for client requests

2017-09-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152961#comment-16152961 ] Jing Zhao commented on RATIS-105: - The patch looks good to me, except we need to rename the java files of

[jira] [Commented] (RATIS-100) Fix bugs for running multiple raft groups with a state machine

2017-09-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152945#comment-16152945 ] Jing Zhao commented on RATIS-100: - The patch needs a minor fix to compile: {code} diff --git

[jira] [Issue Comment Deleted] (RATIS-105) Server should check group id for client requests

2017-09-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-105: Comment: was deleted (was: I've committed the patch. Thanks Nicholas for the contribution!) > Server should

[jira] [Issue Comment Deleted] (RATIS-105) Server should check group id for client requests

2017-09-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-105: Comment: was deleted (was: The patch needs a minor fix to compile: {code} diff --git

[jira] [Resolved] (RATIS-105) Server should check group id for client requests

2017-09-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-105. - Resolution: Fixed Fix Version/s: 0.2.0-alpha I've committed the patch. Thanks Nicholas for the

[jira] [Commented] (RATIS-100) Fix bugs for running multiple raft groups with a state machine

2017-09-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152936#comment-16152936 ] Jing Zhao commented on RATIS-100: - +1. I will commit the patch shortly, > Fix bugs for running multiple

[jira] [Resolved] (RATIS-97) Leader may not have majority after setConfiguration

2017-08-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-97. Resolution: Fixed Fix Version/s: 0.2.0-alpha I've committed the patch. Thanks Nicholas! > Leader may

[jira] [Commented] (RATIS-97) Leader may not have majority after setConfiguration

2017-08-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122880#comment-16122880 ] Jing Zhao commented on RATIS-97: +1. I will commit the patch shortly. > Leader may not have majority after

[jira] [Resolved] (RATIS-94) Expose basic information over JMX

2017-08-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-94?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-94. Resolution: Fixed Fix Version/s: 0.2.0-alpha I've committed the patch. Thanks for the contribution,

[jira] [Commented] (RATIS-94) Expose basic information over JMX

2017-08-07 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116931#comment-16116931 ] Jing Zhao commented on RATIS-94: Besides, you may need to rebase the patch... Thanks. > Expose basic

[jira] [Commented] (RATIS-94) Expose basic information over JMX

2017-08-07 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116927#comment-16116927 ] Jing Zhao commented on RATIS-94: Yes RaftPeer may be better. BTW, {code} 972 .map(leaderState1

[jira] [Commented] (RATIS-97) Leader may not have majority after setConfiguration

2017-08-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114062#comment-16114062 ] Jing Zhao commented on RATIS-97: Thanks for the patch, Nicholas! Looks like we may have two scenarios here:

[jira] [Resolved] (RATIS-96) LeaderState computeLastCommitted may throw ArrayIndexOutOfBoundsException

2017-08-01 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-96. Resolution: Fixed Fix Version/s: 0.2.0-alpha I've committed the patch. Thanks for the fix, Nicholas!

[jira] [Commented] (RATIS-96) LeaderState computeLastCommitted may throw ArrayIndexOutOfBoundsException

2017-07-31 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108401#comment-16108401 ] Jing Zhao commented on RATIS-96: +1. I will commit the patch shortly. > LeaderState computeLastCommitted

[jira] [Resolved] (RATIS-99) Exclude shaded sources from the checkstyle check

2017-07-28 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-99. Resolution: Fixed Fix Version/s: 0.2.0-alpha I've committed the patch. Thanks for the contribution,

[jira] [Commented] (RATIS-97) Leader may not have majority after setConfiguration

2017-07-28 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105563#comment-16105563 ] Jing Zhao commented on RATIS-97: bq. Currently, we just start new servers with one configuration. I guess

[jira] [Commented] (RATIS-97) Leader may not have majority after setConfiguration

2017-07-27 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104207#comment-16104207 ] Jing Zhao commented on RATIS-97: Not sure whether this can happen. According to the protocol, during

[jira] [Commented] (RATIS-96) LeaderState computeLastCommitted may throw ArrayIndexOutOfBoundsException

2017-07-27 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104178#comment-16104178 ] Jing Zhao commented on RATIS-96: Uploaded the wrong patch? The latest patch is for ozone. > LeaderState

[jira] [Commented] (RATIS-96) LeaderState computeLastCommitted may throw ArrayIndexOutOfBoundsException

2017-07-20 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095671#comment-16095671 ] Jing Zhao commented on RATIS-96: Thanks for fixing the issue, Nicholas! So is it possible that we can do an

[jira] [Assigned] (RATIS-96) LeaderState computeLastCommitted may throw ArrayIndexOutOfBoundsException

2017-07-20 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao reassigned RATIS-96: -- Assignee: Tsz Wo Nicholas Sze > LeaderState computeLastCommitted may throw

[jira] [Commented] (RATIS-93) Filter peers from the iteration before random selection

2017-07-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082860#comment-16082860 ] Jing Zhao commented on RATIS-93: +1 > Filter peers from the iteration before random selection >

[jira] [Resolved] (RATIS-86) Support server re-initialization

2017-05-19 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-86. Resolution: Fixed Fix Version/s: 0.2.0-alpha > Support server re-initialization >

[jira] [Commented] (RATIS-86) Support server re-initialization

2017-05-19 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017778#comment-16017778 ] Jing Zhao commented on RATIS-86: +1. I will commit the patch shortly. Thanks Nicholas! > Support server

[jira] [Updated] (RATIS-85) TestNotLeaderExceptionWithHadoopRpc and TestRaftReconfigurationWithHadoopRpc fail intermittently

2017-05-12 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-85: --- Attachment: RATIS-85.000.patch Upload the first patch. > TestNotLeaderExceptionWithHadoopRpc and

[jira] [Commented] (RATIS-87) Separate RaftServerImpl into proxy and impl

2017-05-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005363#comment-16005363 ] Jing Zhao commented on RATIS-87: +1 > Separate RaftServerImpl into proxy and impl >

[jira] [Resolved] (RATIS-82) Add cache eviction policy

2017-05-10 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-82. Resolution: Fixed Fix Version/s: 0.2.0-alpha I've committed the patch. Thanks Nicholas for the review!

[jira] [Commented] (RATIS-11) Better retry policy support for Raft client

2017-05-05 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998836#comment-15998836 ] Jing Zhao commented on RATIS-11: [~jingc], sure! I've added you as Ratis contributor. > Better retry

[jira] [Updated] (RATIS-82) Add cache eviction policy

2017-05-04 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-82: --- Attachment: RATIS-82.001.patch Added some basic tests. > Add cache eviction policy > -

[jira] [Updated] (RATIS-85) TestNotLeaderExceptionWithHadoopRpc and TestRaftReconfigurationWithHadoopRpc fail intermittently

2017-05-03 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-85: --- Summary: TestNotLeaderExceptionWithHadoopRpc and TestRaftReconfigurationWithHadoopRpc fail intermittently

[jira] [Created] (RATIS-85) TestNotLeaderExceptionWithHadoopRpc and TestRaftReconfigurationWithHadoopRpc fail immediately

2017-05-03 Thread Jing Zhao (JIRA)
Jing Zhao created RATIS-85: -- Summary: TestNotLeaderExceptionWithHadoopRpc and TestRaftReconfigurationWithHadoopRpc fail immediately Key: RATIS-85 URL: https://issues.apache.org/jira/browse/RATIS-85 Project:

[jira] [Commented] (RATIS-65) Add a script to automate the release process

2017-04-28 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989474#comment-15989474 ] Jing Zhao commented on RATIS-65: I've tested the script in my local environment and it works. +1 > Add a

[jira] [Commented] (RATIS-63) Add NOTICE.txt

2017-04-28 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989457#comment-15989457 ] Jing Zhao commented on RATIS-63: +1 > Add NOTICE.txt > -- > > Key: RATIS-63 >

[jira] [Created] (RATIS-82) Add cache eviction policy

2017-04-28 Thread Jing Zhao (JIRA)
Jing Zhao created RATIS-82: -- Summary: Add cache eviction policy Key: RATIS-82 URL: https://issues.apache.org/jira/browse/RATIS-82 Project: Ratis Issue Type: Sub-task Reporter: Jing Zhao

[jira] [Resolved] (RATIS-76) Add loading policy for RaftLogCache

2017-04-26 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-76. Resolution: Fixed Fix Version/s: 0.1.0-alpha Thanks again for the review, Nicholas! I've committed the

[jira] [Commented] (RATIS-76) Add loading policy for RaftLogCache

2017-04-25 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983835#comment-15983835 ] Jing Zhao commented on RATIS-76: bq. Question: Is getEntryWithLoading intended to be only used in

[jira] [Updated] (RATIS-76) Add loading policy for RaftLogCache

2017-04-25 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-76: --- Attachment: RATIS-76.003.patch Thanks a lot for the review, Nicholas! Update the patch to address your

[jira] [Updated] (RATIS-78) Ratis does not compile in Intellij

2017-04-21 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-78: --- Attachment: RATIS-78.000.patch > Ratis does not compile in Intellij > -- > >

[jira] [Created] (RATIS-78) Ratis does not compile in Intellij

2017-04-21 Thread Jing Zhao (JIRA)
Jing Zhao created RATIS-78: -- Summary: Ratis does not compile in Intellij Key: RATIS-78 URL: https://issues.apache.org/jira/browse/RATIS-78 Project: Ratis Issue Type: Bug Reporter: Jing

[jira] [Updated] (RATIS-76) Add loading policy for RaftLogCache

2017-04-21 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-76: --- Attachment: RATIS-76.002.patch Update the patch with some simple tests. Also let the SegmentedRaftLog call

[jira] [Commented] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent

2017-04-21 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979219#comment-15979219 ] Jing Zhao commented on RATIS-77: Thank you for reporting the issue, [~kaiyangzhang]! Yeah, looks like we

[jira] [Updated] (RATIS-76) Add loading policy for RaftLogCache

2017-04-20 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-76: --- Attachment: RATIS-76.001.patch Added RaftLogIOException for Exception thrown while loading log entries from

[jira] [Resolved] (RATIS-70) Separate term/index/offset and log entry content in LogSegment

2017-04-17 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-70. Resolution: Fixed Fix Version/s: 0.1.0-alpha Thanks Nicholas for the review! I've committed the patch.

[jira] [Updated] (RATIS-76) Add loading policy for RaftLogCache

2017-04-13 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-76: --- Attachment: RATIS-76.000.patch Initial patch to demo the idea. The patch depends on RATIS-70. Will add more

[jira] [Created] (RATIS-76) Add loading policy for RaftLogCache

2017-04-13 Thread Jing Zhao (JIRA)
Jing Zhao created RATIS-76: -- Summary: Add loading policy for RaftLogCache Key: RATIS-76 URL: https://issues.apache.org/jira/browse/RATIS-76 Project: Ratis Issue Type: Sub-task Reporter:

[jira] [Updated] (RATIS-70) Separate term/index/offset and log entry content in LogSegment

2017-04-13 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-70: --- Attachment: RATIS-70.002.patch Thanks a lot for the review, Nicholas! Update the patch to address your

[jira] [Created] (RATIS-75) Document Ratis library usage

2017-04-13 Thread Jing Zhao (JIRA)
Jing Zhao created RATIS-75: -- Summary: Document Ratis library usage Key: RATIS-75 URL: https://issues.apache.org/jira/browse/RATIS-75 Project: Ratis Issue Type: Improvement Reporter:

[jira] [Assigned] (RATIS-74) Missing dependency for enforcer rule enforceBytecodeVersion

2017-04-13 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao reassigned RATIS-74: -- Assignee: Karl Heinz Marbaise > Missing dependency for enforcer rule enforceBytecodeVersion >

[jira] [Assigned] (RATIS-73) Update apache-rat-plugin to version 0.12

2017-04-13 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao reassigned RATIS-73: -- Assignee: Karl Heinz Marbaise > Update apache-rat-plugin to version 0.12 >

[jira] [Updated] (RATIS-70) Separate term/index/offset and log entry content in LogSegment

2017-04-11 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-70: --- Attachment: RATIS-70.000.patch Rebase the patch. > Separate term/index/offset and log entry content in

[jira] [Updated] (RATIS-70) Separate term/index/offset and log entry content in LogSegment

2017-04-06 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-70: --- Summary: Separate term/index/offset and log entry content in LogSegment (was: Code refactoring on

[jira] [Resolved] (RATIS-68) Simplify parent entries

2017-04-06 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-68. Resolution: Fixed +1. Thanks for the fix, [~khmarbaise]! > Simplify parent entries > ---

[jira] [Created] (RATIS-70) Code refactoring on RaftLogCache

2017-04-06 Thread Jing Zhao (JIRA)
Jing Zhao created RATIS-70: -- Summary: Code refactoring on RaftLogCache Key: RATIS-70 URL: https://issues.apache.org/jira/browse/RATIS-70 Project: Ratis Issue Type: Sub-task Reporter:

[jira] [Commented] (RATIS-64) Do not pre-shade artifacts

2017-04-03 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954027#comment-15954027 ] Jing Zhao commented on RATIS-64: Yes maybe we can use this chance to remove hadoop related code from the

[jira] [Resolved] (RATIS-62) Return the Exception from StateMachine#preAppendTransaction to client as StateMachineException

2017-03-31 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-62. Resolution: Fixed Fix Version/s: 0.1.0-alpha Thanks for the review, Mingliang! I've committed the

  1   2   >