[jira] [Updated] (RATIS-39) Avoid using google guava

2017-03-14 Thread Tsz Wo Nicholas Sze (JIRA)

 [ 
https://issues.apache.org/jira/browse/RATIS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo Nicholas Sze updated RATIS-39:
-
Summary: Avoid using google guava  (was: Avoid using google guava so that 
it is easier to shade)

> Avoid using google guava
> 
>
> Key: RATIS-39
> URL: https://issues.apache.org/jira/browse/RATIS-39
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r39_20170309.patch, r39_20170310.patch, 
> r39_20170314.patch
>
>
> In order to allow user application using google guava, we should either not 
> using it or shade it.
> Except for ratis-common, we can replace google guava by:
> - Preconditions: add similar methods in our util.  
> - VisibleForTesting: remove it.
> - ThreadFactoryBuilder: use Daemon::new
> - Charsets: use StandardCharsets
> - Lists, ImmutableList: use java collections
> - Throwables; just throw IOException



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (RATIS-39) Avoid using google guava so that it is easier to shade

2017-03-14 Thread Tsz Wo Nicholas Sze (JIRA)

 [ 
https://issues.apache.org/jira/browse/RATIS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo Nicholas Sze updated RATIS-39:
-
Attachment: r39_20170314.patch

Thanks Mingliang.  Here is a new patch addressing your comments.

r39_20170314.patch

> Avoid using google guava so that it is easier to shade
> --
>
> Key: RATIS-39
> URL: https://issues.apache.org/jira/browse/RATIS-39
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r39_20170309.patch, r39_20170310.patch, 
> r39_20170314.patch
>
>
> In order to allow user application using google guava, we should either not 
> using it or shade it.
> Except for ratis-common, we can replace google guava by:
> - Preconditions: add similar methods in our util.  
> - VisibleForTesting: remove it.
> - ThreadFactoryBuilder: use Daemon::new
> - Charsets: use StandardCharsets
> - Lists, ImmutableList: use java collections
> - Throwables; just throw IOException



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)