[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269707#comment-16269707
]
Chen Liang commented on RATIS-141:
--
+1 on v20171125b patch, I've committed the patch, thanks [~szetszwo]
[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264955#comment-16264955
]
Tsz Wo Nicholas Sze commented on RATIS-141:
---
[~vagarychen], looked at the code again and found
[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263441#comment-16263441
]
Tsz Wo Nicholas Sze commented on RATIS-141:
---
> And just making callIdCounter non-static would do
[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263369#comment-16263369
]
Chen Liang commented on RATIS-141:
--
Thanks [~szetszwo] for working on this! Had an offline discussion with
[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258728#comment-16258728
]
Tsz Wo Nicholas Sze commented on RATIS-141:
---
> It seems easier to reproduce the failure of
[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258715#comment-16258715
]
Tsz Wo Nicholas Sze commented on RATIS-141:
---
This is a different failed case
{code}
Running
[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258695#comment-16258695
]
Tsz Wo Nicholas Sze commented on RATIS-141:
---
TestRaftStream.testSimpleWrite may fail WITHOUT any
[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257899#comment-16257899
]
Tsz Wo Nicholas Sze commented on RATIS-141:
---
r141_20171117.patch: add streamSeqNum to
[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250460#comment-16250460
]
Jing Zhao commented on RATIS-141:
-
Yeah, sounds good to me. In the meanwhile, let me check why we made this
[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250022#comment-16250022
]
Tsz Wo Nicholas Sze commented on RATIS-141:
---
It actually is better to call it streamSeqNum. How
10 matches
Mail list logo