[jira] [Commented] (RATIS-17) Add basic retry cache implementation for Raft Server

2017-03-31 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950439#comment-15950439 ] Jing Zhao commented on RATIS-17: Thanks for the review, Nicholas! Since RATIS-52 got reopened, I will commit

[jira] [Commented] (RATIS-17) Add basic retry cache implementation for Raft Server

2017-03-31 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950372#comment-15950372 ] Tsz Wo Nicholas Sze commented on RATIS-17: -- +1 the 006 patch looks good. Please update it with

[jira] [Commented] (RATIS-17) Add basic retry cache implementation for Raft Server

2017-03-30 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949686#comment-15949686 ] Jing Zhao commented on RATIS-17: Thanks for the comments, Nicholas. bq. For #2, should we just return the

[jira] [Commented] (RATIS-17) Add basic retry cache implementation for Raft Server

2017-03-27 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944136#comment-15944136 ] Jing Zhao commented on RATIS-17: Just realized that the {{queryCache}} still has a race condition. Will

[jira] [Commented] (RATIS-17) Add basic retry cache implementation for Raft Server

2017-03-24 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941395#comment-15941395 ] Jing Zhao commented on RATIS-17: bq. The guava Cache is thread safe. Do we need to synchronize queryCache

[jira] [Commented] (RATIS-17) Add basic retry cache implementation for Raft Server

2017-03-22 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937491#comment-15937491 ] Tsz Wo Nicholas Sze commented on RATIS-17: -- Thanks Jing, some quick comments: - CacheKey is created