[
https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950439#comment-15950439
]
Jing Zhao commented on RATIS-17:
Thanks for the review, Nicholas! Since RATIS-52 got reopened, I will commit
[
https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950372#comment-15950372
]
Tsz Wo Nicholas Sze commented on RATIS-17:
--
+1 the 006 patch looks good. Please update it with
[
https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949686#comment-15949686
]
Jing Zhao commented on RATIS-17:
Thanks for the comments, Nicholas.
bq. For #2, should we just return the
[
https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944136#comment-15944136
]
Jing Zhao commented on RATIS-17:
Just realized that the {{queryCache}} still has a race condition. Will
[
https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941395#comment-15941395
]
Jing Zhao commented on RATIS-17:
bq. The guava Cache is thread safe. Do we need to synchronize queryCache
[
https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937491#comment-15937491
]
Tsz Wo Nicholas Sze commented on RATIS-17:
--
Thanks Jing, some quick comments:
- CacheKey is created