[
https://issues.apache.org/jira/browse/RATIS-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893015#comment-15893015
]
Tsz Wo Nicholas Sze commented on RATIS-33:
------------------------------------------
Thanks for working on this. Tried the patch. It is working fine.
- Let's add -DskipTests and quote it by ``` for the command below.
{code}
run with
-$ mvn install -Dcompile-protobuf
+$ mvn package -Dcompile-protobuf
{code}
- It seems that there is no mvn command to remove the shaded source. We
probably should add a new mvn target. We may do it separately.
> Protobuf gets compiled only when both activation conditions are triggered
> -------------------------------------------------------------------------
>
> Key: RATIS-33
> URL: https://issues.apache.org/jira/browse/RATIS-33
> Project: Ratis
> Issue Type: Bug
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: RATIS-33.000.patch, RATIS-33.001.patch,
> RATIS-33.002.patch
>
>
> In RATIS-26 we specify the following activation conditions for compiling
> protobuf files:
> {code}
> <activation>
> <!-- Activate this if the generated source directory is missing. It
> will automatically
> kick the protoc compilation if you are doing a mvn install for the
> first time. Otherwise
> it will only compile the resources under src/main/java as usual. If
> you want to
> force-compile the proto files (for example after changing them), you
> should run with
> mvn install -Dcompile-protobuf -->
> <file>
> <missing>${sources.dir}</missing>
> </file>
> <property>
> <name>compile-protobuf</name>
> </property>
> </activation>
> {code}
> This does not work after maven version 3.2.2, due to MNG-4565 that changes
> the activation condition relationships from OR to AND. Thus we have to do
> both 1) delete ratis-proto-shaded/src/main/java, and 2) include
> -Dcompile-protobuf in the command to trigger the protobuf compilation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
