[jira] [Commented] (RATIS-694) Fix checkstyle violations in ratis-metrics
[
https://issues.apache.org/jira/browse/RATIS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958996#comment-16958996
]
Dinesh Chitlangia commented on RATIS-694:
-
Thanks [~szetszwo] for review & commit.
> Fix checkstyle violations in ratis-metrics
> --
>
> Key: RATIS-694
> URL: https://issues.apache.org/jira/browse/RATIS-694
> Project: Ratis
> Issue Type: Sub-task
> Components: metrics
>Reporter: Dinesh Chitlangia
>Assignee: Dinesh Chitlangia
>Priority: Minor
> Fix For: 0.5.0
>
> Attachments: RATIS-694.001.patch
>
>
> Checkstyle found 78 item(s) in 30 file(s)
> BaseStateMachine.java : 5 item(s)
> Variable 'server' must be private and have accessor methods. (49:49)
> [VisibilityModifierCheck]
> Variable 'groupId' must be private and have accessor methods. (50:34)
> [VisibilityModifierCheck]
> Variable 'lifeCycle' must be private and have accessor methods. (51:29)
> [VisibilityModifierCheck]
> 'server' hides a field. (67:37) [HiddenFieldCheck]
> 'groupId' hides a field. (67:57) [HiddenFieldCheck]
> BufferedChannelBase.java : 1 item(s)
> Variable 'fileChannel' must be private and have accessor methods. (25:31)
> [VisibilityModifierCheck]
> LeaderElection.java : 3 item(s)
> Variable 'result' must be private and have accessor methods. (70:18)
> [VisibilityModifierCheck]
> Variable 'term' must be private and have accessor methods. (71:16)
> [VisibilityModifierCheck]
> switch without "default" clause. (208:0) [MissingSwitchDefaultCheck]
> LeaderState.java : 9 item(s)
> Variable 'type' must be private and have accessor methods. (70:16)
> [VisibilityModifierCheck]
> Variable 'newTerm' must be private and have accessor methods. (71:16)
> [VisibilityModifierCheck]
> Variable 'handler' must be private and have accessor methods. (72:20)
> [VisibilityModifierCheck]
> Definition of 'equals()' without corresponding definition of 'hashCode()'.
> (84:5) [EqualsHashCodeCheck]
> 'for' construct must use '{}'s. (129:0) [NeedBracesCheck]
> Empty statement. (129:52) [EmptyStatementCheck]
> Name 'UPDATE_COMMIT_EVENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. (178:34)
> [MemberNameCheck]
> Name 'CHECK_STAGING_EVENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. (180:34)
> [MemberNameCheck]
> 'stagingState' hides a field. (296:31) [HiddenFieldCheck]
> LogAppender.java : 5 item(s)
> Variable 'server' must be private and have accessor methods. (122:34)
> [VisibilityModifierCheck]
> Variable 'raftLog' must be private and have accessor methods. (124:27)
> [VisibilityModifierCheck]
> Variable 'follower' must be private and have accessor methods. (125:32)
> [VisibilityModifierCheck]
> Variable 'halfMinTimeoutMs' must be private and have accessor methods.
> (129:24) [VisibilityModifierCheck]
> switch without "default" clause. (483:0) [MissingSwitchDefaultCheck]
> LogSegment.java : 1 item(s)
> Class LogSegment should be declared as final. (53:0) [FinalClassCheck]
> MemoryRaftLog.java : 1 item(s)
> 'entries' hides a field. (161:68) [HiddenFieldCheck]
> MetaFile.java : 2 item(s)
> 'term' hides a field. (88:23) [HiddenFieldCheck]
> 'votedFor' hides a field. (88:36) [HiddenFieldCheck]
> PendingRequests.java : 2 item(s)
> Line is longer than 120 characters (found 123). (112:0) [LineLengthCheck]
> Line is longer than 120 characters (found 122). (201:0) [LineLengthCheck]
> RaftConfiguration.java : 2 item(s)
> Class RaftConfiguration should be declared as final. (36:0) [FinalClassCheck]
> Class Builder should be declared as final. (43:0) [FinalClassCheck]
> RaftLog.java : 1 item(s)
> Line is longer than 120 characters (found 131). (321:0) [LineLengthCheck]
> RaftServer.java : 1 item(s)
> Line is longer than 120 characters (found 128). (79:0) [LineLengthCheck]
> RaftServerConstants.java : 1 item(s)
> interfaces should describe a type and hence have methods. (22:0)
> [InterfaceIsTypeCheck]
> RaftServerImpl.java : 5 item(s)
> Line is longer than 120 characters (found 136). (82:0) [LineLengthCheck]
> 'state' hides a field. (124:19) [HiddenFieldCheck]
> 'stateMachine' hides a field. (545:24) [HiddenFieldCheck]
> More than 7 parameters (found 8). (885:54) [ParameterNumberCheck]
> 'stateMachine' hides a field. (1,250:24) [HiddenFieldCheck]
> RaftServerProxy.java : 2 item(s)
> Name '_1' must match pattern '^[a-z][a-zA-Z0-9]*$'. (385:24)
> [ParameterNameCheck]
> Line is longer than 120 characters (found 123). (397:0) [LineLengthCheck]
> RaftServerRpc.java : 1 item(s)
> 'server' hides a field. (45:35) [HiddenFieldCheck]
> RaftStorage.java : 1 item(s)
> 'metaFile' hides a field. (89:14) [HiddenFieldCheck]
> RaftStorageDirectory.java : 3 item(s)
> Variable 'startIndex' must be private and have accessor methods. (66:23)
> [VisibilityModifierCheck]
> Variable 'endIndex' must be private and have accessor
[jira] [Commented] (RATIS-694) Fix checkstyle violations in ratis-metrics
[
https://issues.apache.org/jira/browse/RATIS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958992#comment-16958992
]
Tsz-wo Sze commented on RATIS-694:
--
+1 patch looks good.
> Fix checkstyle violations in ratis-metrics
> --
>
> Key: RATIS-694
> URL: https://issues.apache.org/jira/browse/RATIS-694
> Project: Ratis
> Issue Type: Sub-task
>Reporter: Dinesh Chitlangia
>Assignee: Dinesh Chitlangia
>Priority: Minor
> Attachments: RATIS-694.001.patch
>
>
> Checkstyle found 78 item(s) in 30 file(s)
> BaseStateMachine.java : 5 item(s)
> Variable 'server' must be private and have accessor methods. (49:49)
> [VisibilityModifierCheck]
> Variable 'groupId' must be private and have accessor methods. (50:34)
> [VisibilityModifierCheck]
> Variable 'lifeCycle' must be private and have accessor methods. (51:29)
> [VisibilityModifierCheck]
> 'server' hides a field. (67:37) [HiddenFieldCheck]
> 'groupId' hides a field. (67:57) [HiddenFieldCheck]
> BufferedChannelBase.java : 1 item(s)
> Variable 'fileChannel' must be private and have accessor methods. (25:31)
> [VisibilityModifierCheck]
> LeaderElection.java : 3 item(s)
> Variable 'result' must be private and have accessor methods. (70:18)
> [VisibilityModifierCheck]
> Variable 'term' must be private and have accessor methods. (71:16)
> [VisibilityModifierCheck]
> switch without "default" clause. (208:0) [MissingSwitchDefaultCheck]
> LeaderState.java : 9 item(s)
> Variable 'type' must be private and have accessor methods. (70:16)
> [VisibilityModifierCheck]
> Variable 'newTerm' must be private and have accessor methods. (71:16)
> [VisibilityModifierCheck]
> Variable 'handler' must be private and have accessor methods. (72:20)
> [VisibilityModifierCheck]
> Definition of 'equals()' without corresponding definition of 'hashCode()'.
> (84:5) [EqualsHashCodeCheck]
> 'for' construct must use '{}'s. (129:0) [NeedBracesCheck]
> Empty statement. (129:52) [EmptyStatementCheck]
> Name 'UPDATE_COMMIT_EVENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. (178:34)
> [MemberNameCheck]
> Name 'CHECK_STAGING_EVENT' must match pattern '^[a-z][a-zA-Z0-9]*$'. (180:34)
> [MemberNameCheck]
> 'stagingState' hides a field. (296:31) [HiddenFieldCheck]
> LogAppender.java : 5 item(s)
> Variable 'server' must be private and have accessor methods. (122:34)
> [VisibilityModifierCheck]
> Variable 'raftLog' must be private and have accessor methods. (124:27)
> [VisibilityModifierCheck]
> Variable 'follower' must be private and have accessor methods. (125:32)
> [VisibilityModifierCheck]
> Variable 'halfMinTimeoutMs' must be private and have accessor methods.
> (129:24) [VisibilityModifierCheck]
> switch without "default" clause. (483:0) [MissingSwitchDefaultCheck]
> LogSegment.java : 1 item(s)
> Class LogSegment should be declared as final. (53:0) [FinalClassCheck]
> MemoryRaftLog.java : 1 item(s)
> 'entries' hides a field. (161:68) [HiddenFieldCheck]
> MetaFile.java : 2 item(s)
> 'term' hides a field. (88:23) [HiddenFieldCheck]
> 'votedFor' hides a field. (88:36) [HiddenFieldCheck]
> PendingRequests.java : 2 item(s)
> Line is longer than 120 characters (found 123). (112:0) [LineLengthCheck]
> Line is longer than 120 characters (found 122). (201:0) [LineLengthCheck]
> RaftConfiguration.java : 2 item(s)
> Class RaftConfiguration should be declared as final. (36:0) [FinalClassCheck]
> Class Builder should be declared as final. (43:0) [FinalClassCheck]
> RaftLog.java : 1 item(s)
> Line is longer than 120 characters (found 131). (321:0) [LineLengthCheck]
> RaftServer.java : 1 item(s)
> Line is longer than 120 characters (found 128). (79:0) [LineLengthCheck]
> RaftServerConstants.java : 1 item(s)
> interfaces should describe a type and hence have methods. (22:0)
> [InterfaceIsTypeCheck]
> RaftServerImpl.java : 5 item(s)
> Line is longer than 120 characters (found 136). (82:0) [LineLengthCheck]
> 'state' hides a field. (124:19) [HiddenFieldCheck]
> 'stateMachine' hides a field. (545:24) [HiddenFieldCheck]
> More than 7 parameters (found 8). (885:54) [ParameterNumberCheck]
> 'stateMachine' hides a field. (1,250:24) [HiddenFieldCheck]
> RaftServerProxy.java : 2 item(s)
> Name '_1' must match pattern '^[a-z][a-zA-Z0-9]*$'. (385:24)
> [ParameterNameCheck]
> Line is longer than 120 characters (found 123). (397:0) [LineLengthCheck]
> RaftServerRpc.java : 1 item(s)
> 'server' hides a field. (45:35) [HiddenFieldCheck]
> RaftStorage.java : 1 item(s)
> 'metaFile' hides a field. (89:14) [HiddenFieldCheck]
> RaftStorageDirectory.java : 3 item(s)
> Variable 'startIndex' must be private and have accessor methods. (66:23)
> [VisibilityModifierCheck]
> Variable 'endIndex' must be private and have accessor methods. (67:23)
> [VisibilityModifierCheck]
> 'if' construct must use '{}'s. (355:0)
[jira] [Commented] (RATIS-694) Fix checkstyle violations in ratis-metrics
[
https://issues.apache.org/jira/browse/RATIS-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958476#comment-16958476
]
Hadoop QA commented on RATIS-694:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} root: The patch generated 0 new + 0 unchanged - 7
fixed = 0 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 2s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 49s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestRaftAsyncExceptionWithGrpc |
| | ratis.grpc.TestRaftOutputStreamWithGrpc |
| | ratis.grpc.TestRaftReconfigurationWithGrpc |
| | ratis.grpc.TestRaftServerWithGrpc |
| | ratis.netty.TestRaftReconfigurationWithNetty |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.netty.TestRaftWithNetty |
| | ratis.grpc.TestLeaderElectionWithGrpc |
| | ratis.examples.filestore.TestFileStoreAsyncWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 Image:yetus/ratis:date2019-10-24 |
| JIRA Issue | RATIS-694 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12983881/RATIS-694.001.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux a484a7611cd8 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 55cbfbb |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1104/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1104/testReport/ |
| Max. process+thread count | 1155 (vs. ulimit of 5000) |
| modules | C: ratis-metrics U: ratis-metrics |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1104/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Fix checkstyle violations in ratis-metrics
> --
>
> Key: RATIS-694
> URL:
