[jira] [Created] (ROCKETMQ-255) Offset store is null after consumer clients start()

[Zhanhui Li (JIRA)]

Zhanhui Li created ROCKETMQ-255:
---

 Summary: Offset store is null after consumer clients start()
 Key: ROCKETMQ-255
 URL: https://issues.apache.org/jira/browse/ROCKETMQ-255
 Project: Apache RocketMQ
  Issue Type: Bug
  Components: rocketmq-client
Affects Versions: 4.1.0-incubating
Reporter: Zhanhui Li
Assignee: Zhanhui Li






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-44) Duplicated codes in DefaultMessageStore.getEarliestMessageTime and DefaultMessageStore.getMessageStoreTimeStamp

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116239#comment-16116239
 ] 

ASF GitHub Bot commented on ROCKETMQ-44:


Github user Ritabrata-TW commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/134
  
@vsair The Travis build seems to have passed. Did you notice something 
wrong with the code style ? 



> Duplicated codes in DefaultMessageStore.getEarliestMessageTime and 
> DefaultMessageStore.getMessageStoreTimeStamp
> ---
>
> Key: ROCKETMQ-44
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-44
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Wu Sheng
>Assignee: vongosling
>Priority: Minor
> Fix For: 4.2.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116142#comment-16116142
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  
LGTM


> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-256) Manually clean disk to specified watermark with message consuming progress considered

[Zhanhui Li (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116243#comment-16116243
 ] 

Zhanhui Li commented on ROCKETMQ-256:
-

Users may want to clean commit log files to have more free disk space. 

> Manually clean disk to specified watermark with message consuming progress 
> considered
> -
>
> Key: ROCKETMQ-256
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-256
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-broker, rocketmq-store, rocketmq-tools
>Affects Versions: 4.1.0-incubating
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-44) Duplicated codes in DefaultMessageStore.getEarliestMessageTime and DefaultMessageStore.getMessageStoreTimeStamp

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116240#comment-16116240
 ] 

ASF GitHub Bot commented on ROCKETMQ-44:


Github user Ritabrata-TW commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/134
  
@zhouxinyu My pleasure. I have set the merge target to develop. Thanks. 


> Duplicated codes in DefaultMessageStore.getEarliestMessageTime and 
> DefaultMessageStore.getMessageStoreTimeStamp
> ---
>
> Key: ROCKETMQ-44
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-44
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Wu Sheng
>Assignee: vongosling
>Priority: Minor
> Fix For: 4.2.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-44) Duplicated codes in DefaultMessageStore.getEarliestMessageTime and DefaultMessageStore.getMessageStoreTimeStamp

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116134#comment-16116134
 ] 

ASF GitHub Bot commented on ROCKETMQ-44:


Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/134
  
@Ritabrata-TW thanks, I will take a close look it later :-)


> Duplicated codes in DefaultMessageStore.getEarliestMessageTime and 
> DefaultMessageStore.getMessageStoreTimeStamp
> ---
>
> Key: ROCKETMQ-44
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-44
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Wu Sheng
>Assignee: vongosling
>Priority: Minor
> Fix For: 4.2.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-44) Duplicated codes in DefaultMessageStore.getEarliestMessageTime and DefaultMessageStore.getMessageStoreTimeStamp

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116151#comment-16116151
 ] 

ASF GitHub Bot commented on ROCKETMQ-44:


Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/134
  
@Ritabrata-TW Hi, thanks for your contribution, and could you please set 
your merge target to `develop` branch which is our daily development branch?


> Duplicated codes in DefaultMessageStore.getEarliestMessageTime and 
> DefaultMessageStore.getMessageStoreTimeStamp
> ---
>
> Key: ROCKETMQ-44
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-44
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Wu Sheng
>Assignee: vongosling
>Priority: Minor
> Fix For: 4.2.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-255) Offset store is null after consumer clients start()

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116237#comment-16116237
 ] 

ASF GitHub Bot commented on ROCKETMQ-255:
-

GitHub user lizhanhui opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/142

[ROCKETMQ-255] Fix offsetStore being null after consumers start()

Associated JIRA ticket is: 
https://issues.apache.org/jira/browse/ROCKETMQ-255


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lizhanhui/incubator-rocketmq offset_store

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #142


commit 6e565434a82fe6466913fce69608c173f19d1d35
Author: Li Zhanhui 
Date:   2017-08-07T08:07:35Z

DefaultMQ{Push|Pull}Consumer#getOffsetStore should not return null after 
start()




> Offset store is null after consumer clients start()
> ---
>
> Key: ROCKETMQ-255
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-255
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-255) Offset store is null after consumer clients start()

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116276#comment-16116276
 ] 

ASF GitHub Bot commented on ROCKETMQ-255:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/142
  

[![Coverage 
Status](https://coveralls.io/builds/12719494/badge)](https://coveralls.io/builds/12719494)

Coverage increased (+0.2%) to 38.932% when pulling 
**6e565434a82fe6466913fce69608c173f19d1d35 on lizhanhui:offset_store** into 
**98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.



> Offset store is null after consumer clients start()
> ---
>
> Key: ROCKETMQ-255
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-255
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-256) Manually clean disk to specified watermark with message consuming progress considered

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116283#comment-16116283
 ] 

ASF GitHub Bot commented on ROCKETMQ-256:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/143
  

[![Coverage 
Status](https://coveralls.io/builds/12719541/badge)](https://coveralls.io/builds/12719541)

Coverage decreased (-0.1%) to 38.612% when pulling 
**c967102209c27f268fb1c058263c909474d46b00 on lizhanhui:store_clean** into 
**98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.



> Manually clean disk to specified watermark with message consuming progress 
> considered
> -
>
> Key: ROCKETMQ-256
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-256
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-broker, rocketmq-store, rocketmq-tools
>Affects Versions: 4.1.0-incubating
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-256) Manually clean disk to specified watermark with message consuming progress considered

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116284#comment-16116284
 ] 

ASF GitHub Bot commented on ROCKETMQ-256:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/143
  

[![Coverage 
Status](https://coveralls.io/builds/12719541/badge)](https://coveralls.io/builds/12719541)

Coverage decreased (-0.1%) to 38.612% when pulling 
**c967102209c27f268fb1c058263c909474d46b00 on lizhanhui:store_clean** into 
**98bd032454c9dd01bcaea0f4c92abfa0b1847bac on apache:develop**.



> Manually clean disk to specified watermark with message consuming progress 
> considered
> -
>
> Key: ROCKETMQ-256
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-256
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-broker, rocketmq-store, rocketmq-tools
>Affects Versions: 4.1.0-incubating
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)