[jira] [Commented] (ROCKETMQ-218) README.md update
[ https://issues.apache.org/jira/browse/ROCKETMQ-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040204#comment-16040204 ] ASF GitHub Bot commented on ROCKETMQ-218: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [](https://coveralls.io/builds/11861699) Coverage decreased (-0.08%) to 38.595% when pulling **cf64cb9ef19252f695d53df513896c352d5d2832 on zhoudiqiu:new_pr** into **80791b6deb0e5a2ab4bc920f14f3a0e786587b53 on apache:develop**. > README.md update > > > Key: ROCKETMQ-218 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-218 > Project: Apache RocketMQ > Issue Type: Improvement >Reporter: Diqiu Zhou >Assignee: vongosling > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-218) README.md update
[ https://issues.apache.org/jira/browse/ROCKETMQ-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040203#comment-16040203 ] ASF GitHub Bot commented on ROCKETMQ-218: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [](https://coveralls.io/builds/11861699) Coverage decreased (-0.08%) to 38.595% when pulling **cf64cb9ef19252f695d53df513896c352d5d2832 on zhoudiqiu:new_pr** into **80791b6deb0e5a2ab4bc920f14f3a0e786587b53 on apache:develop**. > README.md update > > > Key: ROCKETMQ-218 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-218 > Project: Apache RocketMQ > Issue Type: Improvement >Reporter: Diqiu Zhou >Assignee: vongosling > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-218) README.md update
[ https://issues.apache.org/jira/browse/ROCKETMQ-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040205#comment-16040205 ] ASF GitHub Bot commented on ROCKETMQ-218: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/113 [](https://coveralls.io/builds/11861699) Coverage decreased (-0.08%) to 38.595% when pulling **cf64cb9ef19252f695d53df513896c352d5d2832 on zhoudiqiu:new_pr** into **80791b6deb0e5a2ab4bc920f14f3a0e786587b53 on apache:develop**. > README.md update > > > Key: ROCKETMQ-218 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-218 > Project: Apache RocketMQ > Issue Type: Improvement >Reporter: Diqiu Zhou >Assignee: vongosling > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ROCKETMQ-219) Add Batch Example
dongeforever created ROCKETMQ-219: - Summary: Add Batch Example Key: ROCKETMQ-219 URL: https://issues.apache.org/jira/browse/ROCKETMQ-219 Project: Apache RocketMQ Issue Type: Bug Reporter: dongeforever Assignee: dongeforever Fix For: 4.1.0-incubating Add batch example -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ROCKETMQ-218) README.md update
Diqiu Zhou created ROCKETMQ-218: --- Summary: README.md update Key: ROCKETMQ-218 URL: https://issues.apache.org/jira/browse/ROCKETMQ-218 Project: Apache RocketMQ Issue Type: Improvement Reporter: Diqiu Zhou Assignee: vongosling -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ROCKETMQ-217) Web site, polish example of scheduled message example
Zhanhui Li created ROCKETMQ-217: --- Summary: Web site, polish example of scheduled message example Key: ROCKETMQ-217 URL: https://issues.apache.org/jira/browse/ROCKETMQ-217 Project: Apache RocketMQ Issue Type: Bug Reporter: Zhanhui Li Assignee: Zhanhui Li -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (ROCKETMQ-204) all brokers were down but client still report heartbeat
[
https://issues.apache.org/jira/browse/ROCKETMQ-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040106#comment-16040106
]
Jaskey Lam edited comment on ROCKETMQ-204 at 6/7/17 3:38 AM:
-
The problem is because when update topic route info from nameserver, the local
topicRouteInfo table is only updated when the result from nameserver is not
null.
{code}
if (topicRouteData != null) {
//update info table here
} else {
//do nothing but log
log.warn("updateTopicRouteInfoFromNameServer,
getTopicRouteInfoFromNameServer return null. Topic: {}", topic);
}
{code}
This results client will not consider the broker is offline already , so
heartbeat will be continue to send but the attempts will actually fail always.
was (Author: jaskey):
The problem is because when update topic route info from nameserver, the local
topicRouteInfo table is only updated when the result from nameserver is not
null.
{code}
if (topicRouteData != null) {
//update info table here
} else {
//do nothing but log
log.warn("updateTopicRouteInfoFromNameServer,
getTopicRouteInfoFromNameServer return null. Topic: {}", topic);
}
{code}
> all brokers were down but client still report heartbeat
> ---
>
> Key: ROCKETMQ-204
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-204
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-broker, rocketmq-client
>Reporter: Eason Chen
>Assignee: yukon
>
> all brokers were down but client still hold at least one broker adresss and
> report heartbeat to it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-204) all brokers were down but client still report heartbeat
[
https://issues.apache.org/jira/browse/ROCKETMQ-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040106#comment-16040106
]
Jaskey Lam commented on ROCKETMQ-204:
-
The problem is because when update topic route info from nameserver, the local
topicRouteInfo table is only updated when the result from nameserver is not
null.
{code}
if (topicRouteData != null) {
//update info table here
} else {
//do nothing but log
log.warn("updateTopicRouteInfoFromNameServer,
getTopicRouteInfoFromNameServer return null. Topic: {}", topic);
}
{code}
> all brokers were down but client still report heartbeat
> ---
>
> Key: ROCKETMQ-204
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-204
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-broker, rocketmq-client
>Reporter: Eason Chen
>Assignee: yukon
>
> all brokers were down but client still hold at least one broker adresss and
> report heartbeat to it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (ROCKETMQ-216) Website polish
[ https://issues.apache.org/jira/browse/ROCKETMQ-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dongeforever closed ROCKETMQ-216. - Resolution: Fixed > Website polish > -- > > Key: ROCKETMQ-216 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-216 > Project: Apache RocketMQ > Issue Type: Bug >Reporter: Diqiu Zhou >Assignee: vongosling > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-216) Website polish
[ https://issues.apache.org/jira/browse/ROCKETMQ-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038867#comment-16038867 ] ASF GitHub Bot commented on ROCKETMQ-216: - Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq-site/pull/14 > Website polish > -- > > Key: ROCKETMQ-216 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-216 > Project: Apache RocketMQ > Issue Type: Bug >Reporter: Diqiu Zhou >Assignee: vongosling > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-208) incompatibility problem found in enviroment of JDK 1.7 when running client
[ https://issues.apache.org/jira/browse/ROCKETMQ-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038843#comment-16038843 ] ASF GitHub Bot commented on ROCKETMQ-208: - Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/110 @Jaskey This PR has been merged and will be released in 4.1.0. Thanks a lot for your work. > incompatibility problem found in enviroment of JDK 1.7 when running client > -- > > Key: ROCKETMQ-208 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-208 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-client > Environment: jdk 1.7 >Reporter: laiyiyu >Assignee: Jaskey Lam > > when I start the application which dependencies on rmq client 3.5.8 in > java7, the application throw the exception no such method, causing by the > ConcurrentHashMap inner class KeySetView of the java8incompatible with > the java7; > so , I think the official use the java8 packing the rmq source code -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (ROCKETMQ-86) Polish the release file format
[ https://issues.apache.org/jira/browse/ROCKETMQ-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dongeforever closed ROCKETMQ-86. Resolution: Fixed > Polish the release file format > -- > > Key: ROCKETMQ-86 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-86 > Project: Apache RocketMQ > Issue Type: Improvement > Components: build >Affects Versions: 4.1.0-incubating >Reporter: yukon >Assignee: yukon >Priority: Minor > Fix For: 4.1.0-incubating > > > To match the source package format, modify the release file format from .tgz > to .zip. > Refer to release.xml and release-client.xml -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ROCKETMQ-216) Website polish
Diqiu Zhou created ROCKETMQ-216: --- Summary: Website polish Key: ROCKETMQ-216 URL: https://issues.apache.org/jira/browse/ROCKETMQ-216 Project: Apache RocketMQ Issue Type: Bug Reporter: Diqiu Zhou Assignee: vongosling -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-208) incompatibility problem found in enviroment of JDK 1.7 when running client
[ https://issues.apache.org/jira/browse/ROCKETMQ-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038447#comment-16038447 ] ASF GitHub Bot commented on ROCKETMQ-208: - Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/110 @lizhanhui @dongeforever @zhouxinyu conflicts resolved, and to avoid the same problem in the future, I have replace `ConcurrentHashMap` to `ConcurrentMap` when declaring as much as possible as long as we do not dependent on the method implementation the class. Please review. > incompatibility problem found in enviroment of JDK 1.7 when running client > -- > > Key: ROCKETMQ-208 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-208 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-client > Environment: jdk 1.7 >Reporter: laiyiyu >Assignee: Jaskey Lam > > when I start the application which dependencies on rmq client 3.5.8 in > java7, the application throw the exception no such method, causing by the > ConcurrentHashMap inner class KeySetView of the java8incompatible with > the java7; > so , I think the official use the java8 packing the rmq source code -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-208) incompatibility problem found in enviroment of JDK 1.7 when running client
[ https://issues.apache.org/jira/browse/ROCKETMQ-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038389#comment-16038389 ] ASF subversion and git services commented on ROCKETMQ-208: -- Commit a8e0834a0d8e5f5951b327be8aea5e5aae8f39ac in incubator-rocketmq's branch refs/heads/release-4.1.0-incubating from [~Jaskey] [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=a8e0834 ] [ROCKETMQ-208]incompatibility problem found in enviroment of JDK 1.7 when running client closes apache/incubator-rocketmq#10 > incompatibility problem found in enviroment of JDK 1.7 when running client > -- > > Key: ROCKETMQ-208 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-208 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-client > Environment: jdk 1.7 >Reporter: laiyiyu >Assignee: Jaskey Lam > > when I start the application which dependencies on rmq client 3.5.8 in > java7, the application throw the exception no such method, causing by the > ConcurrentHashMap inner class KeySetView of the java8incompatible with > the java7; > so , I think the official use the java8 packing the rmq source code -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-208) incompatibility problem found in enviroment of JDK 1.7 when running client
[ https://issues.apache.org/jira/browse/ROCKETMQ-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038364#comment-16038364 ] ASF subversion and git services commented on ROCKETMQ-208: -- Commit 96cd2e4ed03e2c47a7d79d7e10980d154d2acb93 in incubator-rocketmq's branch refs/heads/develop from [~Jaskey] [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=96cd2e4 ] [ROCKETMQ-208]incompatibility problem found in enviroment of JDK 1.7 when running client closes apache/incubator-rocketmq#10 > incompatibility problem found in enviroment of JDK 1.7 when running client > -- > > Key: ROCKETMQ-208 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-208 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-client > Environment: jdk 1.7 >Reporter: laiyiyu >Assignee: Jaskey Lam > > when I start the application which dependencies on rmq client 3.5.8 in > java7, the application throw the exception no such method, causing by the > ConcurrentHashMap inner class KeySetView of the java8incompatible with > the java7; > so , I think the official use the java8 packing the rmq source code -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-208) incompatibility problem found in enviroment of JDK 1.7 when running client
[ https://issues.apache.org/jira/browse/ROCKETMQ-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038327#comment-16038327 ] ASF GitHub Bot commented on ROCKETMQ-208: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/110 [](https://coveralls.io/builds/11844151) Coverage decreased (-0.02%) to 38.587% when pulling **57227585735920c83c916df00a0d1f8cba0623a6 on Jaskey:ROCKETMQ-208-concurenthashmap-ncompatibility-problem** into **0c5e53db6f4d0ed9f25747379a8b679e2da5392d on apache:master**. > incompatibility problem found in enviroment of JDK 1.7 when running client > -- > > Key: ROCKETMQ-208 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-208 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-client > Environment: jdk 1.7 >Reporter: laiyiyu >Assignee: Jaskey Lam > > when I start the application which dependencies on rmq client 3.5.8 in > java7, the application throw the exception no such method, causing by the > ConcurrentHashMap inner class KeySetView of the java8incompatible with > the java7; > so , I think the official use the java8 packing the rmq source code -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-208) incompatibility problem found in enviroment of JDK 1.7 when running client
[ https://issues.apache.org/jira/browse/ROCKETMQ-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038328#comment-16038328 ] ASF GitHub Bot commented on ROCKETMQ-208: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/110 [](https://coveralls.io/builds/11844151) Coverage decreased (-0.02%) to 38.587% when pulling **57227585735920c83c916df00a0d1f8cba0623a6 on Jaskey:ROCKETMQ-208-concurenthashmap-ncompatibility-problem** into **0c5e53db6f4d0ed9f25747379a8b679e2da5392d on apache:master**. > incompatibility problem found in enviroment of JDK 1.7 when running client > -- > > Key: ROCKETMQ-208 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-208 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-client > Environment: jdk 1.7 >Reporter: laiyiyu >Assignee: Jaskey Lam > > when I start the application which dependencies on rmq client 3.5.8 in > java7, the application throw the exception no such method, causing by the > ConcurrentHashMap inner class KeySetView of the java8incompatible with > the java7; > so , I think the official use the java8 packing the rmq source code -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-208) incompatibility problem found in enviroment of JDK 1.7 when running client
[ https://issues.apache.org/jira/browse/ROCKETMQ-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038329#comment-16038329 ] ASF GitHub Bot commented on ROCKETMQ-208: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/110 [](https://coveralls.io/builds/11844151) Coverage decreased (-0.02%) to 38.587% when pulling **57227585735920c83c916df00a0d1f8cba0623a6 on Jaskey:ROCKETMQ-208-concurenthashmap-ncompatibility-problem** into **0c5e53db6f4d0ed9f25747379a8b679e2da5392d on apache:master**. > incompatibility problem found in enviroment of JDK 1.7 when running client > -- > > Key: ROCKETMQ-208 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-208 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-client > Environment: jdk 1.7 >Reporter: laiyiyu >Assignee: Jaskey Lam > > when I start the application which dependencies on rmq client 3.5.8 in > java7, the application throw the exception no such method, causing by the > ConcurrentHashMap inner class KeySetView of the java8incompatible with > the java7; > so , I think the official use the java8 packing the rmq source code -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-208) incompatibility problem found in enviroment of JDK 1.7 when running client
[ https://issues.apache.org/jira/browse/ROCKETMQ-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038278#comment-16038278 ] ASF GitHub Bot commented on ROCKETMQ-208: - Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/110 +1, cool~ > incompatibility problem found in enviroment of JDK 1.7 when running client > -- > > Key: ROCKETMQ-208 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-208 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-client > Environment: jdk 1.7 >Reporter: laiyiyu >Assignee: Jaskey Lam > > when I start the application which dependencies on rmq client 3.5.8 in > java7, the application throw the exception no such method, causing by the > ConcurrentHashMap inner class KeySetView of the java8incompatible with > the java7; > so , I think the official use the java8 packing the rmq source code -- This message was sent by Atlassian JIRA (v6.3.15#6346)
