[jira] [Commented] (ROCKETMQ-126) Provide a docker image for RocketMQ

[Jing Chen (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110026#comment-16110026
 ] 

Jing Chen commented on ROCKETMQ-126:


can you please whitelist me, I would like to take a stab on this ticket. ty

> Provide a docker image for RocketMQ
> ---
>
> Key: ROCKETMQ-126
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-126
> Project: Apache RocketMQ
>  Issue Type: Wish
>  Components: rocketmq-externals
>Reporter: yukon
>Priority: Minor
> Fix For: 4.2.0-incubating
>
>
> Provide a docker image for easy deployment and management, optimize for the 
> latest version.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-224) Client log4j2 logging

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108795#comment-16108795
 ] 

ASF GitHub Bot commented on ROCKETMQ-224:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-rocketmq/pull/120


> Client log4j2 logging
> -
>
> Key: ROCKETMQ-224
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
> Environment: Jdk 1.7
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If 
> we using log4j2,there is no client log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-231) Pull result size is always less than given size in PullConsumer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108658#comment-16108658
 ] 

ASF GitHub Bot commented on ROCKETMQ-231:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/126
  

[![Coverage 
Status](https://coveralls.io/builds/12636404/badge)](https://coveralls.io/builds/12636404)

Coverage increased (+0.9%) to 39.575% when pulling 
**a5d73d080e49e63457c2be4b996c339d6e488fae on 
lindzh:fix_consumer_pull_msg_size** into 
**9bb6eae4bd35697808174a2ff9195e393450ec91 on apache:master**.



> Pull result size is always less than given size in PullConsumer
> ---
>
> Key: ROCKETMQ-231
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-231
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-broker
>Affects Versions: 4.0.0-incubating
>Reporter: lindzh
>Assignee: yukon
>Priority: Critical
> Fix For: 4.2.0-incubating
>
>
> When using PullConsumer pull message by default result size is 32,and 
> messages is more than 32 in a queue,but broker always returns 31.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-231) Pull result size is always less than given size in PullConsumer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108660#comment-16108660
 ] 

ASF GitHub Bot commented on ROCKETMQ-231:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/126
  

[![Coverage 
Status](https://coveralls.io/builds/12636404/badge)](https://coveralls.io/builds/12636404)

Coverage increased (+0.9%) to 39.575% when pulling 
**a5d73d080e49e63457c2be4b996c339d6e488fae on 
lindzh:fix_consumer_pull_msg_size** into 
**9bb6eae4bd35697808174a2ff9195e393450ec91 on apache:master**.



> Pull result size is always less than given size in PullConsumer
> ---
>
> Key: ROCKETMQ-231
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-231
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-broker
>Affects Versions: 4.0.0-incubating
>Reporter: lindzh
>Assignee: yukon
>Priority: Critical
> Fix For: 4.2.0-incubating
>
>
> When using PullConsumer pull message by default result size is 32,and 
> messages is more than 32 in a queue,but broker always returns 31.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-231) Pull result size is always less than given size in PullConsumer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108654#comment-16108654
 ] 

ASF GitHub Bot commented on ROCKETMQ-231:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/126
  

[![Coverage 
Status](https://coveralls.io/builds/12636413/badge)](https://coveralls.io/builds/12636413)

Coverage increased (+0.6%) to 39.308% when pulling 
**a5d73d080e49e63457c2be4b996c339d6e488fae on 
lindzh:fix_consumer_pull_msg_size** into 
**9bb6eae4bd35697808174a2ff9195e393450ec91 on apache:master**.



> Pull result size is always less than given size in PullConsumer
> ---
>
> Key: ROCKETMQ-231
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-231
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-broker
>Affects Versions: 4.0.0-incubating
>Reporter: lindzh
>Assignee: yukon
>Priority: Critical
> Fix For: 4.2.0-incubating
>
>
> When using PullConsumer pull message by default result size is 32,and 
> messages is more than 32 in a queue,but broker always returns 31.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108638#comment-16108638
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12636199/badge)](https://coveralls.io/builds/12636199)

Coverage decreased (-0.4%) to 38.718% when pulling 
**6cdfaacb2e01eae477d561c8f6efd0fed1afce09 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108639#comment-16108639
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12636199/badge)](https://coveralls.io/builds/12636199)

Coverage decreased (-0.4%) to 38.718% when pulling 
**6cdfaacb2e01eae477d561c8f6efd0fed1afce09 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108640#comment-16108640
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/141
  

[![Coverage 
Status](https://coveralls.io/builds/12636199/badge)](https://coveralls.io/builds/12636199)

Coverage decreased (-0.4%) to 38.718% when pulling 
**6cdfaacb2e01eae477d561c8f6efd0fed1afce09 on lindzh:logger_appender_test** 
into **d4149207e27ed3516f1f06407b55986790b806ae on apache:master**.



> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-231) Pull result size is always less than given size in PullConsumer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108617#comment-16108617
 ] 

ASF GitHub Bot commented on ROCKETMQ-231:
-

Github user lindzh commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/126#discussion_r130558354
  
--- Diff: 
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
@@ -1110,7 +1110,7 @@ private boolean isTheBatchFull(int sizePy, int 
maxMsgNums, int bufferTotal, int
 return false;
 }
 
-if ((messageTotal + 1) >= maxMsgNums) {
--- End diff --

Yes,this problem has been fixed to maxMsgNums <= messageTotal


> Pull result size is always less than given size in PullConsumer
> ---
>
> Key: ROCKETMQ-231
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-231
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-broker
>Affects Versions: 4.0.0-incubating
>Reporter: lindzh
>Assignee: yukon
>Priority: Critical
> Fix For: 4.2.0-incubating
>
>
> When using PullConsumer pull message by default result size is 32,and 
> messages is more than 32 in a queue,but broker always returns 31.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-224) Client log4j2 logging

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108596#comment-16108596
 ] 

ASF GitHub Bot commented on ROCKETMQ-224:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/120
  

[![Coverage 
Status](https://coveralls.io/builds/12635815/badge)](https://coveralls.io/builds/12635815)

Coverage increased (+0.2%) to 38.771% when pulling 
**0ea6994712784d700aa365c2e121306b898b3355 on lindzh:fix_client_logger** into 
**0c5e53db6f4d0ed9f25747379a8b679e2da5392d on apache:master**.



> Client log4j2 logging
> -
>
> Key: ROCKETMQ-224
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
> Environment: Jdk 1.7
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If 
> we using log4j2,there is no client log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-224) Client log4j2 logging

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108595#comment-16108595
 ] 

ASF GitHub Bot commented on ROCKETMQ-224:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/120
  

[![Coverage 
Status](https://coveralls.io/builds/12635815/badge)](https://coveralls.io/builds/12635815)

Coverage increased (+0.2%) to 38.771% when pulling 
**0ea6994712784d700aa365c2e121306b898b3355 on lindzh:fix_client_logger** into 
**0c5e53db6f4d0ed9f25747379a8b679e2da5392d on apache:master**.



> Client log4j2 logging
> -
>
> Key: ROCKETMQ-224
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
> Environment: Jdk 1.7
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If 
> we using log4j2,there is no client log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-224) Client log4j2 logging

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108594#comment-16108594
 ] 

ASF GitHub Bot commented on ROCKETMQ-224:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/120
  

[![Coverage 
Status](https://coveralls.io/builds/12635815/badge)](https://coveralls.io/builds/12635815)

Coverage increased (+0.2%) to 38.771% when pulling 
**0ea6994712784d700aa365c2e121306b898b3355 on lindzh:fix_client_logger** into 
**0c5e53db6f4d0ed9f25747379a8b679e2da5392d on apache:master**.



> Client log4j2 logging
> -
>
> Key: ROCKETMQ-224
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
> Environment: Jdk 1.7
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If 
> we using log4j2,there is no client log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-224) Client log4j2 logging

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108580#comment-16108580
 ] 

ASF GitHub Bot commented on ROCKETMQ-224:
-

Github user vongosling commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/120
  
Now, LGTM. this pr also fix the rocketmq's logger appender bug when using 
any concrete implementation, no matter log4j, log4j2 or logback. 


> Client log4j2 logging
> -
>
> Key: ROCKETMQ-224
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
> Environment: Jdk 1.7
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If 
> we using log4j2,there is no client log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-224) Client log4j2 logging

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108576#comment-16108576
 ] 

ASF GitHub Bot commented on ROCKETMQ-224:
-

Github user vongosling commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/120#discussion_r130550009
  
--- Diff: 
client/src/test/java/org/apache/rocketmq/client/log/ClientLogTest.java ---
@@ -32,15 +33,19 @@
 LOG_DIR = System.getProperty(CLIENT_LOG_ROOT, 
"${user.home}/logs/rocketmqlogs");
 }
 
+// FIXME: Workarond for concret implementation for slf4j, is there any 
better solution for all slf4j implementations in one class ? 2017/8/1
--- End diff --

we'd better remember this task and fix it later.


> Client log4j2 logging
> -
>
> Key: ROCKETMQ-224
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
> Project: Apache RocketMQ
>  Issue Type: New Feature
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
> Environment: Jdk 1.7
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If 
> we using log4j2,there is no client log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-244) Message#putUserProperty uses == for String comparison

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108509#comment-16108509
 ] 

ASF subversion and git services commented on ROCKETMQ-244:
--

Commit 118bdec96005ce695295bcf0d9082e0230e69bf7 in incubator-rocketmq's branch 
refs/heads/master from shroman
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=118bdec ]

[ROCKETMQ-244] Message#putUserProperty uses == for String comparison.

Signed-off-by: shroman 


> Message#putUserProperty uses == for String comparison
> -
>
> Key: ROCKETMQ-244
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-244
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-commons
>Affects Versions: 4.1.0-incubating
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>
> {{value.trim() == ""}} won't be equal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-234) Bugfix in batch scenario

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108504#comment-16108504
 ] 

ASF subversion and git services commented on ROCKETMQ-234:
--

Commit 323eb5cebaf4c50d478afbb4d33d844741e7f403 in incubator-rocketmq's branch 
refs/heads/master from [~evthoriz]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=323eb5c ]

[ROCKETMQ-234][HOTFIX] Fix Bug, broker will write response twice in batch 
scenario

Author: evthoriz 

Closes #128 from evthoriz/bugfix.


> Bugfix in batch scenario
> 
>
> Key: ROCKETMQ-234
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-234
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-broker
>Affects Versions: 4.1.0-incubating, 4.2.0-incubating
>Reporter: Yu Kaiyuan
>Assignee: yukon
> Fix For: 4.2.0-incubating
>
>
> Bug in handle batch response. Broker will write response twice to client in 
> batch scenario.
> Details below:
> {code:java}
> private RemotingCommand sendBatchMessage(...)
> {
> // ignore irrelevant logic...
> // here in handlePutMessageResult function, reponse will be written back 
> through ctx once
> handlePutMessageResult(putMessageResult, response, request, 
> messageExtBatch, responseHeader, sendMessageContext, ctx, queueIdInt);
> // the response returned here will be written back again if response is 
> not null 
> return response;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-236) Script to merge github pull request

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108505#comment-16108505
 ] 

ASF subversion and git services commented on ROCKETMQ-236:
--

Commit b70b680033f0ed0b7ddfd16456c792cb6c002273 in incubator-rocketmq's branch 
refs/heads/master from [~Yukon]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=b70b680 ]

[ROCKETMQ-236] Script to merge github pull request


> Script to merge github pull request
> ---
>
> Key: ROCKETMQ-236
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-236
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 4.2.0-incubating
>Reporter: yukon
>Assignee: yukon
>
> Utility for creating well-formed pull request merges and pushing them to 
> Apache. Provide a modified version of 
> https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-6) Use logger for exceptions instead of e.printStackTrace()

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108507#comment-16108507
 ] 

ASF subversion and git services commented on ROCKETMQ-6:


Commit 246be9eb06a8686435f1e8db1e4fac7a0b737e89 in incubator-rocketmq's branch 
refs/heads/master from shroman
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=246be9e ]

ROCKETMQ-6: Use logger for exceptions instead of e.printStackTrace().

Signed-off-by: shroman 


> Use logger for exceptions instead of e.printStackTrace()
> 
>
> Key: ROCKETMQ-6
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-6
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
> Fix For: 4.2.0-incubating
>
>
> Replace {{e.printStackTrace()}} with {{log.error(...)}} in all core modules, 
> except tests, tools and  examples.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-243) BrokerData#selectBrokerAddr() picks the 1st element in the list of addresses

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108508#comment-16108508
 ] 

ASF subversion and git services commented on ROCKETMQ-243:
--

Commit 3672f70e9fb99b73d9c3a6102ecab06cd87d3da5 in incubator-rocketmq's branch 
refs/heads/master from shroman
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=3672f70 ]

[ROCKETMQ-243] Avoid picking the 1st element in the list of addresses for 
BrokerData#selectBrokerAddr().

Signed-off-by: shroman 


> BrokerData#selectBrokerAddr() picks the 1st element in the list of addresses
> 
>
> Key: ROCKETMQ-243
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-243
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-commons
>Affects Versions: 4.1.0-incubating
>Reporter: Roman Shtykh
>Assignee: Roman Shtykh
>Priority: Minor
>
> I wonder if this can cause broker contention. Therefore I propose to pick the 
> address at least in a random manner.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-219) Add Batch Example

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108498#comment-16108498
 ] 

ASF subversion and git services commented on ROCKETMQ-219:
--

Commit f4be3bb929c99b9066759c9f02dc6d24045088cb in incubator-rocketmq's branch 
refs/heads/develop from [~zander]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=f4be3bb ]

[ROCKETMQ-219] Add batch example, closes apache/incubator-rocketmq#112


> Add Batch Example
> -
>
> Key: ROCKETMQ-219
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-219
> Project: Apache RocketMQ
>  Issue Type: Wish
>Reporter: dongeforever
>Assignee: dongeforever
> Fix For: 4.1.0-incubating
>
>
> Add batch example



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-218) README.md update, remove some github links

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108499#comment-16108499
 ] 

ASF subversion and git services commented on ROCKETMQ-218:
--

Commit cd744a5dd2f53f226bf491201f18413ea2f33b41 in incubator-rocketmq's branch 
refs/heads/develop from [~zhoudi...@wustl.edu]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=cd744a5 ]

[ROCKETMQ-218] Polish README.md, closes apache/incubator-rocketmq#113


> README.md update, remove some github links
> --
>
> Key: ROCKETMQ-218
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-218
> Project: Apache RocketMQ
>  Issue Type: Improvement
>Reporter: Diqiu Zhou
>Assignee: vongosling
> Fix For: 4.1.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-233) Apply pull interval when pull result contains no new matched msg

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108474#comment-16108474
 ] 

ASF GitHub Bot commented on ROCKETMQ-233:
-

Github user shroman commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/127
  
@lizhanhui Got it, thanks! How about adding comments with explanations for 
each policy class? I think developers will appreciate that.


> Apply pull interval when pull result contains no new matched msg
> 
>
> Key: ROCKETMQ-233
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-233
> Project: Apache RocketMQ
>  Issue Type: Bug
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
> Fix For: 4.2.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-233) Apply pull interval when pull result contains no new matched msg

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108473#comment-16108473
 ] 

ASF GitHub Bot commented on ROCKETMQ-233:
-

Github user shroman commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/127#discussion_r130530039
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/consumer/PullIntervalPolicy.java
 ---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.client.consumer;
+
+public interface PullIntervalPolicy {
+
+void update(PullStatus status);
+
+int getPullInterval();
--- End diff --

What about making it `long`? _delay_ of executePullRequestLater(...) is 
long.


> Apply pull interval when pull result contains no new matched msg
> 
>
> Key: ROCKETMQ-233
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-233
> Project: Apache RocketMQ
>  Issue Type: Bug
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
> Fix For: 4.2.0-incubating
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-242) mqclient can not fetch nameSrvAddr periodly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108448#comment-16108448
 ] 

ASF GitHub Bot commented on ROCKETMQ-242:
-

Github user qqeasonchen commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/139#discussion_r130527608
  
--- Diff: 
client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
 ---
@@ -255,19 +255,17 @@ public void start() throws MQClientException {
 }
 
 private void startScheduledTask() {
-if (null == this.clientConfig.getNamesrvAddr()) {
--- End diff --

in fact, even though we specified the web endpoint, client will not fetch 
name server addresses any more beacase of below code in start():

`// If not specified,looking address from name server
if (null == this.clientConfig.getNamesrvAddr()) {
this.mQClientAPIImpl.fetchNameServerAddr();
}`


> mqclient can not fetch nameSrvAddr periodly
> ---
>
> Key: ROCKETMQ-242
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-242
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.0.0-incubating, 4.1.0-incubating
> Environment: test and production
>Reporter: Eason Chen
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> when mqclientinstance start, it getNameSrvAddr once by bellow code:
>  if (null == this.clientConfig.getNamesrvAddr()) {
> 
> this.clientConfig.setNamesrvAddr(this.mQClientAPIImpl.fetchNameServerAddr());
> }
> but in startScheduledTask()，it will not start the schedule task if 
> namesrvAddr is not null
> code=
> {code:java}
> public void start() throws MQClientException {
> synchronized (this) {
> switch (this.serviceState) {
> case CREATE_JUST:
> this.serviceState = ServiceState.START_FAILED;
> // If not specified,looking address from name server
>*{color:red} if (null == 
> this.clientConfig.getNamesrvAddr()) {
> 
> this.clientConfig.setNamesrvAddr(this.mQClientAPIImpl.fetchNameServerAddr());
> }{color}*
> // Start request-response channel
> this.mQClientAPIImpl.start();
> // Start various schedule tasks
> this.startScheduledTask();
> // Start pull service
> this.pullMessageService.start();
> // Start rebalance service
> this.rebalanceService.start();
> // Start push service
> 
> this.defaultMQProducer.getDefaultMQProducerImpl().start(false);
> log.info("the client factory [{}] start OK", 
> this.clientId);
> this.serviceState = ServiceState.RUNNING;
> break;
> case RUNNING:
> break;
> case SHUTDOWN_ALREADY:
> break;
> case START_FAILED:
> throw new MQClientException("The Factory object[" + 
> this.getClientId() + "] has been created before, and failed.", null);
> default:
> break;
> }
> }
> }
> private void startScheduledTask() {
>   *{color:red} if (null == this.clientConfig.getNamesrvAddr()) {{color}*
> this.scheduledExecutorService.scheduleAtFixedRate(new Runnable() {
> @Override
> public void run() {
> try {
> 
> MQClientInstance.this.mQClientAPIImpl.fetchNameServerAddr();
> } catch (Exception e) {
> log.error("ScheduledTask fetchNameServerAddr 
> exception", e);
> }
> }
> }, 1000 * 10, 1000 * 60 * 2, TimeUnit.MILLISECONDS);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-254) LoggerAppender unit test cost much time and sometimes test failure

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108424#comment-16108424
 ] 

ASF GitHub Bot commented on ROCKETMQ-254:
-

Github user vongosling commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/141#discussion_r130525133
  
--- Diff: 
logappender/src/main/java/org/apache/rocketmq/logappender/common/ProducerInstance.java
 ---
@@ -61,7 +68,7 @@ public static MQProducer getInstance(String 
nameServerAddress, String group) thr
 defaultMQProducer.setNamesrvAddr(nameServerAddress);
 MQProducer beforeProducer = null;
 //cas put producer
--- End diff --

what's the purpose for this comment :-)


> LoggerAppender unit test cost much time and sometimes test failure
> --
>
> Key: ROCKETMQ-254
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-254
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> LoggerAppender unit test cost much time, and in some cases it may cause test 
> failure,fix this case this mockito.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)