[jira] [Commented] (ROCKETMQ-286) Add a switch to decide whether to wake up commitLogService when put message

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167477#comment-16167477
 ] 

ASF GitHub Bot commented on ROCKETMQ-286:
-

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/162
  
LGTM, wake up `commitLogService` is for real-time, but it may let broker 
suffer from SSD write amplification, so provide a switch is reasonable.


> Add a switch to decide whether to wake up commitLogService when put message
> ---
>
> Key: ROCKETMQ-286
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-286
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-store
>Affects Versions: 4.0.0-incubating, 4.1.0-incubating
>Reporter: Eric Liu
>Assignee: Eric Liu
> Fix For: 4.2.0-incubating
>
>
> Now, it will wake up commitLogService after putting message. This may have 
> impact on disk.
> Add a switch to control this feature.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-289) getBrokerRuntimeInfo method may be output fileReservedTime value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167472#comment-16167472
 ] 

ASF GitHub Bot commented on ROCKETMQ-289:
-

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/163
  
Hi, thanks for your contribution. We could get FileReservedTime through 
`GetBrokerConfigCommand`, there is no need to add it to `runtimeInfo `.


> getBrokerRuntimeInfo method may be output fileReservedTime value 
> -
>
> Key: ROCKETMQ-289
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-289
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-broker
>Affects Versions: 4.0.0-incubating, 4.1.0-incubating, 4.2.0-incubating, 
> 4.3.0-incubating
>Reporter: yubaofu
>Assignee: yukon
> Fix For: 4.2.0-incubating, 4.3.0-incubating
>
>
> for some reasons, getBrokerRuntimeInfo method may be output fileReservedTime 
> value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ROCKETMQ-278) Add specified cluster for cluster info cmd

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167446#comment-16167446
 ] 

ASF GitHub Bot commented on ROCKETMQ-278:
-

Github user shroman commented on a diff in the pull request:

https://github.com/apache/incubator-rocketmq/pull/152#discussion_r139078626
  
--- Diff: 
namesrv/src/main/java/org/apache/rocketmq/namesrv/routeinfo/RouteInfoManager.java
 ---
@@ -63,11 +65,36 @@ public RouteInfoManager() {
 this.filterServerTable = new HashMap(256);
 }
 
-public byte[] getAllClusterInfo() {
-ClusterInfo clusterInfoSerializeWrapper = new ClusterInfo();
-
clusterInfoSerializeWrapper.setBrokerAddrTable(this.brokerAddrTable);
-
clusterInfoSerializeWrapper.setClusterAddrTable(this.clusterAddrTable);
-return clusterInfoSerializeWrapper.encode();
+public byte[] getAllClusterInfo(String cluster) {
--- End diff --

You change the signature of the public class here.
How about having another method -- `public byte[] getAllClusterInfo()`? And 
you won't need calling `getAllClusterInfo(null)` then too ;)


> Add specified cluster for cluster info cmd
> --
>
> Key: ROCKETMQ-278
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-278
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-client, rocketmq-namesrv, rocketmq-tools
>Affects Versions: 4.1.0-incubating
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> When using mqadmin command clusterlist,it always display all cluster,i want 
> to display specified cluster.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)