[jira] [Commented] (ROCKETMQ-136) Provide a handy message queue producer for order message sharding

2017-09-20 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174137#comment-16174137
 ] 

ASF GitHub Bot commented on ROCKETMQ-136:
-

Github user dongeforever commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/149
  
@zhouxinyu @vongosling any idea about this?


> Provide a handy message queue producer for order message sharding
> -
>
> Key: ROCKETMQ-136
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-136
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
> Fix For: 4.2.0-incubating
>
>
> When order message is needed, users need to provide a message queue selector 
> to make sure that the messages which has the same shading key should be sent 
> to the same message queue.
> Actually this is a very common scenario with a common solutions, say 
> consistent hashing.
> We should provide a handy selector for them to easily do that, what they only 
> need to provide is a sharding key.
> A consistent hash selector will meet most of the user's need.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ROCKETMQ-136) Provide a handy message queue producer for order message sharding

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132067#comment-16132067
 ] 

ASF GitHub Bot commented on ROCKETMQ-136:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/149
  

[![Coverage 
Status](https://coveralls.io/builds/12892225/badge)](https://coveralls.io/builds/12892225)

Coverage increased (+0.1%) to 39.213% when pulling 
**25f8951ecf2e3e0719d16ef91a9c930635624dad on 
Jaskey:ROCKETMQ-136-order-message** into 
**332df78e2bb6caadfc6f471445ebb1f9d224 on apache:develop**.



> Provide a handy message queue producer for order message sharding
> -
>
> Key: ROCKETMQ-136
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-136
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
> Fix For: 4.2.0-incubating
>
>
> When order message is needed, users need to provide a message queue selector 
> to make sure that the messages which has the same shading key should be sent 
> to the same message queue.
> Actually this is a very common scenario with a common solutions, say 
> consistent hashing.
> We should provide a handy selector for them to easily do that, what they only 
> need to provide is a sharding key.
> A consistent hash selector will meet most of the user's need.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ROCKETMQ-136) Provide a handy message queue producer for order message sharding

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132066#comment-16132066
 ] 

ASF GitHub Bot commented on ROCKETMQ-136:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/149
  

[![Coverage 
Status](https://coveralls.io/builds/12892225/badge)](https://coveralls.io/builds/12892225)

Coverage increased (+0.1%) to 39.213% when pulling 
**25f8951ecf2e3e0719d16ef91a9c930635624dad on 
Jaskey:ROCKETMQ-136-order-message** into 
**332df78e2bb6caadfc6f471445ebb1f9d224 on apache:develop**.



> Provide a handy message queue producer for order message sharding
> -
>
> Key: ROCKETMQ-136
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-136
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
> Fix For: 4.2.0-incubating
>
>
> When order message is needed, users need to provide a message queue selector 
> to make sure that the messages which has the same shading key should be sent 
> to the same message queue.
> Actually this is a very common scenario with a common solutions, say 
> consistent hashing.
> We should provide a handy selector for them to easily do that, what they only 
> need to provide is a sharding key.
> A consistent hash selector will meet most of the user's need.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ROCKETMQ-136) Provide a handy message queue producer for order message sharding

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132064#comment-16132064
 ] 

ASF GitHub Bot commented on ROCKETMQ-136:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/149
  

[![Coverage 
Status](https://coveralls.io/builds/12892172/badge)](https://coveralls.io/builds/12892172)

Coverage increased (+0.1%) to 39.202% when pulling 
**25f8951ecf2e3e0719d16ef91a9c930635624dad on 
Jaskey:ROCKETMQ-136-order-message** into 
**332df78e2bb6caadfc6f471445ebb1f9d224 on apache:develop**.



> Provide a handy message queue producer for order message sharding
> -
>
> Key: ROCKETMQ-136
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-136
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
> Fix For: 4.2.0-incubating
>
>
> When order message is needed, users need to provide a message queue selector 
> to make sure that the messages which has the same shading key should be sent 
> to the same message queue.
> Actually this is a very common scenario with a common solutions, say 
> consistent hashing.
> We should provide a handy selector for them to easily do that, what they only 
> need to provide is a sharding key.
> A consistent hash selector will meet most of the user's need.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ROCKETMQ-136) Provide a handy message queue producer for order message sharding

2017-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132048#comment-16132048
 ] 

ASF GitHub Bot commented on ROCKETMQ-136:
-

GitHub user Jaskey opened a pull request:

https://github.com/apache/incubator-rocketmq/pull/149

[ROCKETMQ-136]Provide a handy message queue producer for order message 
sharding

jira: https://issues.apache.org/jira/browse/ROCKETMQ-136


implementation brief: provide a OrderMessageProducer which need to 
implement an abstract method `sharingKey` and use a consistent hash selector to 
select a mq to send.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jaskey/incubator-rocketmq 
ROCKETMQ-136-order-message

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-rocketmq/pull/149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #149


commit c3388ab4a457dacab59815675a2ad98270ef6159
Author: Jaskey 
Date:   2017-08-18T10:31:49Z

[ROCKETMQ-136]Provide a handy message queue producer for order message 
sharding




> Provide a handy message queue producer for order message sharding
> -
>
> Key: ROCKETMQ-136
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-136
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-client
>Affects Versions: 4.1.0-incubating
>Reporter: Jaskey Lam
>Assignee: Jaskey Lam
>Priority: Minor
> Fix For: 4.2.0-incubating
>
>
> When order message is needed, users need to provide a message queue selector 
> to make sure that the messages which has the same shading key should be sent 
> to the same message queue.
> Actually this is a very common scenario with a common solutions, say 
> consistent hashing.
> We should provide a handy selector for them to easily do that, what they only 
> need to provide is a sharding key.
> A consistent hash selector will meet most of the user's need.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)