[GitHub] aharui commented on issue #341: Adding listener for when a bindable style has changed

2018-11-10 Thread GitBox
aharui commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437648890 If you have time to refactor things so more code is shared that would be great. There are plenty of places that could stand to

[GitHub] nihavend commented on issue #339: Spark Module class added.

2018-11-10 Thread GitBox
nihavend commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437648169 Exactly this is what i am saying @aharui. I added the import to SparkRoyaleClasses and errors go away. ContainerCreationPolicy was weak reference

[GitHub] hcsuk commented on issue #341: Adding listener for when a bindable style has changed

2018-11-10 Thread GitBox
hcsuk commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437647762 Okay thanks; so I've looked into more what's happening in various places with this... I'd wondered whether there would be value

[GitHub] aharui commented on issue #343: Question : IS there a way to embed third party components within a Royale app

2018-11-10 Thread GitBox
aharui commented on issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343#issuecomment-437641623 IUIBase source code (and all Apache Royale component source) is in ActionScript, but eventually is

[GitHub] flexicious edited a comment on issue #343: Question : IS there a way to embed third party components within a Royale app

2018-11-10 Thread GitBox
flexicious edited a comment on issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343#issuecomment-437639681 Yep - we finished the port back in 2012 . The port has been in production for a large

[GitHub] flexicious commented on issue #343: Question : IS there a way to embed third party components within a Royale app

2018-11-10 Thread GitBox
flexicious commented on issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343#issuecomment-437639681 Yep - we finished the port back in 2012 right after the infamous Steve Jobs letter. The port has

[GitHub] aharui commented on issue #343: Question : IS there a way to embed third party components within a Royale app

2018-11-10 Thread GitBox
aharui commented on issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343#issuecomment-437638929 First a side-comment: I'm sure you have finished your port to HTML/JS, but keep in mind that with

[GitHub] flexicious commented on issue #343: Question : IS there a way to embed third party components within a Royale app

2018-11-10 Thread GitBox
flexicious commented on issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343#issuecomment-437638007 Maybe some context might help here This is for a HTML port of our Flex product (Which is

[GitHub] aharui commented on issue #339: Spark Module class added.

2018-11-10 Thread GitBox
aharui commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437635851 So doesn't adding the import to SparkRoyaleClasses (but not changing spark-royale-manifest.xml) make your errors go away? I noticed that

[GitHub] flexicious commented on issue #343: Question : IS there a way to embed third party components within a Royale app

2018-11-10 Thread GitBox
flexicious commented on issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343#issuecomment-437608485 Ok this is great, so let me delve specifically into what we're trying to do, and whether its even

[GitHub] hcsuk commented on issue #341: Adding listener for when a bindable style has changed

2018-11-10 Thread GitBox
hcsuk commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437589258 One question: if you set the "style" property via a string, and make multiple calls, should the result be incremental? e.g.

[GitHub] carlosrovira commented on issue #343: Question : IS there a way to embed third party components within a Royale app

2018-11-10 Thread GitBox
carlosrovira commented on issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343#issuecomment-437579647 Hi Piotr, hehe, thought you already see that! :) I still need to make the same use in the rest

[GitHub] piotrzarzycki21 commented on issue #343: Question : IS there a way to embed third party components within a Royale app

2018-11-10 Thread GitBox
piotrzarzycki21 commented on issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343#issuecomment-437578945 Wow @carlosrovira great to hear that you were able to utilize my code for highliting code!

[GitHub] nihavend commented on issue #339: Spark Module class added.

2018-11-10 Thread GitBox
nihavend commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437567219 I should have been more clear @aharui. Spark Module is part of MXML but in the action script part of mxml. So here are the steps and the error :