[GitHub] [royale-asjs] yishayw merged pull request #1034: Under Spark, systemManager can be null in UITextFormat.measure()

2021-11-22 Thread GitBox
yishayw merged pull request #1034: URL: https://github.com/apache/royale-asjs/pull/1034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [royale-asjs] mjesteve commented on pull request #1155: jewel ThreeCheckBox - first commit

2021-11-22 Thread GitBox
mjesteve commented on pull request #1155: URL: https://github.com/apache/royale-asjs/pull/1155#issuecomment-975501258 You are right, I will change it too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [royale-asjs] Harbs commented on pull request #1155: jewel ThreeCheckBox - first commit

2021-11-22 Thread GitBox
Harbs commented on pull request #1155: URL: https://github.com/apache/royale-asjs/pull/1155#issuecomment-975499006 I'm not using Jewel and haven't tested it. After quickly reading the code, overall it looks good. The only thing that jumped out at me is I think `indeterminated` should

[GitHub] [royale-asjs] mjesteve commented on pull request #1155: jewel ThreeCheckBox - first commit

2021-11-22 Thread GitBox
mjesteve commented on pull request #1155: URL: https://github.com/apache/royale-asjs/pull/1155#issuecomment-975421954 Hi Harbs, sure, no problem, can I change it on my PR? Are you looking at it?, how do you see it?, is there anything that could be done better? Piotr was going to

[GitHub] [royale-asjs] Harbs edited a comment on pull request #1155: jewel ThreeCheckBox - first commit

2021-11-22 Thread GitBox
Harbs edited a comment on pull request #1155: URL: https://github.com/apache/royale-asjs/pull/1155#issuecomment-975413567 What do you think of changing the name to `TriStateCheckbox`? I think that's the standard name for this kind of component. -- This is an automated message from the

[GitHub] [royale-asjs] Harbs commented on pull request #1155: jewel ThreeCheckBox - first commit

2021-11-22 Thread GitBox
Harbs commented on pull request #1155: URL: https://github.com/apache/royale-asjs/pull/1155#issuecomment-975413567 What do you think of changing the name to `TriStateCheckbox`. I think that's the standard name for this kind of component. -- This is an automated message from the Apache