[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

2018-03-16 Thread GitBox
aharui commented on issue #25: [CSS] rgba is not valid in text-shadow URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-373869349 I think it should be safe to update those two projects. If you can see if they are missing in the parent pom that might be why they did not

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

2018-03-16 Thread GitBox
aharui commented on issue #25: [CSS] rgba is not valid in text-shadow URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-373860698 Hi Carlos, Just like last time, that implies that your local changes are not used when compiling an example. Do you remember what

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

2018-03-16 Thread GitBox
aharui commented on issue #25: [CSS] rgba is not valid in text-shadow URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-373828990 Hi Carlos, I forgot that Maven calls the execute() entry point in MXMLJSC and COMPJSC. Sorry about that. If you are getting

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

2018-03-15 Thread GitBox
aharui commented on issue #25: [CSS] rgba is not valid in text-shadow URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-373526917 Yes, the test checks all 3 things. We had a problem before where you had trouble picking up changes. The responsibility is on you to

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

2018-03-15 Thread GitBox
aharui commented on issue #25: [CSS] rgba is not valid in text-shadow URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-373500322 There is a test in the compiler-jx folder that is working. See CSSTestSource.css. Make that test fail and then I will take a look.

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

2018-03-06 Thread GitBox
aharui commented on issue #25: [CSS] rgba is not valid in text-shadow URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-370950624 You might need to output slightly different things for the App.js vs App.css. App.css should be compliant CSS and use rgba(). The App.css

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

2018-03-06 Thread GitBox
aharui commented on issue #25: [CSS] rgba is not valid in text-shadow URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-370925374 In the JS output, some CSS is output twice. Once in App.js as a data structure for ValuesManager/SimpleCSSValuesImpl and the other in

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

2018-03-06 Thread GitBox
aharui commented on issue #25: [CSS] rgba is not valid in text-shadow URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-370854316 This looks like it is Google Closure Compiler complaining about the text "unexpected value type:". I think that text should not be in