[GitHub] aharui commented on issue #339: Spark Module class added.

2018-11-10 Thread GitBox
aharui commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437635851 So doesn't adding the import to SparkRoyaleClasses (but not changing spark-royale-manifest.xml) make your errors go away? I noticed that

[GitHub] aharui commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox
aharui commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437565547 If you are using Spark Module in MXML files, what errors are you currently getting if Module is mapped to MX Module? Adding Spark Module to

[GitHub] aharui commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox
aharui commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437480561 It depends on what errors you are getting. If you are just referencing the class from AS, you can include the class in SparkRoyaleClasses.as but not change

[GitHub] aharui commented on issue #339: Spark Module class added.

2018-11-09 Thread GitBox
aharui commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437478181 To be clear, you would not remove mx.modules.Module.as. The spark-royale-manifest.xml (and any MXML manifest) creates a mapping of MXML tags to actual