[GitHub] aharui commented on issue #343: Question : IS there a way to embed third party components within a Royale app
aharui commented on issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343#issuecomment-437566014 Check out how Ace Editor is available in Royale. There is a frameworks/projects/Ace SWC and an examples/royale/Ace example. Yishay can probably provide more details. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library
aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library URL: https://github.com/apache/royale-compiler/issues/57#issuecomment-437565834 I think we should be able to add an "Externs" compiler target (like we have for SWF and JSRoyale and more) that will use a different set of Emitters and generate externs. The compiler can generate externs from AS files already, but it assumes the AS is written as an extern (no method body). The Externs emitters would need to strip function bodies. Since you have a workaround, I will probably get the next release out before working on it, but you or someone else are welcome to try to create the emitters. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library
aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library URL: https://github.com/apache/royale-compiler/issues/57#issuecomment-437565706 You should be able to pass these options to GCC via the Royale compiler. I think the syntax would be: -js-compiler-option="--externs ../../../BaseClasses.js" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui commented on issue #339: Spark Module class added.
aharui commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437565547 If you are using Spark Module in MXML files, what errors are you currently getting if Module is mapped to MX Module? Adding Spark Module to SparkRoyaleClasses won't help the Module tag be recognized as Spark Module. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui commented on issue #341: Adding listener for when a bindable style has changed
aharui commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437565456 Thanks for experimenting. I agree with your sentiments about the amount of code in the styles setter. Some options we have are to dictate that: 1) the styles property can only be set to an object once (you can set it to a string multiple times since you can do that in HTML). Then you wouldn't need to remove the bead from the strand 2) require that all objects (except Strings) assigned to the styles property be IBeads. In addition, it might be that we can alter the API of applyStyles to take a third parameter that is a list of properties to set. Then you wouldn't have to create the temporary object and can just pass in the entire BindableCSSValuesImpl. That might cut down on the amount of code in UIBase "just-in-case". This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kennylerma commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library
kennylerma commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library URL: https://github.com/apache/royale-compiler/issues/57#issuecomment-437539707 Thanks @aharui. I have a work-around, but it's not very elegant. I have a large project that loads many separate projects from a menu. It's just like loading SWF files. Each project shares the same base classes, so I need to exclude those base classes in each project and create a separate javascript file to use as the base library for all projects. This way I don't load the same classes again and cause conflicts. I do this by using the --externs argument for the closure compiler as below in a batch file. I make a debug build and then use the closure compiler to combine the js files, but exclude the classes in the extern file. Perhaps there could be a way to generate the single js extern file in the compiler when generating swcs. ``` @echo off set ARGS=--externs ../../../BaseClasses.js set ARGS=%ARGS% --js bin\js-debug\com\test\*.js set ARGS=%ARGS% --js bin\js-debug\com\test\test_Main.js set ARGS=%ARGS% --dependency_mode=STRICT --entry_point=test_Main @echo on java -jar %1/js/lib/google/closure-compiler/compiler.jar %ARGS% --compilation_level WHITESPACE_ONLY --js_output_file=test_Module.js ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library
aharui commented on issue #57: Dependency error when extending class and implementing interface from "external" SWC library URL: https://github.com/apache/royale-compiler/issues/57#issuecomment-437532076 Interesting. The interface shouldn't be in the requires list. But after we fix that, there will be other warnings because Google Closure Compiler cannot find the base class and interface which are referenced by some of the code. A typedefs/externs file is required for that, and I don't think you can use the .js files for the external class and interface as the typedef/extern. So that means, unlike a SWF class, which can be used as the external or linked definitions, the .js class cannot. It would be rather heavy to generate a sister typedef file for every .js file since most classes probably won't be used as external dependencies. Maybe in the future we can teach the compiler to autogenerate a typedef/extern on the fly if it sees that there are external references that have .js files that aren't externs. But that could be slow. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui closed issue #57: Dependency error when extending class and implementing interface from "external" SWC library
aharui closed issue #57: Dependency error when extending class and implementing interface from "external" SWC library URL: https://github.com/apache/royale-compiler/issues/57 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] flexicious opened a new issue #343: Question : IS there a way to embed third party components within a Royale app
flexicious opened a new issue #343: Question : IS there a way to embed third party components within a Royale app URL: https://github.com/apache/royale-asjs/issues/343 We are trying out royale, and I was wondering can I put highcharts (or any other third party javascript component) within royale? Is there a sample? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hcsuk commented on issue #341: Adding listener for when a bindable style has changed
hcsuk commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437487171 Okay - I'm having a bit of a play with this and will see what works.. about to stop for the evening to become a taxi service for a bunch of kids..! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nihavend edited a comment on issue #339: Spark Module class added.
nihavend edited a comment on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437484597 I checked the code again removing Module from SparkRoyaleClasses.as. Module references are all in as part of mxml. I guess i can leave manifest as is and import to SparkRoyaleClasses.as. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nihavend commented on issue #339: Spark Module class added.
nihavend commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437484597 I checked the code again removing Module from SparkRoyaleClasses.as. Module references are all in as part of mxml. I guess i can leave manifest as is and the import to SparkRoyaleClasses.as. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui commented on issue #339: Spark Module class added.
aharui commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437480561 It depends on what errors you are getting. If you are just referencing the class from AS, you can include the class in SparkRoyaleClasses.as but not change it in the manifest. If you are referencing it from MXML, I'm curious as to what APIs are missing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nihavend edited a comment on issue #339: Spark Module class added.
nihavend edited a comment on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437479543 It is more clear now, I am not sure that spark Module is working as mx Module. I am not at the point of things to check if working but trying to remove compiling errors. It is better to leave as it is and remove spark mapping i guess. And my question, how can i get rid of compiler arros for s:Module in my code then ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nihavend commented on issue #339: Spark Module class added.
nihavend commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437479543 It is more clear now, I am not sure that spark Module is working as mx Module. I am not at the point of things to check if working but trying to remove compiling errors. It is better to leave as it is and remove psark mapping i guess. And my question, how can i get rid of compiler arros for s:Module in my code then ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui commented on issue #339: Spark Module class added.
aharui commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437478181 To be clear, you would not remove mx.modules.Module.as. The spark-royale-manifest.xml (and any MXML manifest) creates a mapping of MXML tags to actual classes. In Flex, the spark-manifest.xml maps "Module" to "spark.modules.Module". In Royale, it is temporarily mapped via lookupOnly to mx.modules.Module because mx.modules.Module actually works. So, if you want to remove that temporary mapping and map Spark Module to spark.modules.Module, you will need to change spark-royale-manifest.xml, and further you will need to make sure spark.modules.Module actually works because I think folks are already depending on it working (via mx.modules.Module). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui commented on issue #341: Adding listener for when a bindable style has changed
aharui commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437476563 Yes, good point that BindableCSSStyles needs a reference to its "host". So thinking about this some more, there are two scenarios to support. One is that someone sets a style property at runtime via `myUIBase.style.foo = "bar";` And one just I thought about is that there could be properties on a component that are implemented as changes to HTMLElement.styles. The 'visible' property is an example (more or less). Not sure if there are others. I would say that properties that result in changes to HTMLElement.styles are not required to go through BindableCSSStyles. Instead they can just set HTMLElement.styles directly. So, I'm not clear that BindableCSSStyles needs to listen to UIBase for style changes, but it does need a reference to know what to pass to the IValuesImpl if we encapsulate change handling outside of UIBase (which would be more PAYG, IMO). If I understand your alternate plan, you are suggesting a bead that integrates BindableCSSStyles with its host. That's reasonable, but isn't another option that BindableCSSStyles itself could a bead? Not sure if we have other beads assigned via properties. The styles setter would test if the object is IBead and if so, would put BindableCSSStyles on the strand. That test is still just-in-case code, but it might be ok. We could get rid of that test by requiring that if folks use BindableCSSStyles that they use it on the beads list and not as the styles object, but that seems too weird. Or maybe all objects assigned to styles must be a Bead (or a String). Yet another option could be that the styles setter tests for an interface and assigns the reference. There is already an IDocument interface, but just having a host reference is more like IStrand so maybe having BindableCSSStyles be a bead is better and avoids people forgetting to add the bead that ties BindableCSSStyles to the change handling code. Ideally, we would remove stylesChangeHandler from UIBase and put it in BindableCSSStyles and folks could use BindableCSSStyles without any extra beads and everything would just work without too much other just-in-case code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hcsuk opened a new pull request #342: Switching from using a new HTTPStatusEvent to a ValueEvent, now with …
hcsuk opened a new pull request #342: Switching from using a new HTTPStatusEvent to a ValueEvent, now with … URL: https://github.com/apache/royale-asjs/pull/342 Following the discussion on pull request #340 this update removes the additional HTTPStatusEvent class, and instead we use a ValueEvent within the URLLoader class. To simplify the use of the uint status code within the ValueEvent, the type of 'value' is changed from 'Object' to '*'. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nihavend commented on issue #339: Spark Module class added.
nihavend commented on issue #339: Spark Module class added. URL: https://github.com/apache/royale-asjs/pull/339#issuecomment-437474507 I am using spark spark.modules.Module so added mapping. Anyone using mx.modules.Module may stilll need that mapping i guess. If not than i canre remove mx version. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui commented on issue #340: URLLoader: HTTPStatusEvent addition
aharui commented on issue #340: URLLoader: HTTPStatusEvent addition URL: https://github.com/apache/royale-asjs/pull/340#issuecomment-437467293 IMO, Object is as weak as *. Object is used in Flash often as "Any but not undefined". So changing to * probably wouldn't make things significantly weaker. If you have time to make these changes, please do so. I think having fewer Event classes will benefit Royale. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hcsuk commented on issue #341: Adding listener for when a bindable style has changed
hcsuk commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437466684 To do this, there would need to be a link created between the UI object (UIBase), and the BindableCSSStyles object, so that the latter could listen out for style changes on the UIBase object. So this would imply we still need to change UIBase.as, such that when the style is set on it, it sets up the event listener - essentially this just moves the `styleChangeHandler` code from UIBase into BindableCSSStyles, but still needs similar changes to be made to UIBase. An alternative would be to create a bead that does this stuff so we could keep the same code in all the existing classes, but just have folk add a bead that would set everything up to sort out the styles based on the changes to the UIBase object... that would be a little more stand-alone and avoids adding code into any existing class or changing the current functionality for anyone.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hcsuk commented on issue #340: URLLoader: HTTPStatusEvent addition
hcsuk commented on issue #340: URLLoader: HTTPStatusEvent addition URL: https://github.com/apache/royale-asjs/pull/340#issuecomment-437464342 Having the * type makes me a little uncomfortable but that's just because of my background in strongly typed languages probably! and also knowing what happens under the hood within AS3/avmplus around objects and references. But I definitely agree with the idea of reducing the number of classes required so would probably go with this option rather than creating multiple ValueEvent derivations for the different types.. Happy to change to that, and then revert these changes, if you think this is worth doing? thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui commented on issue #341: Adding listener for when a bindable style has changed
aharui commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437463001 It would be PAYG to have a variant of SimpleCSSValuesImpl that expects runtime changes to styles, but couldn't all of the code that needs to be run be encapsulated in BindableCSSStyles (and avoid the temporary object? That would be even more PAYG, if the code doesn't get awful or too much code gets duplicated from the IValuesImpl. Or maybe applyStyles need to be refactored or a new API is needed on IValuesImpl to be passed the BindableCSSStyles itself. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hcsuk commented on issue #341: Adding listener for when a bindable style has changed
hcsuk commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437461172 Okay yes good point (and I definitely like the way that most of the Royale classes are very small - makes them easy to understand!). So I'll have a quick go at updating the `BindableCSSStyles` class - or perhaps, having looked at it, it would make more sense provide a subclass of `SimpleCSSValuesImpl` which is where there's an association between the UI element and the Style object (in `applyStyles`) where we could listen out for changes in the style, and then just directly adjust that particular style rather than having to create a new dynamic object and then parse it... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hcsuk commented on issue #340: URLLoader: HTTPStatusEvent addition
hcsuk commented on issue #340: URLLoader: HTTPStatusEvent addition URL: https://github.com/apache/royale-asjs/pull/340#issuecomment-437456584 Thanks - I had wondered about using the ValueEvent .. my main concern with that was the typing, where it's after an Object type. If it was a * it might have been possible I guess, but when I wanted to put an integer into this slot I would have got compiler errors from the initial type checking. Adding it as an object with a 'status' member would have added overhead within the VM. As an aside, this might be where a templated type would be useful e.g. `ValueEvent.` ... but that's a bit of a digression! cheers This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aharui commented on issue #341: Adding listener for when a bindable style has changed
aharui commented on issue #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341#issuecomment-437452380 Actually, I was thinking of pulling out that UIBase.styleChangeHandler. Ideally, because of PAYG, we could devise a solution where BindableCSSStyles just runs the code that was in styleChangeHandler. This is another example of the mindset-shift difference between Flex and Royale that I'm trying to promote. Flex's UIComponent grew to 13,000 lines of code because we kept adding little bits of just-in-case code. I would like us to try to find solutions that are PAYG and keep separation of concerns. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kennylerma opened a new issue #57: Dependency error when extending class from "external" SWC library
kennylerma opened a new issue #57: Dependency error when extending class from
"external" SWC library
URL: https://github.com/apache/royale-compiler/issues/57
The included TEST.swc has a simple TestClass class in it. The swc is
compiled correctly and includes the javascript. When I use the swc as an
included library it works just fine. However, if I use the swc as an External
library so not to include the classes in the output, I get the error below.
The key here is that I'm extending the class from the swc. If I don't extend
this class and just instantiate it compiles fine.
Internal error: java.lang.NullPointerException
org.apache.royale.compiler.internal.graph.GoogDepsWriter.generateDeps(GoogDepsWriter.java:214)org.apache.royale.compiler.internal.codegen.mxml.royale.MXMLRoyalePublisher.publish(MXMLRoyalePublisher.java:422)org.apache.royale.compiler.clients.MXMLJSCNative.compile(MXMLJSCNative.java:376)org.apache.royale.compiler.clients.MXMLJSCNative._mainNoExit(MXMLJSCNative.java:234)org.apache.royale.compiler.clients.MXMLJSCNative.mainNoExit(MXMLJSCNative.java:191)org.apache.royale.compiler.clients.MXMLJSC._mainNoExit(MXMLJSC.java:401)org.apache.royale.compiler.clients.MXMLJSC.mainNoExit(MXMLJSC.java:300)org.apache.royale.compiler.clients.MXMLJSC.staticMainNoExit(MXMLJSC.java:259)org.apache.royale.compiler.clients.MXMLJSC.main(MXMLJSC.java:241)
Main document class
```
package
{
import TestClass;
public class Main extends TestClass
{
public function Main()
{
}
}
}
```
Class from TEST.swc
```
package
{
public class TestClass
{
public function TestClass()
{
}
}
}
```
[TestFiles.zip](https://github.com/apache/royale-compiler/files/2566896/TestFiles.zip)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] hcsuk opened a new pull request #341: Adding listener for when a bindable style has changed
hcsuk opened a new pull request #341: Adding listener for when a bindable style has changed URL: https://github.com/apache/royale-asjs/pull/341 There was already an event handler for this, but it wasn't being hooked up... If we have some bindable styles, they are being updated by the binding code but the style wasn't being re-applied to the element. Adding this event listener (if the style implements IEventDispatcher - the bindable one does, the simple one doesn't) made it all just work.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hcsuk opened a new pull request #340: URLLoader: HTTPStatusEvent addition
hcsuk opened a new pull request #340: URLLoader: HTTPStatusEvent addition URL: https://github.com/apache/royale-asjs/pull/340 Adding an HTTPStatusEvent into the JS-based code. We've found that this is required by some applications and it seems to make sense to expose this to client code. Initial thought was to add a status property to the URLLoader directly, but the "httpStatus" event was already being dispatched, so this just adds an extra value to the event object so that listeners can check whether the request was successful. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kennylerma closed issue #42: Update Closure Compiler for removal of google dependencies in WHITESPACE_ONLY mode
kennylerma closed issue #42: Update Closure Compiler for removal of google dependencies in WHITESPACE_ONLY mode URL: https://github.com/apache/royale-compiler/issues/42 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Harbs commented on issue #338: Question: How TLF measures text?
Harbs commented on issue #338: Question: How TLF measures text? URL: https://github.com/apache/royale-asjs/issues/338#issuecomment-437318481 TLF itself is ported, but there's quite a few caveats. TLF required FTE to work properly. The text engine was propriety code. For TLF to actually do anything you need a JS text engine. This needs to be done in either DOM elements, SVG or Canvas. The TLF interactions with the text engine were all changed to interfaces, so you can swap out different text engines as needed. Currently, Royale only has a relatively simple text engine which Alex implemented as DOM elements. I'm using a custom text engine we developed internally. There is a possibility that we might license our text engine at some point in the future, but we have a significant amount of work to do to make that happen. You can contact me privately for more details. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] devlfm commented on issue #338: Question: How TLF measures text?
devlfm commented on issue #338: Question: How TLF measures text? URL: https://github.com/apache/royale-asjs/issues/338#issuecomment-437316174 @aharui @carlosrovira someone ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
