[jira] [Commented] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743529#comment-16743529 ] Hadoop QA commented on SENTRY-2482: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12955020/SENTRY-2482.patch against master. {color:red}Overall:{color} -1 due to 2 errors {color:red}ERROR:{color} mvn test exited 1 {color:red}ERROR:{color} Failed: org.apache.sentry.tests.e2e.hdfs.TestHDFSIntegrationEnd2End Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4318/console This message is automatically generated. > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482 Solr - Design Documentation.pdf, > SENTRY-2482.patch.6, SENTRY-2482.patch.7, SENTRY-2482.patch.8 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tristan Stevens updated SENTRY-2482: Attachment: SENTRY-2482.patch.8 > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482 Solr - Design Documentation.pdf, > SENTRY-2482.patch.6, SENTRY-2482.patch.7, SENTRY-2482.patch.8 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743431#comment-16743431 ] Hadoop QA commented on SENTRY-2482: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12955016/SENTRY-2482.patch against master. {color:red}Overall:{color} -1 due to an error {color:red}ERROR:{color} failed to apply patch (exit code 1): fatal: corrupt patch at line 2285 fatal: corrupt patch at line 2285 fatal: corrupt patch at line 2285 The patch does not appear to apply with p0, p1, or p2 Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4317/console This message is automatically generated. > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482 Solr - Design Documentation.pdf, > SENTRY-2482.patch.6, SENTRY-2482.patch.7 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743426#comment-16743426 ] Tristan Stevens commented on SENTRY-2482: - I don't think the test failures are caused by my changes, although I'd appreciate a second look. I've attached a new patch that addresses the whitespace errors. > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482 Solr - Design Documentation.pdf, > SENTRY-2482.patch.6, SENTRY-2482.patch.7 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tristan Stevens updated SENTRY-2482: Attachment: SENTRY-2482.patch.7 > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482 Solr - Design Documentation.pdf, > SENTRY-2482.patch.6, SENTRY-2482.patch.7 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743286#comment-16743286 ] Hadoop QA commented on SENTRY-2482: --- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12954991/SENTRY-2482.patch against master. {color:red}Overall:{color} -1 due to 2 errors {color:red}ERROR:{color} mvn test exited 1 {color:red}ERROR:{color} Failed: org.apache.sentry.tests.e2e.dbprovider.TestDbSentryOnFailureHookLoading Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4316/console This message is automatically generated. > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482 Solr - Design Documentation.pdf, > SENTRY-2482.patch.6 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tristan Stevens updated SENTRY-2482: Attachment: (was: SENTRY-2482.patch.5) > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482 Solr - Design Documentation.pdf, > SENTRY-2482.patch.6 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743193#comment-16743193 ] Tristan Stevens commented on SENTRY-2482: - Attached design document and updated patch following Zsolt's comments. > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482 Solr - Design Documentation.pdf, > SENTRY-2482.patch.6 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tristan Stevens updated SENTRY-2482: Status: Patch Available (was: Open) > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482 Solr - Design Documentation.pdf, > SENTRY-2482.patch.6 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tristan Stevens updated SENTRY-2482: Attachment: SENTRY-2482.patch.6 > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482 Solr - Design Documentation.pdf, > SENTRY-2482.patch.5, SENTRY-2482.patch.6 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tristan Stevens updated SENTRY-2482: Attachment: SENTRY-2482 Solr - Design Documentation.pdf > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482 Solr - Design Documentation.pdf, > SENTRY-2482.patch.5, SENTRY-2482.patch.6 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tristan Stevens updated SENTRY-2482: Attachment: SENTRY-2482.patch.5 > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > Attachments: SENTRY-2482.patch.5 > > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SENTRY-2482) Sentry Solr to support multi-attribute document level security
[ https://issues.apache.org/jira/browse/SENTRY-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743068#comment-16743068 ] Zsolt Gyulavari commented on SENTRY-2482: - Apart from initializing the 'attributes' Set as a mutable collection in FieldToAttributeMapping.java:L46 I can see no problems with the code. I cannot comment in Review Board, please wrap it in a Collections.unmodifiableSet(...), otherwise I'm happy with it. > Sentry Solr to support multi-attribute document level security > -- > > Key: SENTRY-2482 > URL: https://issues.apache.org/jira/browse/SENTRY-2482 > Project: Sentry > Issue Type: Improvement > Components: Solr Plugin >Reporter: Tristan Stevens >Assignee: Tristan Stevens >Priority: Major > > This is an improvement request to cover enhanced document level security for > the Solr document level controls, specifically to cover: > # Security controls against multiple fields > # Filters based on user attributes as well as just Sentry roles > # Different security predicates (AND, LessThan, GreaterThan - in addition to > the currently supported OR) > # Pluggable user attribute source ahead of Sentry enhancements. > # Sample LDAP user attribute source > The ambition is this will be a precursor to full complex predicate support > being served by Sentry ABAC roadmap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)