[jira] [Commented] (SCB-1263) forward request in edge should not inherit cse-context

2019-04-22 Thread YaoHaishi (JIRA)
[ https://issues.apache.org/jira/browse/SCB-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822959#comment-16822959 ] YaoHaishi commented on SCB-1263: PR has been created, EdgeService does not inherit InvocationContext from

[jira] [Commented] (SCB-1263) forward request in edge should not inherit cse-context

2019-04-20 Thread YaoHaishi (JIRA)
[ https://issues.apache.org/jira/browse/SCB-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822463#comment-16822463 ] YaoHaishi commented on SCB-1263: Hi, how about adding a configuration to determine whether to inherit

[jira] [Commented] (SCB-1263) forward request in edge should not inherit cse-context

2019-04-20 Thread wujimin (JIRA)
[ https://issues.apache.org/jira/browse/SCB-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822433#comment-16822433 ] wujimin commented on SCB-1263: -- i think the difference is who do this action. > forward request in edge

[jira] [Commented] (SCB-1263) forward request in edge should not inherit cse-context

2019-04-19 Thread liubao (JIRA)
[ https://issues.apache.org/jira/browse/SCB-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822320#comment-16822320 ] liubao commented on SCB-1263: - There is no difference between "maybe we can provide a way to allow developer

[jira] [Commented] (SCB-1263) forward request in edge should not inherit cse-context

2019-04-19 Thread wujimin (JIRA)
[ https://issues.apache.org/jira/browse/SCB-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822312#comment-16822312 ] wujimin commented on SCB-1263: -- this type inject is a high risk operation we should not inherit cse-context

[jira] [Commented] (SCB-1263) forward request in edge should not inherit cse-context

2019-04-19 Thread liubao (JIRA)
[ https://issues.apache.org/jira/browse/SCB-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822292#comment-16822292 ] liubao commented on SCB-1263: - Tracing is one of the possible scenarios, and you give an optional way to

[jira] [Commented] (SCB-1263) forward request in edge should not inherit cse-context

2019-04-19 Thread YaoHaishi (JIRA)
[ https://issues.apache.org/jira/browse/SCB-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821813#comment-16821813 ] YaoHaishi commented on SCB-1263: Agree with wujimin. Since the EdgeService is facing the request from

[jira] [Commented] (SCB-1263) forward request in edge should not inherit cse-context

2019-04-19 Thread wujimin (JIRA)
[ https://issues.apache.org/jira/browse/SCB-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821704#comment-16821704 ] wujimin commented on SCB-1263: -- for tracing from outside edge, edge should inherited them from standard http

[jira] [Commented] (SCB-1263) forward request in edge should not inherit cse-context

2019-04-19 Thread liubao (JIRA)
[ https://issues.apache.org/jira/browse/SCB-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821700#comment-16821700 ] liubao commented on SCB-1263: - I think we should make it default to not override, because it's very usefull