[jira] [Commented] (SCB-706) refactor loadbalance filters logic to support invocation based filter
[ https://issues.apache.org/jira/browse/SCB-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541090#comment-16541090 ] ASF GitHub Bot commented on SCB-706: coveralls commented on issue #803: [SCB-706]change filters to discovery filters and support invocation based filters URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/803#issuecomment-404380842 [](https://coveralls.io/builds/17946654) Coverage decreased (-0.09%) to 87.039% when pulling **f6a460c7ba872c9b31a76957bf557337ada46b60 on liubao68:test-11** into **b00f4c748122460ba1484815ed9c98eadf9eba31 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > refactor loadbalance filters logic to support invocation based filter > - > > Key: SCB-706 > URL: https://issues.apache.org/jira/browse/SCB-706 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > > Why we do this? > # When implement invocation based filter, e.g. darklaunch deployment, we > need to filter servers based on invocation parameters. But now, we create a > Loadbalaner instance for each service, and Robin filter interface can not > pass Invocation to it. Before refactor, we doing this by ThreadLocal and > cache Invocation, and use in filter implementation. This is error prone and > users can't handle this complixity > # We have other improvements, e.g. SCB-700, we can do server status check, > and add a filter a choose from active servers. We need to consider filter > orders and other feature, current implementation not satisfy this. > # We want to make loadbalance code handy by remove some compatible fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-737) avoid null point exception
laijianbin created SCB-737:
--
Summary: avoid null point exception
Key: SCB-737
URL: https://issues.apache.org/jira/browse/SCB-737
Project: Apache ServiceComb
Issue Type: Task
Reporter: laijianbin
Assignee: laijianbin
2018-07-11
03:27:52,651Z(28241):ERROR{}[main]org.springframework.boot.SpringApplication.reportFailure(SpringApplication.java:771)-->Application
startup failed
org.springframework.beans.factory.UnsatisfiedDependencyException: Error
creating bean with name 'batchConfig': Unsatisfied dependency expressed through
field 'jobBuilderFactory'; nested exception is
org.springframework.beans.factory.BeanCreationException: Error creating bean
with name 'jobBuilders' defined in class path resource
[org/springframework/batch/core/configuration/annotation/SimpleBatchConfiguration.class]:
Bean instantiation via factory method failed; nested exception is
org.springframework.beans.BeanInstantiationException: Failed to instantiate
[org.springframework.batch.core.configuration.annotation.JobBuilderFactory]:
Factory method 'jobBuilders' threw exception; nested exception is
org.springframework.beans.factory.BeanCreationException: Error creating bean
with name 'jobRepository' defined in class path resource
[org/springframework/batch/core/configuration/annotation/SimpleBatchConfiguration.class]:
Initialization of bean failed; nested exception is
java.lang.NullPointerException
RELEASE]
at
org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:207)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1136)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1064)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:585)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
... 19 more
Caused by: java.lang.NullPointerException
at
org.apache.servicecomb.provider.rest.common.RestProducers.processProvider(RestProducers.java:52)
~[provider-rest-common-1.0.0.B003.6.jar:1.0.0.B003.6]
at
org.apache.servicecomb.provider.rest.common.RestProducers.postProcessAfterInitialization(RestProducers.java:43)
~[provider-rest-common-1.0.0.B003.6.jar:1.0.0.B003.6]
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyBeanPostProcessorsAfterInitialization(AbstractAutowireCapableBeanFactory.java:423)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1594)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:554)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:483)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197)
~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:381)
~[spring-context-4.3.5.RELEASE.jar:4.3.5.RELEASE]
at
[jira] [Commented] (SCB-727) Java Chassis-Local generated schema and service center schema are different while registering the service then print the difference content
[ https://issues.apache.org/jira/browse/SCB-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541062#comment-16541062 ] ASF GitHub Bot commented on SCB-727: liubao68 edited a comment on issue #801: [SCB-727] Local generated schema and service center schema are different then print the diff content to the user URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/801#issuecomment-404371649 Tips: when adding new commits to existing PR, please use commit message start with issue id and a message related to the new commit(not copy the original one), e.g. [SCB-727] add unit test case So that we can create a rebase and merge and we also known these commits are related. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Java Chassis-Local generated schema and service center schema are different > while registering the service then print the difference content > --- > > Key: SCB-727 > URL: https://issues.apache.org/jira/browse/SCB-727 > Project: Apache ServiceComb > Issue Type: Improvement >Affects Versions: java-chassis-1.0.0 >Reporter: Mahesh Raju Somalaraju >Assignee: Mahesh Raju Somalaraju >Priority: Major > Fix For: java-chassis-1.0.0 > > > Java Chassis- Local generated schema and service center schema are different > while registering the service then print the difference content. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-727) Java Chassis-Local generated schema and service center schema are different while registering the service then print the difference content
[ https://issues.apache.org/jira/browse/SCB-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541055#comment-16541055 ] ASF GitHub Bot commented on SCB-727: liubao68 commented on issue #801: [SCB-727] Local generated schema and service center schema are different then print the diff content to the user URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/801#issuecomment-404371649 Tips: when adding new commits to existing PR, please use commit message start with issue id, e.g. [SCB-727] add unit test case So that we can create a rebase and merge and we also known these commits are related. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Java Chassis-Local generated schema and service center schema are different > while registering the service then print the difference content > --- > > Key: SCB-727 > URL: https://issues.apache.org/jira/browse/SCB-727 > Project: Apache ServiceComb > Issue Type: Improvement >Affects Versions: java-chassis-1.0.0 >Reporter: Mahesh Raju Somalaraju >Assignee: Mahesh Raju Somalaraju >Priority: Major > Fix For: java-chassis-1.0.0 > > > Java Chassis- Local generated schema and service center schema are different > while registering the service then print the difference content. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-733) open handlerContext for business logic, and add a new name: localContext
[ https://issues.apache.org/jira/browse/SCB-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao updated SCB-733: --- Fix Version/s: java-chassis-1.0.0 > open handlerContext for business logic, and add a new name: localContext > > > Key: SCB-733 > URL: https://issues.apache.org/jira/browse/SCB-733 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-733) open handlerContext for business logic, and add a new name: localContext
[ https://issues.apache.org/jira/browse/SCB-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao resolved SCB-733. Resolution: Fixed > open handlerContext for business logic, and add a new name: localContext > > > Key: SCB-733 > URL: https://issues.apache.org/jira/browse/SCB-733 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-733) open handlerContext for business logic, and add a new name: localContext
[
https://issues.apache.org/jira/browse/SCB-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541038#comment-16541038
]
ASF GitHub Bot commented on SCB-733:
liubao68 closed pull request #802: [SCB-733] open handlerContext for business
logic, and add a new name:localContext
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/802
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/src/main/java/org/apache/servicecomb/core/Invocation.java
b/core/src/main/java/org/apache/servicecomb/core/Invocation.java
index 43c93ea7c..6b5be130a 100644
--- a/core/src/main/java/org/apache/servicecomb/core/Invocation.java
+++ b/core/src/main/java/org/apache/servicecomb/core/Invocation.java
@@ -17,7 +17,6 @@
package org.apache.servicecomb.core;
-import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.Executor;
@@ -47,7 +46,7 @@
private Endpoint endpoint;
// 只用于handler之间传递数据，是本地数据
- private Map handlerContext = new HashMap<>();
+ private Map handlerContext = localContext;
// handler链，是arrayList，可以高效地通过index访问
private List handlerList;
diff --git a/core/src/test/java/org/apache/servicecomb/core/TestInvocation.java
b/core/src/test/java/org/apache/servicecomb/core/TestInvocation.java
index 49352abf1..0efc78370 100644
--- a/core/src/test/java/org/apache/servicecomb/core/TestInvocation.java
+++ b/core/src/test/java/org/apache/servicecomb/core/TestInvocation.java
@@ -135,4 +135,13 @@ public void isConsumer_no(@Mocked ReferenceConfig
referenceConfig) {
Invocation invocation = new Invocation(referenceConfig, operationMeta,
swaggerArguments);
Assert.assertTrue(invocation.isConsumer());
}
+
+ @Test
+ public void localContext(@Mocked ReferenceConfig referenceConfig) {
+Invocation invocation = new Invocation(referenceConfig, operationMeta,
swaggerArguments);
+
+invocation.addLocalContext("k", 1);
+Assert.assertSame(invocation.getHandlerContext(),
invocation.getLocalContext());
+Assert.assertEquals(1, (int) invocation.getLocalContext("k"));
+ }
}
diff --git
a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/engine/unittest/LocalProducerInvoker.java
b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/engine/unittest/LocalProducerInvoker.java
index ba4afce75..31bf31abc 100644
---
a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/engine/unittest/LocalProducerInvoker.java
+++
b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/engine/unittest/LocalProducerInvoker.java
@@ -61,7 +61,7 @@ public SwaggerInvocation getInvocation() {
return invocation.getSwaggerArgument(idx);
}
- public T getContext(String key) {
+ public String getContext(String key) {
return invocation.getContext(key);
}
diff --git
a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/SwaggerInvocation.java
b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/SwaggerInvocation.java
index cd2c0948f..98f0ad8b0 100644
---
a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/SwaggerInvocation.java
+++
b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/SwaggerInvocation.java
@@ -32,6 +32,7 @@ public SwaggerInvocation() {
parentContext = ContextUtils.getInvocationContext();
if (parentContext != null) {
addContext(parentContext.getContext());
+ addLocalContext(parentContext.getLocalContext());
}
}
diff --git
a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/context/InvocationContext.java
b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/context/InvocationContext.java
index 8804d40c4..2edeca77e 100644
---
a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/context/InvocationContext.java
+++
b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/context/InvocationContext.java
@@ -34,6 +34,8 @@
// value只能是简单类型
protected Map context = new HashMap<>();
+ protected Map localContext = new HashMap<>();
+
public InvocationContext() {
httpStatus = Status.OK;
}
@@ -50,9 +52,8 @@ public void addContext(String key, String value) {
context.put(key, value);
}
- @SuppressWarnings("unchecked")
- public T getContext(String key) {
-
[jira] [Assigned] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
[ https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao reassigned SCB-736: -- Assignee: sukesh > generate default value to swagger for primitive type, even there is no > defaultValue annotation > -- > > Key: SCB-736 > URL: https://issues.apache.org/jira/browse/SCB-736 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: sukesh >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
wujimin created SCB-736: --- Summary: generate default value to swagger for primitive type, even there is no defaultValue annotation Key: SCB-736 URL: https://issues.apache.org/jira/browse/SCB-736 Project: Apache ServiceComb Issue Type: Task Components: Java-Chassis Reporter: wujimin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-706) refactor loadbalance filters logic to support invocation based filter
[
https://issues.apache.org/jira/browse/SCB-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540250#comment-16540250
]
ASF GitHub Bot commented on SCB-706:
liubao68 closed pull request #786: [SCB-706]refactor loadbalance filters logic
to support invocation based filter
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/786
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/demo/demo-springmvc/springmvc-client/src/main/resources/microservice.yaml
b/demo/demo-springmvc/springmvc-client/src/main/resources/microservice.yaml
index 09a4d0e69..ce89ac481 100644
--- a/demo/demo-springmvc/springmvc-client/src/main/resources/microservice.yaml
+++ b/demo/demo-springmvc/springmvc-client/src/main/resources/microservice.yaml
@@ -54,10 +54,6 @@ servicecomb:
retryEnabled: true
retryOnSame: 1
retryOnNext: 1
-serverListFilters: zoneaware
-serverListFilter:
- zoneaware:
-className:
org.apache.servicecomb.loadbalance.filter.ZoneAwareServerListFilterExt
fallbackpolicy:
Consumer:
springmvc:
diff --git
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadBalancer.java
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadBalancer.java
index 22f8b19bb..51bcc682b 100644
---
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadBalancer.java
+++
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadBalancer.java
@@ -19,59 +19,32 @@
import java.util.Collections;
import java.util.List;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
-
-import org.apache.servicecomb.core.Invocation;
import com.netflix.loadbalancer.AbstractLoadBalancer;
import com.netflix.loadbalancer.IRule;
import com.netflix.loadbalancer.LoadBalancerStats;
import com.netflix.loadbalancer.Server;
-import com.netflix.loadbalancer.ServerListFilter;
-import com.netflix.loadbalancer.WeightedResponseTimeRule;
/**
- * 实现不包含服务器状态监测的负载均衡器。（这些职责在注册中心客户端实现）
- *
+ * Robbin LoadBalancer implementation. Only support IRule and basic
operations.
*/
public class LoadBalancer extends AbstractLoadBalancer {
- private String name;
-
private List serverList = Collections.emptyList();
private IRule rule;
private LoadBalancerStats lbStats;
- // 以filter类名为Key
- private Map filters;
-
private String microServiceName;
- public LoadBalancer(String name, IRule rule, String microServiceName) {
-this.name = name;
-this.rule = rule;
+ public LoadBalancer(IRule rule, String microServiceName,
+ LoadBalancerStats stats) {
this.microServiceName = microServiceName;
-this.lbStats = new LoadBalancerStats(null);
-this.filters = new ConcurrentHashMap<>();
+this.rule = rule;
this.rule.setLoadBalancer(this);
+this.lbStats = stats;
}
- public String getName() {
-return name;
- }
-
- public void shutdown() {
-// netflix components does not have a property way to shutdown
laodbalancers so we do it in a not quite elegant way.
-if (this.rule instanceof WeightedResponseTimeRule) {
- ((WeightedResponseTimeRule) this.rule).shutdown();
-}
- }
-
- // every filter group has a loadBalancer instance
- // serverList almost not changed for different invocation
- // so every invocation will call setServerList, this is no problem
public void setServerList(List serverList) {
this.serverList = Collections.unmodifiableList(serverList);
}
@@ -103,12 +76,14 @@ public void markServerDown(Server server) {
}
@Override
+ // Different types of Robin Component Rule have different usages for server
status and list.
+ // e.g. RoundRobinRule using getAllServers & alive & readyToServe
+ // RandomRule using getReachableServers & alive
+ // WeightedResponseTimeRule using getAllServers & alive
+ // To make all rules work only on "how to choose a server from alive
servers", we do not rely on Robbin getReachableServers.
+ // We ensure getReachableServers & getAllServers work in the same way.
public List getAllServers() {
-List servers = serverList;
-for (ServerListFilter filter : filters.values()) {
- servers = filter.getFilteredListOfServers(servers);
-}
-return servers;
+return serverList;
}
@Override
@@ -121,20 +96,6 @@ public LoadBalancerStats getLoadBalancerStats() {
return lbStats;
}
- public void setInvocation(Invocation invocation) {
-for (ServerListFilterExt filter : filters.values()) {
- filter.setInvocation(invocation);
-}
- }
-
- public void putFilter(String name, ServerListFilterExt filter) {
-
[jira] [Commented] (SCB-706) refactor loadbalance filters logic to support invocation based filter
[ https://issues.apache.org/jira/browse/SCB-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540249#comment-16540249 ] ASF GitHub Bot commented on SCB-706: liubao68 commented on issue #786: [SCB-706]refactor loadbalance filters logic to support invocation based filter URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/786#issuecomment-404211445 closed for new https://github.com/apache/incubator-servicecomb-java-chassis/pull/803 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > refactor loadbalance filters logic to support invocation based filter > - > > Key: SCB-706 > URL: https://issues.apache.org/jira/browse/SCB-706 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > > Why we do this? > # When implement invocation based filter, e.g. darklaunch deployment, we > need to filter servers based on invocation parameters. But now, we create a > Loadbalaner instance for each service, and Robin filter interface can not > pass Invocation to it. Before refactor, we doing this by ThreadLocal and > cache Invocation, and use in filter implementation. This is error prone and > users can't handle this complixity > # We have other improvements, e.g. SCB-700, we can do server status check, > and add a filter a choose from active servers. We need to consider filter > orders and other feature, current implementation not satisfy this. > # We want to make loadbalance code handy by remove some compatible fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-706) refactor loadbalance filters logic to support invocation based filter
[ https://issues.apache.org/jira/browse/SCB-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540246#comment-16540246 ] ASF GitHub Bot commented on SCB-706: liubao68 commented on issue #803: [SCB-706]change filters to discovery filters and support invocation based filters URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/803#issuecomment-404211055 related docs PR： https://github.com/apache/incubator-servicecomb-docs/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > refactor loadbalance filters logic to support invocation based filter > - > > Key: SCB-706 > URL: https://issues.apache.org/jira/browse/SCB-706 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > > Why we do this? > # When implement invocation based filter, e.g. darklaunch deployment, we > need to filter servers based on invocation parameters. But now, we create a > Loadbalaner instance for each service, and Robin filter interface can not > pass Invocation to it. Before refactor, we doing this by ThreadLocal and > cache Invocation, and use in filter implementation. This is error prone and > users can't handle this complixity > # We have other improvements, e.g. SCB-700, we can do server status check, > and add a filter a choose from active servers. We need to consider filter > orders and other feature, current implementation not satisfy this. > # We want to make loadbalance code handy by remove some compatible fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-706) refactor loadbalance filters logic to support invocation based filter
[ https://issues.apache.org/jira/browse/SCB-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540242#comment-16540242 ] ASF GitHub Bot commented on SCB-706: liubao68 opened a new pull request #803: [SCB-706]change filters to discovery filters and support invocation based filters URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/803 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > refactor loadbalance filters logic to support invocation based filter > - > > Key: SCB-706 > URL: https://issues.apache.org/jira/browse/SCB-706 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > > Why we do this? > # When implement invocation based filter, e.g. darklaunch deployment, we > need to filter servers based on invocation parameters. But now, we create a > Loadbalaner instance for each service, and Robin filter interface can not > pass Invocation to it. Before refactor, we doing this by ThreadLocal and > cache Invocation, and use in filter implementation. This is error prone and > users can't handle this complixity > # We have other improvements, e.g. SCB-700, we can do server status check, > and add a filter a choose from active servers. We need to consider filter > orders and other feature, current implementation not satisfy this. > # We want to make loadbalance code handy by remove some compatible fixes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-733) open handlerContext for business logic, and add a new name: localContext
[ https://issues.apache.org/jira/browse/SCB-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540193#comment-16540193 ] ASF GitHub Bot commented on SCB-733: coveralls commented on issue #802: [SCB-733] open handlerContext for business logic, and add a new name:localContext URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/802#issuecomment-404198022 [](https://coveralls.io/builds/17935344) Coverage increased (+0.008%) to 87.138% when pulling **be663ca6946ea981f0a73495c753e495a37b393b on wujimin:add-localContext** into **b00f4c748122460ba1484815ed9c98eadf9eba31 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > open handlerContext for business logic, and add a new name: localContext > > > Key: SCB-733 > URL: https://issues.apache.org/jira/browse/SCB-733 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-725) support get main class package when run with "java -jar xxx.jar"
[ https://issues.apache.org/jira/browse/SCB-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin resolved SCB-725. - Resolution: Done Fix Version/s: java-chassis-1.0.0 > support get main class package when run with "java -jar xxx.jar" > > > Key: SCB-725 > URL: https://issues.apache.org/jira/browse/SCB-725 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-733) open handlerContext for business logic, and add a new name: localContext
[ https://issues.apache.org/jira/browse/SCB-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540143#comment-16540143 ] ASF GitHub Bot commented on SCB-733: wujimin opened a new pull request #802: [SCB-733] open handlerContext for business logic, and add a new name:localContext URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/802 this makes developers easier to save data to invocation, and used them in HttpServerFilter.beforeSendResponse This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > open handlerContext for business logic, and add a new name: localContext > > > Key: SCB-733 > URL: https://issues.apache.org/jira/browse/SCB-733 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-735) Add admin dump api
[
https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540018#comment-16540018
]
ASF GitHub Bot commented on SCB-735:
little-cui closed pull request #389: SCB-735 Add admin dump api
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/389
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/admin/admin.go b/server/admin/admin.go
new file mode 100644
index ..304b5094
--- /dev/null
+++ b/server/admin/admin.go
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package admin
+
+import (
+ roa "github.com/apache/incubator-servicecomb-service-center/pkg/rest"
+)
+
+func init() {
+ registerREST()
+}
+
+func registerREST() {
+ roa.RegisterServent({})
+}
diff --git a/server/admin/admin_suite_test.go b/server/admin/admin_suite_test.go
new file mode 100644
index ..d2444ea1
--- /dev/null
+++ b/server/admin/admin_suite_test.go
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package admin
+
+import (
+ "github.com/apache/incubator-servicecomb-service-center/pkg/util"
+ _
"github.com/apache/incubator-servicecomb-service-center/server/plugin/infra/quota/buildin"
+ _
"github.com/apache/incubator-servicecomb-service-center/server/plugin/infra/registry/etcd"
+ _
"github.com/apache/incubator-servicecomb-service-center/server/plugin/infra/uuid/buildin"
+ . "github.com/onsi/ginkgo"
+ "github.com/onsi/ginkgo/reporters"
+ . "github.com/onsi/gomega"
+ "golang.org/x/net/context"
+ "testing"
+)
+
+func TestAdmin(t *testing.T) {
+ RegisterFailHandler(Fail)
+ junitReporter := reporters.NewJUnitReporter("model.junit.xml")
+ RunSpecsWithDefaultAndCustomReporters(t, "model Suite",
[]Reporter{junitReporter})
+}
+
+var _ = BeforeSuite(func() {
+ //init plugin
+})
+
+func getContext() context.Context {
+ return util.SetContext(
+ util.SetDomainProject(context.Background(), "default",
"default"),
+ "noCache", "1")
+}
diff --git a/server/admin/controller_v4.go b/server/admin/controller_v4.go
new file mode 100644
index ..5fd786a1
--- /dev/null
+++ b/server/admin/controller_v4.go
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package admin
+
+import (
+ "net/http"
+
+
[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540007#comment-16540007 ] ASF GitHub Bot commented on SCB-735: coveralls commented on issue #389: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/389#issuecomment-404148475 [](https://coveralls.io/builds/17932810) Coverage decreased (-0.1%) to 74.301% when pulling **c4968dd65f8005170372761602e3faae67cee282 on little-cui:admin** into **fc6664cc646c52a01b7934e3b20fa801510146f2 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add admin dump api > -- > > Key: SCB-735 > URL: https://issues.apache.org/jira/browse/SCB-735 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540006#comment-16540006 ] ASF GitHub Bot commented on SCB-735: codecov-io commented on issue #389: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/389#issuecomment-404148335 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/389?src=pr=h1) Report > Merging [#389](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/389?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/fc6664cc646c52a01b7934e3b20fa801510146f2?src=pr=desc) will **decrease** coverage by `0.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/389?src=pr=tree) ```diff @@Coverage Diff @@ ## master #389 +/- ## == - Coverage 71.54% 71.49% -0.05% == Files 39 39 Lines4126 4126 == - Hits 2952 2950 -2 Misses 1007 1007 - Partials 167 169 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/389?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/389/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `80.28% <0%> (-0.71%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/389/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `68.32% <0%> (-0.63%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/389?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/389?src=pr=footer). Last update [fc6664c...c4968dd](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/389?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add admin dump api > -- > > Key: SCB-735 > URL: https://issues.apache.org/jira/browse/SCB-735 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-735) Add admin dump api
[ https://issues.apache.org/jira/browse/SCB-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539995#comment-16539995 ] ASF GitHub Bot commented on SCB-735: little-cui opened a new pull request #389: SCB-735 Add admin dump api URL: https://github.com/apache/incubator-servicecomb-service-center/pull/389 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add admin dump api > -- > > Key: SCB-735 > URL: https://issues.apache.org/jira/browse/SCB-735 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-732) Add the omega-transport-feign into distribution kit
[ https://issues.apache.org/jira/browse/SCB-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539977#comment-16539977 ] ASF GitHub Bot commented on SCB-732: WillemJiang closed pull request #215: SCB-732 Add the omega-transport-feign into distribution kit and updated LICENSE URL: https://github.com/apache/incubator-servicecomb-saga/pull/215 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/saga-distribution/pom.xml b/saga-distribution/pom.xml index 675d1103..aeab76a8 100644 --- a/saga-distribution/pom.xml +++ b/saga-distribution/pom.xml @@ -47,6 +47,10 @@ org.apache.servicecomb.saga omega-transport-dubbo + +org.apache.servicecomb.saga +omega-transport-feign + org.apache.servicecomb.saga omega-connector-grpc diff --git a/saga-distribution/src/release/LICENSE b/saga-distribution/src/release/LICENSE index 6fce523e..c2f30f87 100644 --- a/saga-distribution/src/release/LICENSE +++ b/saga-distribution/src/release/LICENSE @@ -302,6 +302,14 @@ This product bundles Boringssl which is licensed under BSD style licenses. For details, see https://github.com/google/boringssl You can find a copy of the License at licenses/LICENSE-boringssl +=== +For io.github.openfeign:feign-core:9.5.1 +=== +This product bundles spring-cloud-openfeign which is licensed under the +Apache License 2.0. +For details, see https://github.com/spring-cloud/spring-cloud-openfeign.git +You can find a copy of the License at licenses/LICENSE-openfeign + This product bundles the following libraries which are licensed under the Apache License v2. diff --git a/saga-distribution/src/release/licenses/LICENSE-openfeign b/saga-distribution/src/release/licenses/LICENSE-openfeign new file mode 100644 index ..3c50eb3e --- /dev/null +++ b/saga-distribution/src/release/licenses/LICENSE-openfeign @@ -0,0 +1,201 @@ + + Version 2.0, January 2004 +http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally +
[jira] [Commented] (SCB-732) Add the omega-transport-feign into distribution kit
[ https://issues.apache.org/jira/browse/SCB-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539980#comment-16539980 ] ASF GitHub Bot commented on SCB-732: WillemJiang commented on issue #215: SCB-732 Add the omega-transport-feign into distribution kit and updated LICENSE URL: https://github.com/apache/incubator-servicecomb-saga/pull/215#issuecomment-404144038 Thx for the contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add the omega-transport-feign into distribution kit > --- > > Key: SCB-732 > URL: https://issues.apache.org/jira/browse/SCB-732 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Willem Jiang >Priority: Major > > We need to update the saga-distribution pom.xml file. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml > > We need add the third party dependency of > io.github.openfeign:feign-core:jar:9.5.1 into the release license file as > well. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-720) Show the instance statistics in Dashboard and Instance List in Side Menu
[ https://issues.apache.org/jira/browse/SCB-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui reassigned SCB-720: -- Assignee: vibakar (was: Mohammad Asif Siddiqui) > Show the instance statistics in Dashboard and Instance List in Side Menu > > > Key: SCB-720 > URL: https://issues.apache.org/jira/browse/SCB-720 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: vibakar >Priority: Major > Fix For: service-center-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-720) Show the instance statistics in Dashboard and Instance List in Side Menu
[ https://issues.apache.org/jira/browse/SCB-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui reassigned SCB-720: -- Assignee: vibakar (was: Mohammad Asif Siddiqui) > Show the instance statistics in Dashboard and Instance List in Side Menu > > > Key: SCB-720 > URL: https://issues.apache.org/jira/browse/SCB-720 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: vibakar >Priority: Major > Fix For: service-center-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-720) Show the instance statistics in Dashboard and Instance List in Side Menu
[ https://issues.apache.org/jira/browse/SCB-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui reassigned SCB-720: -- Assignee: Mohammad Asif Siddiqui (was: vibakar) > Show the instance statistics in Dashboard and Instance List in Side Menu > > > Key: SCB-720 > URL: https://issues.apache.org/jira/browse/SCB-720 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-735) Add admin dump api
little-cui created SCB-735: -- Summary: Add admin dump api Key: SCB-735 URL: https://issues.apache.org/jira/browse/SCB-735 Project: Apache ServiceComb Issue Type: New Feature Components: Service-Center Reporter: little-cui Assignee: little-cui -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-680) Optimize find instance api
[ https://issues.apache.org/jira/browse/SCB-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui resolved SCB-680. Resolution: Fixed > Optimize find instance api > -- > > Key: SCB-680 > URL: https://issues.apache.org/jira/browse/SCB-680 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-714) Support TLS plugin
[ https://issues.apache.org/jira/browse/SCB-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui resolved SCB-714. Resolution: Fixed > Support TLS plugin > -- > > Key: SCB-714 > URL: https://issues.apache.org/jira/browse/SCB-714 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-734) Provide DSL support for building the Saga invocations
[ https://issues.apache.org/jira/browse/SCB-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-734: - Summary: Provide DSL support for building the Saga invocations (was: Provide DSL support for building the Saga invoations) > Provide DSL support for building the Saga invocations > - > > Key: SCB-734 > URL: https://issues.apache.org/jira/browse/SCB-734 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Willem Jiang >Priority: Major > > Current Saga implementation just take the json request to build the > invocation, it could be more convince if we have a builder class to specify > the sub saga invocations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-734) Provide DSL support for building the Saga invoations
Willem Jiang created SCB-734: Summary: Provide DSL support for building the Saga invoations Key: SCB-734 URL: https://issues.apache.org/jira/browse/SCB-734 Project: Apache ServiceComb Issue Type: New Feature Components: Saga Reporter: Willem Jiang Current Saga implementation just take the json request to build the invocation, it could be more convince if we have a builder class to specify the sub saga invocations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-340) [pack] load balance omega
[ https://issues.apache.org/jira/browse/SCB-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-340: - Fix Version/s: (was: saga-0.3.0) > [pack] load balance omega > - > > Key: SCB-340 > URL: https://issues.apache.org/jira/browse/SCB-340 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Affects Versions: saga-0.2.0 >Reporter: Eric Lee >Priority: Major > > As omega is stateless, there is no need to store instanceId any more. > However, we need to load balance the access to omegas in case of too much > stress on some omegas. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-732) Add the omega-transport-feign into distribution kit
[ https://issues.apache.org/jira/browse/SCB-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539752#comment-16539752 ] ASF GitHub Bot commented on SCB-732: Lionelpang closed pull request #214: [SCB-732] add omega-transport-feign to distribution and add the omega-transport-feign into distribution kit URL: https://github.com/apache/incubator-servicecomb-saga/pull/214 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add the omega-transport-feign into distribution kit > --- > > Key: SCB-732 > URL: https://issues.apache.org/jira/browse/SCB-732 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Willem Jiang >Priority: Major > > We need to update the saga-distribution pom.xml file. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml > > We need add the third party dependency of > io.github.openfeign:feign-core:jar:9.5.1 into the release license file as > well. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-732) Add the omega-transport-feign into distribution kit
[ https://issues.apache.org/jira/browse/SCB-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539738#comment-16539738 ] ASF GitHub Bot commented on SCB-732: coveralls commented on issue #214: [SCB-732] add omega-transport-feign to distribution and add the omega-transport-feign into distribution kit URL: https://github.com/apache/incubator-servicecomb-saga/pull/214#issuecomment-404093173 [](https://coveralls.io/builds/17929884) Coverage decreased (-0.4%) to 92.825% when pulling **f4fa2b5bdd76ab294f53442061deb86231b84a33 on Lionelpang:master** into **aee3a98e2a3846f8a5732d974a56b0cc46dff542 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add the omega-transport-feign into distribution kit > --- > > Key: SCB-732 > URL: https://issues.apache.org/jira/browse/SCB-732 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Willem Jiang >Priority: Major > > We need to update the saga-distribution pom.xml file. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml > > We need add the third party dependency of > io.github.openfeign:feign-core:jar:9.5.1 into the release license file as > well. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-732) Add the omega-transport-feign into distribution kit
[ https://issues.apache.org/jira/browse/SCB-732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539725#comment-16539725 ] ASF GitHub Bot commented on SCB-732: Lionelpang opened a new pull request #214: [SCB-732] add omega-transport-feign to distribution and add the omega-transport-feign into distribution kit URL: https://github.com/apache/incubator-servicecomb-saga/pull/214 1. add omega-transport-feign to distribution 2. Add the omega-transport-feign into distribution kit --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add the omega-transport-feign into distribution kit > --- > > Key: SCB-732 > URL: https://issues.apache.org/jira/browse/SCB-732 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Willem Jiang >Priority: Major > > We need to update the saga-distribution pom.xml file. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml > > We need add the third party dependency of > io.github.openfeign:feign-core:jar:9.5.1 into the release license file as > well. > > https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-733) open handlerContext for business logic, and add a new name: localContext
wujimin created SCB-733: --- Summary: open handlerContext for business logic, and add a new name: localContext Key: SCB-733 URL: https://issues.apache.org/jira/browse/SCB-733 Project: Apache ServiceComb Issue Type: Task Components: Java-Chassis Reporter: wujimin Assignee: wujimin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-725) support get main class package when run with "java -jar xxx.jar"
[
https://issues.apache.org/jira/browse/SCB-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539680#comment-16539680
]
ASF GitHub Bot commented on SCB-725:
wujimin closed pull request #799: [SCB-725] support get main class package when
run with "java -jar xxx.jar
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/799
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
index 48a9baab4..bb02d725e 100644
---
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
+++
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
@@ -16,6 +16,12 @@
*/
package org.apache.servicecomb.foundation.common.utils;
+import java.io.File;
+import java.io.InputStream;
+import java.net.URL;
+import java.util.jar.JarFile;
+import java.util.jar.Manifest;
+
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -36,21 +42,50 @@ private JvmUtils() {
* @return main class or null, never throw exception
*/
public static Class findMainClass() {
+// 1.run with java -cp ..
+// command is main class and args
+// 2.run with java -jar ..
+// command is jar file name and args
String command = System.getProperty(SUN_JAVA_COMMAND);
if (command == null || command.isEmpty()) {
return null;
}
-// command is main class and args
-String mainClass = command.trim().split(" ")[0];
+String mainClassOrJar = command.trim().split(" ")[0];
+String mainClass = readFromJar(mainClassOrJar);
+if (mainClass == null || mainClass.isEmpty()) {
+ return null;
+}
+
try {
- return Class.forName(mainClass);
+ Class cls = Class.forName(mainClass);
+ LOGGER.info("Found main class \"{}\".", mainClass);
+ return cls;
} catch (Throwable e) {
LOGGER.warn("\"{}\" is not a valid class.", mainClass, e);
return null;
}
}
+ private static String readFromJar(String mainClassOrJar) {
+if (!mainClassOrJar.endsWith(".jar")) {
+ return mainClassOrJar;
+}
+
+String manifestUri = "jar:file:/" + new
File(mainClassOrJar).getAbsolutePath() + "!/" + JarFile.MANIFEST_NAME;
+
+try {
+ URL url = new URL(manifestUri);
+ try (InputStream inputStream = url.openStream()) {
+Manifest manifest = new Manifest(inputStream);
+return manifest.getMainAttributes().getValue("Main-Class");
+ }
+} catch (Throwable e) {
+ LOGGER.warn("Failed to read Main-Class from \"{}\".", manifestUri, e);
+ return null;
+}
+ }
+
/**
* find a property class loader to avoid null
*/
diff --git
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
index d16792f3e..257c8f407 100644
---
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
+++
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
@@ -16,12 +16,24 @@
*/
package org.apache.servicecomb.foundation.common.utils;
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.InputStream;
+import java.net.URL;
+import java.util.jar.JarFile;
+
import org.apache.servicecomb.foundation.test.scaffolding.log.LogCollector;
import org.junit.AfterClass;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.powermock.api.mockito.PowerMockito;
+import org.powermock.core.classloader.annotations.PrepareForTest;
+import org.powermock.modules.junit4.PowerMockRunner;
+@RunWith(PowerMockRunner.class)
+@PrepareForTest({JvmUtils.class})
public class TestJvmUtils {
static String orgCmd = System.getProperty(JvmUtils.SUN_JAVA_COMMAND);
@@ -63,9 +75,63 @@ public void findMainClass_invalid() {
}
@Test
- public void findMainClass_normal() {
+ public void findMainClass_class_normal() {
System.setProperty(JvmUtils.SUN_JAVA_COMMAND, TestJvmUtils.class.getName()
+ " arg");
Assert.assertEquals(TestJvmUtils.class, JvmUtils.findMainClass());
}
+
+ @Test
+ public void findMainClass_jar_normal() throws Exception {
+String content = String.format("Manifest-Version: 1.0\nMain-Class: %s\n",
[jira] [Created] (SCB-732) Add the omega-transport-feign into distribution kit
Willem Jiang created SCB-732: Summary: Add the omega-transport-feign into distribution kit Key: SCB-732 URL: https://issues.apache.org/jira/browse/SCB-732 Project: Apache ServiceComb Issue Type: New Feature Components: Saga Reporter: Willem Jiang We need to update the saga-distribution pom.xml file. https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml We need add the third party dependency of io.github.openfeign:feign-core:jar:9.5.1 into the release license file as well. https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-731) Add the omega-transport-feign into distribution kit
Willem Jiang created SCB-731: Summary: Add the omega-transport-feign into distribution kit Key: SCB-731 URL: https://issues.apache.org/jira/browse/SCB-731 Project: Apache ServiceComb Issue Type: New Feature Components: Saga Reporter: Willem Jiang We need to update the saga-distribution pom.xml file. https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/pom.xml We need add the third party dependency of io.github.openfeign:feign-core:jar:9.5.1 into the release license file as well. https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-727) Java Chassis-Local generated schema and service center schema are different while registering the service then print the difference content
[ https://issues.apache.org/jira/browse/SCB-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539637#comment-16539637 ] ASF GitHub Bot commented on SCB-727: coveralls edited a comment on issue #801: [SCB-727] Local generated schema and service center schema are different then print the diff content to the user URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/801#issuecomment-403832092 [](https://coveralls.io/builds/17928723) Coverage increased (+0.01%) to 87.201% when pulling **41c232aed162b41ba37bd6466ea32377b3a4ab73 on maheshrajus:master** into **0c61dd9b122718f75fe4845940ec6f372046078f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Java Chassis-Local generated schema and service center schema are different > while registering the service then print the difference content > --- > > Key: SCB-727 > URL: https://issues.apache.org/jira/browse/SCB-727 > Project: Apache ServiceComb > Issue Type: Improvement >Affects Versions: java-chassis-1.0.0 >Reporter: Mahesh Raju Somalaraju >Assignee: Mahesh Raju Somalaraju >Priority: Major > Fix For: java-chassis-1.0.0 > > > Java Chassis- Local generated schema and service center schema are different > while registering the service then print the difference content. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-725) support get main class package when run with "java -jar xxx.jar"
[
https://issues.apache.org/jira/browse/SCB-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539631#comment-16539631
]
ASF GitHub Bot commented on SCB-725:
WillemJiang commented on a change in pull request #799: [SCB-725] support get
main class package when run with "java -jar xxx.jar
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/799#discussion_r201578064
##
File path:
foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
##
@@ -36,21 +42,50 @@ private JvmUtils() {
* @return main class or null, never throw exception
*/
public static Class findMainClass() {
+// 1.run with java -cp ..
+// command is main class and args
+// 2.run with java -jar ..
+// command is jar file name and args
String command = System.getProperty(SUN_JAVA_COMMAND);
if (command == null || command.isEmpty()) {
return null;
}
-// command is main class and args
-String mainClass = command.trim().split(" ")[0];
+String mainClassOrJar = command.trim().split(" ")[0];
+String mainClass = readFromJar(mainClassOrJar);
+if (mainClass == null || mainClass.isEmpty()) {
+ return null;
Review comment:
OK
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support get main class package when run with "java -jar xxx.jar"
>
>
> Key: SCB-725
> URL: https://issues.apache.org/jira/browse/SCB-725
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-727) Java Chassis-Local generated schema and service center schema are different while registering the service then print the difference content
[ https://issues.apache.org/jira/browse/SCB-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539621#comment-16539621 ] ASF GitHub Bot commented on SCB-727: maheshrajus commented on issue #801: [SCB-727] Local generated schema and service center schema are different then print the diff content to the user URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/801#issuecomment-404058542 Added UT case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Java Chassis-Local generated schema and service center schema are different > while registering the service then print the difference content > --- > > Key: SCB-727 > URL: https://issues.apache.org/jira/browse/SCB-727 > Project: Apache ServiceComb > Issue Type: Improvement >Affects Versions: java-chassis-1.0.0 >Reporter: Mahesh Raju Somalaraju >Assignee: Mahesh Raju Somalaraju >Priority: Major > Fix For: java-chassis-1.0.0 > > > Java Chassis- Local generated schema and service center schema are different > while registering the service then print the difference content. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
